Re: [Buildroot] [PATCH] toolchain/custom: hide away incompatible gcc versions

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Romain Naour <romain.naour@gmail.com>,
	Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] toolchain/custom: hide away incompatible gcc versions
Date: Sun, 19 Sep 2021 14:28:45 +0200	[thread overview]
Message-ID: <20210919122845.GT1053080@scaer> (raw)
In-Reply-To: <20210919140237.6cf62fa5@windsurf>

Thomas, All,

On 2021-09-19 14:02 +0200, Thomas Petazzoni spake thusly:
> On Sun, 19 Sep 2021 13:45:47 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > Some CPUs have a requirement on a minimal gcc version. Until now, ot was
> > possible to use a custom external toolchain that has a gcc older than
> > the requirement, which would lead to build failures (early!) during the
> > build.
> > 
> > Propagate the gcc version requirement down to the external toolchain gcc
> > version choice. By limiting the selection to acceptable gcc versions, we
> > inform the user that its toolchain is too old, and if they decide to lie
> > and select one of available version, we still check that when we extract
> > and install their toolchain.
> 
> I think there was a reason to not have these for external toolchains:
> they can use patched gcc versions that support newer CPU cores that are
> normally not supported in the same gcc upstream version. It was for
> example the case I believe at some point for Linaro toolchains.
> 
> This argument is not necessarily a strong disagreement against your
> patch, I'm just stating why I believe we hadn't done that in the past.

OK, I see the point, and I agree.

> BTW, has there been some recent issue that prompted you to write/submit
> this change ?

No. I was looking at the mips CPUs entries, and I was just looking where
all those BR2_ARCH_NEEDS_GCC_AT_LEAST_xxx were used, and  suddenly my two
neurons collided one with the other, and made me check the custom
toolchains...

But OK, as I was also one to lift some custom toolchain limitations to
account for backported features, the current situation is fine.

I'll drop my patch.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot