From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>,
Romain Naour <romain.naour@gmail.com>,
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] toolchain/custom: hide away incompatible gcc versions
Date: Sun, 19 Sep 2021 14:02:37 +0200 [thread overview]
Message-ID: <20210919140237.6cf62fa5@windsurf> (raw)
In-Reply-To: <20210919114547.103955-1-yann.morin.1998@free.fr>
Hello,
On Sun, 19 Sep 2021 13:45:47 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> Some CPUs have a requirement on a minimal gcc version. Until now, ot was
> possible to use a custom external toolchain that has a gcc older than
> the requirement, which would lead to build failures (early!) during the
> build.
>
> Propagate the gcc version requirement down to the external toolchain gcc
> version choice. By limiting the selection to acceptable gcc versions, we
> inform the user that its toolchain is too old, and if they decide to lie
> and select one of available version, we still check that when we extract
> and install their toolchain.
I think there was a reason to not have these for external toolchains:
they can use patched gcc versions that support newer CPU cores that are
normally not supported in the same gcc upstream version. It was for
example the case I believe at some point for Linaro toolchains.
This argument is not necessarily a strong disagreement against your
patch, I'm just stating why I believe we hadn't done that in the past.
BTW, has there been some recent issue that prompted you to write/submit
this change ?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-09-19 12:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-19 11:45 [Buildroot] [PATCH] toolchain/custom: hide away incompatible gcc versions Yann E. MORIN
2021-09-19 12:02 ` Thomas Petazzoni [this message]
2021-09-19 12:28 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210919140237.6cf62fa5@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=romain.naour@gmail.com \
--cc=thomas.de_schampheleire@nokia.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox