From: Adrian Perez de Castro <aperez@igalia.com>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: James Hilliard <james.hilliard1@gmail.com>,
Philippe Normand <philn@igalia.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/wpewebkit: remove gst1-plugins-good from dependencies
Date: Fri, 1 Oct 2021 13:35:54 +0300 [thread overview]
Message-ID: <20211001133554.GE1057162@momiji> (raw)
In-Reply-To: <20211001132559.GC1057162@momiji>
[-- Attachment #1.1: Type: text/plain, Size: 1274 bytes --]
On Fri, 01 Oct 2021 13:25:59 +0300 Adrian Perez de Castro <aperez@igalia.com> wrote:
> On Fri, 24 Sep 2021 06:45:25 -0600 James Hilliard <james.hilliard1@gmail.com> wrote:
> > This is only a runtime dependency not a build dependency.
> >
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>
> Reviewed-by: Adrian perez de Castro <aperez@igalia.com>
>
> > ---
> > package/wpewebkit/wpewebkit.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
> > index 5c5e6625f8..50714b4366 100644
> > --- a/package/wpewebkit/wpewebkit.mk
> > +++ b/package/wpewebkit/wpewebkit.mk
> > @@ -39,7 +39,7 @@ ifeq ($(BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA),y)
> > WPEWEBKIT_CONF_OPTS += \
> > -DENABLE_VIDEO=ON \
> > -DENABLE_WEB_AUDIO=ON
> > -WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good
> > +WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base
> > else
> > WPEWEBKIT_CONF_OPTS += \
> > -DENABLE_VIDEO=OFF \
> > --
> > 2.25.1
> >
>
> We should do the same edit in package/webkitgtk/webkitgtk.mk :)
Done in https://patchwork.ozlabs.org/project/buildroot/patch/20211001103417.1078082-1-aperez@igalia.com/
Cheers,
—Adrián
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-10-01 10:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 12:45 [Buildroot] [PATCH 1/1] package/wpewebkit: remove gst1-plugins-good from dependencies James Hilliard
2021-10-01 10:25 ` Adrian Perez de Castro
2021-10-01 10:35 ` Adrian Perez de Castro [this message]
2021-10-03 20:15 ` Yann E. MORIN
2021-10-06 15:18 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211001133554.GE1057162@momiji \
--to=aperez@igalia.com \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=philn@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox