From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Adrian Perez de Castro <aperez@igalia.com>,
James Hilliard <james.hilliard1@gmail.com>,
Philippe Normand <philn@igalia.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/wpewebkit: remove gst1-plugins-good from dependencies
Date: Wed, 06 Oct 2021 17:18:11 +0200 [thread overview]
Message-ID: <87bl425gi4.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20211003201527.GX1504958@scaer> (Yann E. MORIN's message of "Sun, 3 Oct 2021 22:15:27 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> James, All,
> On 2021-09-24 06:45 -0600, James Hilliard spake thusly:
>> This is only a runtime dependency not a build dependency.
>>
>> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> Applied to master, thanks.
> Regards,
> Yann E. MORIN.
>> ---
>> package/wpewebkit/wpewebkit.mk | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
>> index 5c5e6625f8..50714b4366 100644
>> --- a/package/wpewebkit/wpewebkit.mk
>> +++ b/package/wpewebkit/wpewebkit.mk
>> @@ -39,7 +39,7 @@ ifeq ($(BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA),y)
>> WPEWEBKIT_CONF_OPTS += \
>> -DENABLE_VIDEO=ON \
>> -DENABLE_WEB_AUDIO=ON
>> -WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good
>> +WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base
NIT: we normally add a # runtime comment to the select line in Config.in
then to make it clear why it isn't listed in _DEPENDENCIES.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-10-06 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 12:45 [Buildroot] [PATCH 1/1] package/wpewebkit: remove gst1-plugins-good from dependencies James Hilliard
2021-10-01 10:25 ` Adrian Perez de Castro
2021-10-01 10:35 ` Adrian Perez de Castro
2021-10-03 20:15 ` Yann E. MORIN
2021-10-06 15:18 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl425gi4.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=aperez@igalia.com \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=philn@igalia.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox