From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/ltrace: fix autoreconf with autoconf >= 2.70
Date: Sat, 9 Oct 2021 22:09:08 +0200 [thread overview]
Message-ID: <20211009220908.39301a19@windsurf> (raw)
In-Reply-To: <20211009075004.370428-1-fontaine.fabrice@gmail.com>
On Sat, 9 Oct 2021 09:50:04 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fix the following build failure raised since bump of autoconf to version
> 2.71 in commit ecd54b65c1f998a7ccd91f7c523e4ff38c4781da:
>
> autoreconf: error: cannot create config/autoconf: No such file or directory
>
> Fixes:
> - http://autobuild.buildroot.org/results/433599039d6e1ee301465f9867e169c121a0646f
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> ...ac-fix-autoreconf-with-autoconf-2.70.patch | 35 +++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 package/ltrace/0003-configure.ac-fix-autoreconf-with-autoconf-2.70.patch
I've extended the explanation to indicate why removing the
AC_CONFIG_AUX_DIR invocation is OK: it's because there is no
config/autoconf directory. I think your commit log should try to
explain why a change is OK, not just "we're removing stuff to fix a
build failure".
Applied to master with the extended commit log. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-10-09 20:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 7:50 [Buildroot] [PATCH 1/1] package/ltrace: fix autoreconf with autoconf >= 2.70 Fabrice Fontaine
2021-10-09 20:09 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211009220908.39301a19@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox