Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Michael Fischer <mf@go-sys.de>,
	Romain Naour <romain.naour@gmail.com>,
	Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 2/5] package/gdb: add support for gdb 11.x
Date: Sun, 10 Oct 2021 11:10:59 +0200	[thread overview]
Message-ID: <20211010091059.GK2081069@scaer> (raw)
In-Reply-To: <20211009191646.1076266-3-thomas.petazzoni@bootlin.com>

Thomas, All,

On 2021-10-09 21:16 +0200, Thomas Petazzoni spake thusly:
> From: Michael Fischer <mf@go-sys.de>
> Starting from version 11.x, gdb needs the gmp library.
[--SNIP--]
> diff --git a/package/gdb/Config.in b/package/gdb/Config.in
> index 246748131e..d5ec5406fb 100644
> --- a/package/gdb/Config.in
> +++ b/package/gdb/Config.in
> @@ -54,6 +54,7 @@ config BR2_PACKAGE_GDB_DEBUGGER
>  	depends on BR2_USE_WCHAR
>  	depends on !BR2_sh
>  	depends on !BR2_csky
> +	select BR2_PACKAGE_GMP

This one looks a bit dubious...

If the host gdb is enabled, then the target gdb is the same version as
the host version. So, this configuration:

    BR2_PACKAGE_HOST_GDB=y
    BR2_PACKAGE_GDB=y
    BR2_GDB_VERSION_10=y

will yield a configuration that will force the target gmp, even though
the target gdb will not use it.

Or did I miss something?

I can fix that when applying:

    select BR2_PACKAGE_GMP if BR2_GDB_VERSION_11

The reasoning is that, BR2_GDB_VERSION_11 can only be set when the host
gdb is enabled.

So, if BR2_GDB_VERSION_11 is not set, either:

  - the host gdb is not enabled, in which case the default for the
    target gdb is 9.x (with next patch, 10.x), or

  - the host gdb is enabled, and another version is selected.

Thoughts?

Of course, that will need some refinments when we introduce gdb 12.x (if
it still needs gmp). But for now, introducing either
BR2_PACKAGE_GDB_NEEDS_GMP of BR2_PACKAGE_GDB_11_X_or_later seemed a bit
heavy-handed...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-10-10  9:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09 19:16 [Buildroot] [PATCH 0/5] GDB updates Thomas Petazzoni
2021-10-09 19:16 ` [Buildroot] [PATCH 1/5] package/gdb: append to dependencies in conditional Thomas Petazzoni
2021-10-10  8:49   ` Yann E. MORIN
2021-10-10 10:05     ` Peter Korsgaard
2021-10-10 13:57     ` Thomas Petazzoni
2021-10-09 19:16 ` [Buildroot] [PATCH 2/5] package/gdb: add support for gdb 11.x Thomas Petazzoni
2021-10-10  9:10   ` Yann E. MORIN [this message]
2021-10-10 13:57     ` Thomas Petazzoni
2021-10-10 17:42       ` Yann E. MORIN
2021-10-09 19:16 ` [Buildroot] [PATCH 3/5] package/gdb: switch to gdb 10.x as the default Thomas Petazzoni
2021-10-10 17:42   ` Yann E. MORIN
2021-10-09 19:16 ` [Buildroot] [PATCH 4/5] package/gdb: drop support for version 8.3.x Thomas Petazzoni
2021-10-10 17:42   ` Yann E. MORIN
2021-10-09 19:16 ` [Buildroot] [PATCH 5/5] support/testing: add suite of tests for gdb Thomas Petazzoni
2021-10-10 17:43   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211010091059.GK2081069@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=mf@go-sys.de \
    --cc=romain.naour@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox