From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Michael Fischer <mf@go-sys.de>,
Romain Naour <romain.naour@gmail.com>,
Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 3/5] package/gdb: switch to gdb 10.x as the default
Date: Sun, 10 Oct 2021 19:42:35 +0200 [thread overview]
Message-ID: <20211010174235.GM2081069@scaer> (raw)
In-Reply-To: <20211009191646.1076266-4-thomas.petazzoni@bootlin.com>
Thomas, All,
On 2021-10-09 21:16 +0200, Thomas Petazzoni spake thusly:
> When doing this, we can simplify the RISC-V related logic. Indeed, as
> there was no support for RISC-V in gdb 9.x, which was the current
> default, we had some trickery in the Config.in file to ensure gdb 10.x
> was used by default on RISC-V. However now that 10.x is the default
> for everybody, this trickery is no longer needed.
>
> Also, we now needs to enable BR2_PACKAGE_GDB_TOPLEVEL when host-gdb is
> not built, as the default target gdb version is 10.x, and threfore
> requires BR2_PACKAGE_GDB_TOPLEVEL=y.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/gdb/Config.in.host | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/package/gdb/Config.in.host b/package/gdb/Config.in.host
> index 2f9790f6e1..fd739f3969 100644
> --- a/package/gdb/Config.in.host
> +++ b/package/gdb/Config.in.host
> @@ -61,7 +61,7 @@ config BR2_PACKAGE_HOST_GDB_SIM
>
> choice
> prompt "GDB debugger Version"
> - default BR2_GDB_VERSION_9_2
> + default BR2_GDB_VERSION_10
> depends on !BR2_arc
> depends on !BR2_csky
> help
> @@ -93,8 +93,8 @@ config BR2_GDB_VERSION
> default "arc-2020.09-release-gdb" if BR2_arc
> default "4ecb98fbc2f94dbe01b69384afbc515107de73df" if BR2_csky
> default "8.3.1" if BR2_GDB_VERSION_8_3
> - default "9.2" if BR2_GDB_VERSION_9_2 || (!BR2_PACKAGE_HOST_GDB && !BR2_riscv)
> - default "10.2" if BR2_GDB_VERSION_10 || (!BR2_PACKAGE_HOST_GDB && BR2_riscv)
> + default "9.2" if BR2_GDB_VERSION_9_2
> + default "10.2" if BR2_GDB_VERSION_10 || !BR2_PACKAGE_HOST_GDB
> default "11.1" if BR2_GDB_VERSION_11
> depends on BR2_PACKAGE_GDB || BR2_PACKAGE_HOST_GDB
>
> @@ -105,5 +105,5 @@ config BR2_PACKAGE_GDB_TOPLEVEL
> default y if BR2_arc
> default y if BR2_GDB_VERSION_10
> default y if BR2_GDB_VERSION_11
> - default y if !BR2_PACKAGE_HOST_GDB && BR2_riscv
> + default y if !BR2_PACKAGE_HOST_GDB
> depends on BR2_PACKAGE_GDB || BR2_PACKAGE_HOST_GDB
> --
> 2.31.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-10-10 17:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 19:16 [Buildroot] [PATCH 0/5] GDB updates Thomas Petazzoni
2021-10-09 19:16 ` [Buildroot] [PATCH 1/5] package/gdb: append to dependencies in conditional Thomas Petazzoni
2021-10-10 8:49 ` Yann E. MORIN
2021-10-10 10:05 ` Peter Korsgaard
2021-10-10 13:57 ` Thomas Petazzoni
2021-10-09 19:16 ` [Buildroot] [PATCH 2/5] package/gdb: add support for gdb 11.x Thomas Petazzoni
2021-10-10 9:10 ` Yann E. MORIN
2021-10-10 13:57 ` Thomas Petazzoni
2021-10-10 17:42 ` Yann E. MORIN
2021-10-09 19:16 ` [Buildroot] [PATCH 3/5] package/gdb: switch to gdb 10.x as the default Thomas Petazzoni
2021-10-10 17:42 ` Yann E. MORIN [this message]
2021-10-09 19:16 ` [Buildroot] [PATCH 4/5] package/gdb: drop support for version 8.3.x Thomas Petazzoni
2021-10-10 17:42 ` Yann E. MORIN
2021-10-09 19:16 ` [Buildroot] [PATCH 5/5] support/testing: add suite of tests for gdb Thomas Petazzoni
2021-10-10 17:43 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211010174235.GM2081069@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=mf@go-sys.de \
--cc=romain.naour@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox