* [Buildroot] [PATCH 1/1] package/libdbi: needs dynamic library
@ 2021-10-14 16:08 Fabrice Fontaine
2021-10-14 16:41 ` Herve Codina
2021-12-28 22:05 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2021-10-14 16:08 UTC (permalink / raw)
To: buildroot; +Cc: Hervé Codina, Fabrice Fontaine
libdbi needs dynamic library to avoid the following build failure raised
since the addition of the package in commit
c6aac6ebdbbd3873110a9e19de1957e49cb9344e:
dbi_main.c:84:2: error: #error no dynamic loading support
84 | #error no dynamic loading support
| ^~~~~
Fixes:
- http://autobuild.buildroot.org/results/9cd56a625cbd52b0c070e2d462e02f5161d9631d
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/libdbi-drivers/Config.in | 4 ++++
package/libdbi/Config.in | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/package/libdbi-drivers/Config.in b/package/libdbi-drivers/Config.in
index 087e6aaf0e..7c505340c1 100644
--- a/package/libdbi-drivers/Config.in
+++ b/package/libdbi-drivers/Config.in
@@ -1,8 +1,12 @@
config BR2_PACKAGE_LIBDBI_DRIVERS
bool "libdbi-drivers"
+ depends on !BR2_STATIC_LIBS # libdbi
select BR2_PACKAGE_LIBDBI
help
The libdbi-drivers project provides the
database-specific drivers for the libdbi framework.
http://libdbi-drivers.sourceforge.net
+
+comment "libdbi-drivers needs a toolchain w/ dynamic library"
+ depends on BR2_STATIC_LIBS
diff --git a/package/libdbi/Config.in b/package/libdbi/Config.in
index ded2bc6e53..13ac344f82 100644
--- a/package/libdbi/Config.in
+++ b/package/libdbi/Config.in
@@ -1,7 +1,11 @@
config BR2_PACKAGE_LIBDBI
bool "lidbi"
+ depends on !BR2_STATIC_LIBS
help
libdbi implements a database-independent abstraction layer
in C, similar to the DBI/DBD layer in Perl.
http://libdbi.sourceforge.net
+
+comment "libdbi needs a toolchain w/ dynamic library"
+ depends on BR2_STATIC_LIBS
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/libdbi: needs dynamic library
2021-10-14 16:08 [Buildroot] [PATCH 1/1] package/libdbi: needs dynamic library Fabrice Fontaine
@ 2021-10-14 16:41 ` Herve Codina
2021-10-14 16:51 ` Fabrice Fontaine
2021-12-28 22:05 ` Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Herve Codina @ 2021-10-14 16:41 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
Hi,
On Thu, 14 Oct 2021 18:08:24 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> libdbi needs dynamic library to avoid the following build failure raised
> since the addition of the package in commit
> c6aac6ebdbbd3873110a9e19de1957e49cb9344e:
>
> dbi_main.c:84:2: error: #error no dynamic loading support
> 84 | #error no dynamic loading support
> | ^~~~~
>
> Fixes:
> - http://autobuild.buildroot.org/results/9cd56a625cbd52b0c070e2d462e02f5161d9631d
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/libdbi-drivers/Config.in | 4 ++++
> package/libdbi/Config.in | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/package/libdbi-drivers/Config.in b/package/libdbi-drivers/Config.in
> index 087e6aaf0e..7c505340c1 100644
> --- a/package/libdbi-drivers/Config.in
> +++ b/package/libdbi-drivers/Config.in
> @@ -1,8 +1,12 @@
> config BR2_PACKAGE_LIBDBI_DRIVERS
> bool "libdbi-drivers"
> + depends on !BR2_STATIC_LIBS # libdbi
> select BR2_PACKAGE_LIBDBI
> help
> The libdbi-drivers project provides the
> database-specific drivers for the libdbi framework.
>
> http://libdbi-drivers.sourceforge.net
> +
> +comment "libdbi-drivers needs a toolchain w/ dynamic library"
> + depends on BR2_STATIC_LIBS
> diff --git a/package/libdbi/Config.in b/package/libdbi/Config.in
> index ded2bc6e53..13ac344f82 100644
> --- a/package/libdbi/Config.in
> +++ b/package/libdbi/Config.in
> @@ -1,7 +1,11 @@
> config BR2_PACKAGE_LIBDBI
> bool "lidbi"
> + depends on !BR2_STATIC_LIBS
> help
> libdbi implements a database-independent abstraction layer
> in C, similar to the DBI/DBD layer in Perl.
>
> http://libdbi.sourceforge.net
> +
> +comment "libdbi needs a toolchain w/ dynamic library"
> + depends on BR2_STATIC_LIBS
Indeed,
Also in collectd Config.in, "depends on" needs to be added
and its related comment.
---- 8< ----
config BR2_PACKAGE_COLLECTD_DBI
bool "dbi"
depends on !BR2_STATIC_LIBS # libdbi
select BR2_PACKAGE_LIBDBI
help
Executes SQL statements on various databases and
interprets the returned data.
comment "dbi needs a toolchain w/ dynamic library"
depends on BR2_STATIC_LIBS
---- 8< ----
Hervé
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libdbi: needs dynamic library
2021-10-14 16:41 ` Herve Codina
@ 2021-10-14 16:51 ` Fabrice Fontaine
2021-10-14 17:17 ` Herve Codina
0 siblings, 1 reply; 6+ messages in thread
From: Fabrice Fontaine @ 2021-10-14 16:51 UTC (permalink / raw)
To: Herve Codina; +Cc: Buildroot Mailing List
Hi,
Le jeu. 14 oct. 2021 à 18:41, Herve Codina <herve.codina@bootlin.com> a écrit :
>
> Hi,
>
> On Thu, 14 Oct 2021 18:08:24 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > libdbi needs dynamic library to avoid the following build failure raised
> > since the addition of the package in commit
> > c6aac6ebdbbd3873110a9e19de1957e49cb9344e:
> >
> > dbi_main.c:84:2: error: #error no dynamic loading support
> > 84 | #error no dynamic loading support
> > | ^~~~~
> >
> > Fixes:
> > - http://autobuild.buildroot.org/results/9cd56a625cbd52b0c070e2d462e02f5161d9631d
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > package/libdbi-drivers/Config.in | 4 ++++
> > package/libdbi/Config.in | 4 ++++
> > 2 files changed, 8 insertions(+)
> >
> > diff --git a/package/libdbi-drivers/Config.in b/package/libdbi-drivers/Config.in
> > index 087e6aaf0e..7c505340c1 100644
> > --- a/package/libdbi-drivers/Config.in
> > +++ b/package/libdbi-drivers/Config.in
> > @@ -1,8 +1,12 @@
> > config BR2_PACKAGE_LIBDBI_DRIVERS
> > bool "libdbi-drivers"
> > + depends on !BR2_STATIC_LIBS # libdbi
> > select BR2_PACKAGE_LIBDBI
> > help
> > The libdbi-drivers project provides the
> > database-specific drivers for the libdbi framework.
> >
> > http://libdbi-drivers.sourceforge.net
> > +
> > +comment "libdbi-drivers needs a toolchain w/ dynamic library"
> > + depends on BR2_STATIC_LIBS
> > diff --git a/package/libdbi/Config.in b/package/libdbi/Config.in
> > index ded2bc6e53..13ac344f82 100644
> > --- a/package/libdbi/Config.in
> > +++ b/package/libdbi/Config.in
> > @@ -1,7 +1,11 @@
> > config BR2_PACKAGE_LIBDBI
> > bool "lidbi"
> > + depends on !BR2_STATIC_LIBS
> > help
> > libdbi implements a database-independent abstraction layer
> > in C, similar to the DBI/DBD layer in Perl.
> >
> > http://libdbi.sourceforge.net
> > +
> > +comment "libdbi needs a toolchain w/ dynamic library"
> > + depends on BR2_STATIC_LIBS
>
>
> Indeed,
>
> Also in collectd Config.in, "depends on" needs to be added
> and its related comment.
Nope, collectd already depends on dynamic library since commit
9960b957a63e8fdd197d9cef6ea55b1b05c40ec3 so it's not needed to add
this dependency a second time.
I'll send a patch to drop it from BR2_PACKAGE_COLLECTD_NOTIFY_EMAIL.
>
> ---- 8< ----
> config BR2_PACKAGE_COLLECTD_DBI
> bool "dbi"
> depends on !BR2_STATIC_LIBS # libdbi
> select BR2_PACKAGE_LIBDBI
> help
> Executes SQL statements on various databases and
> interprets the returned data.
>
> comment "dbi needs a toolchain w/ dynamic library"
> depends on BR2_STATIC_LIBS
> ---- 8< ----
>
> Hervé
>
> --
> Hervé Codina, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,
Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libdbi: needs dynamic library
2021-10-14 16:08 [Buildroot] [PATCH 1/1] package/libdbi: needs dynamic library Fabrice Fontaine
2021-10-14 16:41 ` Herve Codina
@ 2021-12-28 22:05 ` Thomas Petazzoni
2022-01-25 19:23 ` Peter Korsgaard
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2021-12-28 22:05 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Hervé Codina, buildroot
On Thu, 14 Oct 2021 18:08:24 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> libdbi needs dynamic library to avoid the following build failure raised
> since the addition of the package in commit
> c6aac6ebdbbd3873110a9e19de1957e49cb9344e:
>
> dbi_main.c:84:2: error: #error no dynamic loading support
> 84 | #error no dynamic loading support
> | ^~~~~
>
> Fixes:
> - http://autobuild.buildroot.org/results/9cd56a625cbd52b0c070e2d462e02f5161d9631d
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/libdbi-drivers/Config.in | 4 ++++
> package/libdbi/Config.in | 4 ++++
> 2 files changed, 8 insertions(+)
Applied to master, but after adding the !BR2_STATIC_LIBS dependency to
collectd, as suggested by Hervé. Indeed, we prefer to duplicate those
dependencies, if they turn out to change at the top-level
BR2_PACKAGE_COLLECTD option.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libdbi: needs dynamic library
2021-12-28 22:05 ` Thomas Petazzoni
@ 2022-01-25 19:23 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2022-01-25 19:23 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Hervé Codina, Fabrice Fontaine, buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> On Thu, 14 Oct 2021 18:08:24 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>> libdbi needs dynamic library to avoid the following build failure raised
>> since the addition of the package in commit
>> c6aac6ebdbbd3873110a9e19de1957e49cb9344e:
>>
>> dbi_main.c:84:2: error: #error no dynamic loading support
>> 84 | #error no dynamic loading support
>> | ^~~~~
>>
>> Fixes:
>> - http://autobuild.buildroot.org/results/9cd56a625cbd52b0c070e2d462e02f5161d9631d
>>
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>> ---
>> package/libdbi-drivers/Config.in | 4 ++++
>> package/libdbi/Config.in | 4 ++++
>> 2 files changed, 8 insertions(+)
> Applied to master, but after adding the !BR2_STATIC_LIBS dependency to
> collectd, as suggested by Hervé. Indeed, we prefer to duplicate those
> dependencies, if they turn out to change at the top-level
> BR2_PACKAGE_COLLECTD option.
Committed to 2021.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-25 19:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-14 16:08 [Buildroot] [PATCH 1/1] package/libdbi: needs dynamic library Fabrice Fontaine
2021-10-14 16:41 ` Herve Codina
2021-10-14 16:51 ` Fabrice Fontaine
2021-10-14 17:17 ` Herve Codina
2021-12-28 22:05 ` Thomas Petazzoni
2022-01-25 19:23 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox