From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/wireguard-linux-compat: add missing comment about kernel dependency
Date: Sat, 16 Oct 2021 14:10:10 +0200 [thread overview]
Message-ID: <20211016121010.GT4165837@scaer> (raw)
In-Reply-To: <87fst1nyr3.fsf@dell.be.48ers.dk>
Peter, All,
On 2021-10-16 10:46 +0200, Peter Korsgaard spake thusly:
> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> > Add a comment when kernel is not enabled (missing since the addition of
> > the package in commit de591c5c3a93a40d049a32bd79c30cc66daf5fb2)
[--SNIP--]
> Is this really a sensible comment? I would imagine that needing a Linux
> kernel is an obvious requirement for a kernel driver?
Remember that some people build their kernel outside of Buildroot, or
do not build it at all, so they may not think of this as "an obvious
requirement"...
I agree with Fabrice: we have that comment in quite some places, and
this is explicitly documented in our manual:
18.2.5. Dependencies on a Linux kernel built by buildroot
Some packages need a Linux kernel to be built by buildroot. These
are typically kernel modules or firmware. A comment should be added
in the Config.in file to express this dependency, similar to
dependencies on toolchain options. The general format is:
foo needs a Linux kernel to be built
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-10-16 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 8:41 [Buildroot] [PATCH 1/1] package/wireguard-linux-compat: add missing comment about kernel dependency Fabrice Fontaine
2021-10-16 8:46 ` Peter Korsgaard
2021-10-16 8:51 ` Fabrice Fontaine
2021-10-16 8:58 ` Peter Korsgaard
2021-10-16 12:10 ` Yann E. MORIN [this message]
2021-10-17 7:50 ` Yann E. MORIN
2021-10-22 18:42 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211016121010.GT4165837@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox