From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Buildroot Mailing List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/wireguard-linux-compat: add missing comment about kernel dependency
Date: Sat, 16 Oct 2021 10:58:00 +0200 [thread overview]
Message-ID: <87bl3pny7b.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <CAPi7W80qKoytyqrvZoQhWY16qq5kt=XgkxKOwrE-DSGH37YZdA@mail.gmail.com> (Fabrice Fontaine's message of "Sat, 16 Oct 2021 10:51:31 +0200")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Le sam. 16 oct. 2021 à 10:46, Peter Korsgaard <peter@korsgaard.com> a écrit :
>>
>> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
>>
>> > Add a comment when kernel is not enabled (missing since the addition of
>> > the package in commit de591c5c3a93a40d049a32bd79c30cc66daf5fb2)
>>
>> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>> > ---
>> > package/wireguard-linux-compat/Config.in | 3 +++
>> > 1 file changed, 3 insertions(+)
>>
>> > diff --git a/package/wireguard-linux-compat/Config.in
>> > b/package/wireguard-linux-compat/Config.in
>> > index 5a323a35e5..4e8e95bdc3 100644
>> > --- a/package/wireguard-linux-compat/Config.in
>> > +++ b/package/wireguard-linux-compat/Config.in
>> > @@ -21,6 +21,9 @@ config BR2_PACKAGE_WIREGUARD_LINUX_COMPAT
>>
>> > https://www.wireguard.com
>>
>> > +comment "wireguard-linux-compat needs a Linux kernel to be built"
>> > + depends on !BR2_LINUX_KERNEL
>>
>> Is this really a sensible comment? I would imagine that needing a Linux
>> kernel is an obvious requirement for a kernel driver?
> We have this comment for other drivers such as dahdi-linux and xr819-xradio.
> So I think we should be consistent in all packages.
Ok, I'll take care of it.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-10-16 8:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 8:41 [Buildroot] [PATCH 1/1] package/wireguard-linux-compat: add missing comment about kernel dependency Fabrice Fontaine
2021-10-16 8:46 ` Peter Korsgaard
2021-10-16 8:51 ` Fabrice Fontaine
2021-10-16 8:58 ` Peter Korsgaard [this message]
2021-10-16 12:10 ` Yann E. MORIN
2021-10-17 7:50 ` Yann E. MORIN
2021-10-22 18:42 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl3pny7b.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox