* [Buildroot] [PATCH] boot/at91bootstrap3: add svn repository method [not found] <20211019080514.6189-1-xiangyu.chen.ref@aol.com> @ 2021-10-19 8:05 ` CHEN Xiangyu via buildroot 2021-10-24 16:49 ` Thomas Petazzoni 0 siblings, 1 reply; 4+ messages in thread From: CHEN Xiangyu via buildroot @ 2021-10-19 8:05 UTC (permalink / raw) To: buildroot; +Cc: CHEN Xiangyu, Simon Dawson Since more and more traditional companies are starting using buildroot with AT91SAM9x chipset as their product firmware, much of them are still using SVN as their version control system. So add svn repository method to AT91bootstrap3 package. Signed-off-by: CHEN Xiangyu <xiangyu.chen@aol.com> --- boot/at91bootstrap3/Config.in | 14 +++++++++++--- boot/at91bootstrap3/at91bootstrap3.mk | 3 +++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/boot/at91bootstrap3/Config.in b/boot/at91bootstrap3/Config.in index 650d3a23c8..3cfc0bbe14 100644 --- a/boot/at91bootstrap3/Config.in +++ b/boot/at91bootstrap3/Config.in @@ -30,6 +30,14 @@ config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT This option allows Buildroot to get the AT91 Bootstrap 3 source code from a Git repository. +config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_SVN + bool "Custom SVN repository" + help + This option allows Buildroot to get the AT91 Bootstrap 3 + source code from a Subversion repository + config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_TARBALL bool "Custom tarball" @@ -39,7 +45,7 @@ config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_TARBALL_LOCATION string "URL of custom AT91Bootstrap tarball" depends on BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_TARBALL -if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT +if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT || BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_SVN config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL string "URL of custom repository" @@ -47,7 +53,7 @@ config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION string "Custom repository version" help - Revision to use in the typical format used by Git + Revision to use in the typical format used by Git or SVN E.G. a sha id, a tag, branch, .. endif @@ -57,7 +63,7 @@ config BR2_TARGET_AT91BOOTSTRAP3_VERSION default "v4.0.0" if BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION default "v3.10.3" if BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION_3X default BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION \ - if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT + if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT || BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_SVN default "custom" if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_TARBALL config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_PATCH_DIR diff --git a/boot/at91bootstrap3/at91bootstrap3.mk b/boot/at91bootstrap3/at91bootstrap3.mk index 1e2a3a44b0..f609176a3f 100644 --- a/boot/at91bootstrap3/at91bootstrap3.mk +++ b/boot/at91bootstrap3/at91bootstrap3.mk @@ -15,6 +15,9 @@ else ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y) AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL)) AT91BOOTSTRAP3_SITE_METHOD = git BR_NO_CHECK_HASH_FOR += $(AT91BOOTSTRAP3_SOURCE) +else ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_SVN),y) +AT91BOOTSTRAP3_SITE_METHOD = svn +BR_NO_CHECK_HASH_FOR += $(AT91BOOTSTRAP3_SOURCE) else AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION)) endif -- 2.26.2 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] boot/at91bootstrap3: add svn repository method 2021-10-19 8:05 ` [Buildroot] [PATCH] boot/at91bootstrap3: add svn repository method CHEN Xiangyu via buildroot @ 2021-10-24 16:49 ` Thomas Petazzoni 0 siblings, 0 replies; 4+ messages in thread From: Thomas Petazzoni @ 2021-10-24 16:49 UTC (permalink / raw) To: CHEN Xiangyu; +Cc: Simon Dawson, buildroot@buildroot.org Hello Chen, Thanks for this patch. However, I see a problem, see below. On Tue, 19 Oct 2021 16:05:14 +0800 CHEN Xiangyu via buildroot <buildroot@buildroot.org> wrote: > config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_PATCH_DIR > diff --git a/boot/at91bootstrap3/at91bootstrap3.mk b/boot/at91bootstrap3/at91bootstrap3.mk > index 1e2a3a44b0..f609176a3f 100644 > --- a/boot/at91bootstrap3/at91bootstrap3.mk > +++ b/boot/at91bootstrap3/at91bootstrap3.mk > @@ -15,6 +15,9 @@ else ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y) > AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL)) > AT91BOOTSTRAP3_SITE_METHOD = git > BR_NO_CHECK_HASH_FOR += $(AT91BOOTSTRAP3_SOURCE) > +else ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_SVN),y) > +AT91BOOTSTRAP3_SITE_METHOD = svn > +BR_NO_CHECK_HASH_FOR += $(AT91BOOTSTRAP3_SOURCE) You're not defining AT91BOOTSTRAP3_SITE anywhere, so in fact it is never assigned. The current code goes like this: ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_TARBALL),y) AT91BOOTSTRAP3_TARBALL = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_TARBALL_LOCATION)) AT91BOOTSTRAP3_SITE = $(patsubst %/,%,$(dir $(AT91BOOTSTRAP3_TARBALL))) AT91BOOTSTRAP3_SOURCE = $(notdir $(AT91BOOTSTRAP3_TARBALL)) BR_NO_CHECK_HASH_FOR += $(AT91BOOTSTRAP3_SOURCE) else ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y) AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL)) AT91BOOTSTRAP3_SITE_METHOD = git BR_NO_CHECK_HASH_FOR += $(AT91BOOTSTRAP3_SOURCE) else AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION)) endif So if you're adding a new case for BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_SVN, it should also define AT91BOOTSTRAP3_SITE. Am I missing something ? Did you test this change ? Best regards, Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <810116346.3867627.1634462494722.ref@mail.yahoo.com>]
* [Buildroot] [PATCH] boot/at91bootstrap3: add svn repository method [not found] <810116346.3867627.1634462494722.ref@mail.yahoo.com> @ 2021-10-17 9:21 ` Xiangyu Chen via buildroot 0 siblings, 0 replies; 4+ messages in thread From: Xiangyu Chen via buildroot @ 2021-10-17 9:21 UTC (permalink / raw) To: buildroot@buildroot.org [-- Attachment #1.1: Type: text/plain, Size: 475 bytes --] Dear buildroot maintainer: Since more and more traditional companies are starting using buildroot with AT91SAMx chipset as their product firmware, much of them are still using SVN as their version control system. So add svn repository method to AT91bootstrap3 package. It's a milestone to me that i from a parasite to a buildroot contributor, if there is any incorrect in this patch, feel free to tell me via email(xiangyu.chen@aol.com). Thanks! Br,Xiangyu [-- Attachment #1.2: Type: text/html, Size: 1712 bytes --] [-- Attachment #2: 0001-boot-at91bootstrap3-add-svn-repository-method.patch --] [-- Type: application/octet-stream, Size: 3148 bytes --] From dfd64f740b346d6085a3d5af134bd8f44c84b085 Mon Sep 17 00:00:00 2001 From: CHEN Xiangyu <xiangyu.chen@aol.com> Date: Sun, 17 Oct 2021 16:45:33 +0800 Subject: [PATCH] boot/at91bootstrap3: add svn repository method Since more and more traditional companies are starting using buildroot with AT91SAMx chipset as their product firmware, much of them are still using SVN as their version control system. So add svn repository method to AT91bootstrap3 package. --- boot/at91bootstrap3/Config.in | 14 +++++++++++--- boot/at91bootstrap3/at91bootstrap3.mk | 3 +++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/boot/at91bootstrap3/Config.in b/boot/at91bootstrap3/Config.in index 650d3a23c8..3cfc0bbe14 100644 --- a/boot/at91bootstrap3/Config.in +++ b/boot/at91bootstrap3/Config.in @@ -30,6 +30,14 @@ config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT This option allows Buildroot to get the AT91 Bootstrap 3 source code from a Git repository. +config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_SVN + bool "Custom SVN repository" + help + This option allows Buildroot to get the AT91 Bootstrap 3 + source code from a Subversion repository + + + config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_TARBALL bool "Custom tarball" @@ -39,7 +47,7 @@ config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_TARBALL_LOCATION string "URL of custom AT91Bootstrap tarball" depends on BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_TARBALL -if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT +if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT || BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_SVN config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL string "URL of custom repository" @@ -47,7 +55,7 @@ config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION string "Custom repository version" help - Revision to use in the typical format used by Git + Revision to use in the typical format used by Git or SVN E.G. a sha id, a tag, branch, .. endif @@ -57,7 +65,7 @@ config BR2_TARGET_AT91BOOTSTRAP3_VERSION default "v4.0.0" if BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION default "v3.10.3" if BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION_3X default BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION \ - if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT + if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT || BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_SVN default "custom" if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_TARBALL config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_PATCH_DIR diff --git a/boot/at91bootstrap3/at91bootstrap3.mk b/boot/at91bootstrap3/at91bootstrap3.mk index 1e2a3a44b0..f609176a3f 100644 --- a/boot/at91bootstrap3/at91bootstrap3.mk +++ b/boot/at91bootstrap3/at91bootstrap3.mk @@ -15,6 +15,9 @@ else ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y) AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL)) AT91BOOTSTRAP3_SITE_METHOD = git BR_NO_CHECK_HASH_FOR += $(AT91BOOTSTRAP3_SOURCE) +else ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_SVN),y) +AT91BOOTSTRAP3_SITE_METHOD = svn +BR_NO_CHECK_HASH_FOR += $(AT91BOOTSTRAP3_SOURCE) else AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION)) endif -- 2.26.2 [-- Attachment #3: Type: text/plain, Size: 150 bytes --] _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <1553939413.3863322.1634461967644.ref@mail.yahoo.com>]
* [Buildroot] [PATCH] boot/at91bootstrap3: add svn repository method [not found] <1553939413.3863322.1634461967644.ref@mail.yahoo.com> @ 2021-10-17 9:12 ` Xiangyu Chen via buildroot 0 siblings, 0 replies; 4+ messages in thread From: Xiangyu Chen via buildroot @ 2021-10-17 9:12 UTC (permalink / raw) To: buildroot@uclibc.org [-- Attachment #1.1: Type: text/plain, Size: 475 bytes --] Dear buildroot maintainer: Since more and more traditional companies are starting using buildroot with AT91SAMx chipset as their product firmware, much of them are still using SVN as their version control system. So add svn repository method to AT91bootstrap3 package. It's a milestone to me that i from a parasite to a buildroot contributor, if there is any incorrect in this patch, feel free to tell me via email(xiangyu.chen@aol.com). Thanks! Br,Xiangyu [-- Attachment #1.2: Type: text/html, Size: 1140 bytes --] [-- Attachment #2: 0001-boot-at91bootstrap3-add-svn-repository-method.patch --] [-- Type: application/octet-stream, Size: 3148 bytes --] From dfd64f740b346d6085a3d5af134bd8f44c84b085 Mon Sep 17 00:00:00 2001 From: CHEN Xiangyu <xiangyu.chen@aol.com> Date: Sun, 17 Oct 2021 16:45:33 +0800 Subject: [PATCH] boot/at91bootstrap3: add svn repository method Since more and more traditional companies are starting using buildroot with AT91SAMx chipset as their product firmware, much of them are still using SVN as their version control system. So add svn repository method to AT91bootstrap3 package. --- boot/at91bootstrap3/Config.in | 14 +++++++++++--- boot/at91bootstrap3/at91bootstrap3.mk | 3 +++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/boot/at91bootstrap3/Config.in b/boot/at91bootstrap3/Config.in index 650d3a23c8..3cfc0bbe14 100644 --- a/boot/at91bootstrap3/Config.in +++ b/boot/at91bootstrap3/Config.in @@ -30,6 +30,14 @@ config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT This option allows Buildroot to get the AT91 Bootstrap 3 source code from a Git repository. +config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_SVN + bool "Custom SVN repository" + help + This option allows Buildroot to get the AT91 Bootstrap 3 + source code from a Subversion repository + + + config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_TARBALL bool "Custom tarball" @@ -39,7 +47,7 @@ config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_TARBALL_LOCATION string "URL of custom AT91Bootstrap tarball" depends on BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_TARBALL -if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT +if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT || BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_SVN config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL string "URL of custom repository" @@ -47,7 +55,7 @@ config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION string "Custom repository version" help - Revision to use in the typical format used by Git + Revision to use in the typical format used by Git or SVN E.G. a sha id, a tag, branch, .. endif @@ -57,7 +65,7 @@ config BR2_TARGET_AT91BOOTSTRAP3_VERSION default "v4.0.0" if BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION default "v3.10.3" if BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION_3X default BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION \ - if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT + if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT || BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_SVN default "custom" if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_TARBALL config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_PATCH_DIR diff --git a/boot/at91bootstrap3/at91bootstrap3.mk b/boot/at91bootstrap3/at91bootstrap3.mk index 1e2a3a44b0..f609176a3f 100644 --- a/boot/at91bootstrap3/at91bootstrap3.mk +++ b/boot/at91bootstrap3/at91bootstrap3.mk @@ -15,6 +15,9 @@ else ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y) AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL)) AT91BOOTSTRAP3_SITE_METHOD = git BR_NO_CHECK_HASH_FOR += $(AT91BOOTSTRAP3_SOURCE) +else ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_SVN),y) +AT91BOOTSTRAP3_SITE_METHOD = svn +BR_NO_CHECK_HASH_FOR += $(AT91BOOTSTRAP3_SOURCE) else AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION)) endif -- 2.26.2 [-- Attachment #3: Type: text/plain, Size: 150 bytes --] _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-24 16:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211019080514.6189-1-xiangyu.chen.ref@aol.com>
2021-10-19 8:05 ` [Buildroot] [PATCH] boot/at91bootstrap3: add svn repository method CHEN Xiangyu via buildroot
2021-10-24 16:49 ` Thomas Petazzoni
[not found] <810116346.3867627.1634462494722.ref@mail.yahoo.com>
2021-10-17 9:21 ` Xiangyu Chen via buildroot
[not found] <1553939413.3863322.1634461967644.ref@mail.yahoo.com>
2021-10-17 9:12 ` Xiangyu Chen via buildroot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox