* [Buildroot] [PATCH 1/1] package/gobject-introspection: needs host gcc >= 7
@ 2021-10-19 5:25 Fabrice Fontaine
2021-10-25 20:18 ` Yann E. MORIN
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2021-10-19 5:25 UTC (permalink / raw)
To: buildroot
Cc: Grzegorz Blach, Anisse Astier, Asaf Kahlon, Thomas Petazzoni,
Fabrice Fontaine
Commit 33c69c02fb4c1176584d1e2dd336b74ed39f5d65 forgot to propagate
host gcc >= 7 dependency to reverse dependencies of host-qemu resulting
in the following build failure:
ERROR: You need at least GCC v7.5 or Clang v6.0 (or XCode Clang v10.0)
Fixes:
- http://autobuild.buildroot.org/results/14cd0250d55c5ca5dc1d297aee1b927fda889531
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/gobject-introspection/Config.in | 6 ++++--
package/python-bluezero/Config.in | 6 ++++--
package/python-gobject/Config.in | 6 ++++--
3 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/package/gobject-introspection/Config.in b/package/gobject-introspection/Config.in
index bacf44363c..c631c84755 100644
--- a/package/gobject-introspection/Config.in
+++ b/package/gobject-introspection/Config.in
@@ -13,6 +13,7 @@ config BR2_PACKAGE_GOBJECT_INTROSPECTION
# compile errors with locale.c. As such, require 4.9 until this
# can be verified.
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+ depends on BR2_HOST_GCC_AT_LEAST_7 # host-qemu
depends on BR2_TOOLCHAIN_USES_GLIBC
# gobject-introspection does not require python3 to run on the
# target; however, because the tools run in a qemu wrapper, a
@@ -41,8 +42,9 @@ comment "gobject-introspection needs python3"
depends on !BR2_PACKAGE_PYTHON3
depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
-comment "gobject-introspection needs a glibc toolchain, gcc >= 4.9"
+comment "gobject-introspection needs a glibc toolchain, gcc >= 4.9, host gcc >= 7"
depends on BR2_USE_MMU
depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
depends on !BR2_TOOLCHAIN_USES_GLIBC || \
- !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+ !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
+ !BR2_HOST_GCC_AT_LEAST_7
diff --git a/package/python-bluezero/Config.in b/package/python-bluezero/Config.in
index c391bfa858..3d40b1e275 100644
--- a/package/python-bluezero/Config.in
+++ b/package/python-bluezero/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_PYTHON_BLUEZERO
bool "python-bluezero"
depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS # python-gobject -> gobject-introspection
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # python-gobject -> gobject-introspection
+ depends on BR2_HOST_GCC_AT_LEAST_7 # python-gobject -> gobject-introspection -> host-qemu
depends on BR2_TOOLCHAIN_USES_GLIBC # python-gobject -> gobject-introspection
depends on BR2_PACKAGE_PYTHON3
select BR2_PACKAGE_DBUS # runtime
@@ -12,8 +13,9 @@ config BR2_PACKAGE_PYTHON_BLUEZERO
https://github.com/ukBaz/python-bluezero
-comment "python-bluezero needs a glibc toolchain, gcc >= 4.9"
+comment "python-bluezero needs a glibc toolchain, gcc >= 4.9, host gcc >= 7"
depends on BR2_PACKAGE_PYTHON3
depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
depends on !BR2_TOOLCHAIN_USES_GLIBC || \
- !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+ !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
+ !BR2_HOST_GCC_AT_LEAST_7
diff --git a/package/python-gobject/Config.in b/package/python-gobject/Config.in
index 1c9303b0ba..910f990026 100644
--- a/package/python-gobject/Config.in
+++ b/package/python-gobject/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_PYTHON_GOBJECT
depends on BR2_USE_MMU # libglib2, gobject-introspection
depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS # gobject-introspection
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # gobject-introspection
+ depends on BR2_HOST_GCC_AT_LEAST_7 # gobject-introspection -> host-qemu
depends on BR2_TOOLCHAIN_USES_GLIBC # gobject-introspection
depends on BR2_PACKAGE_PYTHON3 # gobject-introspection
select BR2_PACKAGE_GOBJECT_INTROSPECTION
@@ -12,8 +13,9 @@ config BR2_PACKAGE_PYTHON_GOBJECT
https://wiki.gnome.org/action/show/Projects/PyGObject
-comment "python-gobject needs a glibc toolchain, gcc >= 4.9"
+comment "python-gobject needs a glibc toolchain, gcc >= 4.9, host gcc >= 7"
depends on BR2_USE_MMU
depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
depends on !BR2_TOOLCHAIN_USES_GLIBC || \
- !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+ !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
+ !BR2_HOST_GCC_AT_LEAST_7
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/gobject-introspection: needs host gcc >= 7
2021-10-19 5:25 [Buildroot] [PATCH 1/1] package/gobject-introspection: needs host gcc >= 7 Fabrice Fontaine
@ 2021-10-25 20:18 ` Yann E. MORIN
0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2021-10-25 20:18 UTC (permalink / raw)
To: Fabrice Fontaine
Cc: Grzegorz Blach, Anisse Astier, Asaf Kahlon, Thomas Petazzoni,
buildroot, Adam Duskett
Fabrice, All,
+Adam
On 2021-10-19 07:25 +0200, Fabrice Fontaine spake thusly:
> Commit 33c69c02fb4c1176584d1e2dd336b74ed39f5d65 forgot to propagate
> host gcc >= 7 dependency to reverse dependencies of host-qemu resulting
> in the following build failure:
>
> ERROR: You need at least GCC v7.5 or Clang v6.0 (or XCode Clang v10.0)
>
> Fixes:
> - http://autobuild.buildroot.org/results/14cd0250d55c5ca5dc1d297aee1b927fda889531
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Note however, that the issue is really about gcc >= 7.5. We do not have
such a symbol, and we do not want to add it. So, adding the dependency
on host gcc >= 7 is not strictly correct, because it allows for gcc 7.4
and below... And gcc 7.5 was the last release in the 7.x branch. It is
probably a safe bet to require 8.x now.
Adam has sent a patch doing that; I already asked him on IRC to rebase
on master now that I applied your patch.
Regards,
Yann E. MORIN.
> ---
> package/gobject-introspection/Config.in | 6 ++++--
> package/python-bluezero/Config.in | 6 ++++--
> package/python-gobject/Config.in | 6 ++++--
> 3 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/package/gobject-introspection/Config.in b/package/gobject-introspection/Config.in
> index bacf44363c..c631c84755 100644
> --- a/package/gobject-introspection/Config.in
> +++ b/package/gobject-introspection/Config.in
> @@ -13,6 +13,7 @@ config BR2_PACKAGE_GOBJECT_INTROSPECTION
> # compile errors with locale.c. As such, require 4.9 until this
> # can be verified.
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> + depends on BR2_HOST_GCC_AT_LEAST_7 # host-qemu
> depends on BR2_TOOLCHAIN_USES_GLIBC
> # gobject-introspection does not require python3 to run on the
> # target; however, because the tools run in a qemu wrapper, a
> @@ -41,8 +42,9 @@ comment "gobject-introspection needs python3"
> depends on !BR2_PACKAGE_PYTHON3
> depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
>
> -comment "gobject-introspection needs a glibc toolchain, gcc >= 4.9"
> +comment "gobject-introspection needs a glibc toolchain, gcc >= 4.9, host gcc >= 7"
> depends on BR2_USE_MMU
> depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
> depends on !BR2_TOOLCHAIN_USES_GLIBC || \
> - !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
> + !BR2_HOST_GCC_AT_LEAST_7
> diff --git a/package/python-bluezero/Config.in b/package/python-bluezero/Config.in
> index c391bfa858..3d40b1e275 100644
> --- a/package/python-bluezero/Config.in
> +++ b/package/python-bluezero/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_PYTHON_BLUEZERO
> bool "python-bluezero"
> depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS # python-gobject -> gobject-introspection
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # python-gobject -> gobject-introspection
> + depends on BR2_HOST_GCC_AT_LEAST_7 # python-gobject -> gobject-introspection -> host-qemu
> depends on BR2_TOOLCHAIN_USES_GLIBC # python-gobject -> gobject-introspection
> depends on BR2_PACKAGE_PYTHON3
> select BR2_PACKAGE_DBUS # runtime
> @@ -12,8 +13,9 @@ config BR2_PACKAGE_PYTHON_BLUEZERO
>
> https://github.com/ukBaz/python-bluezero
>
> -comment "python-bluezero needs a glibc toolchain, gcc >= 4.9"
> +comment "python-bluezero needs a glibc toolchain, gcc >= 4.9, host gcc >= 7"
> depends on BR2_PACKAGE_PYTHON3
> depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
> depends on !BR2_TOOLCHAIN_USES_GLIBC || \
> - !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
> + !BR2_HOST_GCC_AT_LEAST_7
> diff --git a/package/python-gobject/Config.in b/package/python-gobject/Config.in
> index 1c9303b0ba..910f990026 100644
> --- a/package/python-gobject/Config.in
> +++ b/package/python-gobject/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_PYTHON_GOBJECT
> depends on BR2_USE_MMU # libglib2, gobject-introspection
> depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS # gobject-introspection
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # gobject-introspection
> + depends on BR2_HOST_GCC_AT_LEAST_7 # gobject-introspection -> host-qemu
> depends on BR2_TOOLCHAIN_USES_GLIBC # gobject-introspection
> depends on BR2_PACKAGE_PYTHON3 # gobject-introspection
> select BR2_PACKAGE_GOBJECT_INTROSPECTION
> @@ -12,8 +13,9 @@ config BR2_PACKAGE_PYTHON_GOBJECT
>
> https://wiki.gnome.org/action/show/Projects/PyGObject
>
> -comment "python-gobject needs a glibc toolchain, gcc >= 4.9"
> +comment "python-gobject needs a glibc toolchain, gcc >= 4.9, host gcc >= 7"
> depends on BR2_USE_MMU
> depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
> depends on !BR2_TOOLCHAIN_USES_GLIBC || \
> - !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
> + !BR2_HOST_GCC_AT_LEAST_7
> --
> 2.33.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-25 20:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-19 5:25 [Buildroot] [PATCH 1/1] package/gobject-introspection: needs host gcc >= 7 Fabrice Fontaine
2021-10-25 20:18 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox