[Buildroot] [PATCH 1/1] package/collectd: add missing C++ comment for mysql

[Buildroot] [PATCH 1/1] package/collectd: add missing C++ comment for mysql

[Fabrice Fontaine]

Add missing C++ comment for mysql and while at it drops depends on
MMU and threads which are always true

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/collectd/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/collectd/Config.in b/package/collectd/Config.in
index d44d4e4913..6873e6d5ab 100644
--- a/package/collectd/Config.in
+++ b/package/collectd/Config.in
@@ -377,13 +377,14 @@ config BR2_PACKAGE_COLLECTD_MODBUS
 config BR2_PACKAGE_COLLECTD_MYSQL
 	bool "mysql"
 	depends on BR2_INSTALL_LIBSTDCPP # mysql
-	depends on BR2_USE_MMU # mysql
-	depends on BR2_TOOLCHAIN_HAS_THREADS # mysql
 	select BR2_PACKAGE_MYSQL
 	help
 	  Connects to a MySQL database and issues a "show status"
 	  command.
 
+comment "mysql needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
+
 config BR2_PACKAGE_COLLECTD_NETLINK
 	bool "netlink"
 	select BR2_PACKAGE_LIBMNL
-- 
2.33.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/collectd: add missing C++ comment for mysql

[Thomas Petazzoni]

Hello Fabrice,

On Sat, 30 Oct 2021 23:53:07 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Add missing C++ comment for mysql and while at it drops depends on
> MMU and threads which are always true
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/collectd/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/collectd/Config.in b/package/collectd/Config.in
> index d44d4e4913..6873e6d5ab 100644
> --- a/package/collectd/Config.in
> +++ b/package/collectd/Config.in
> @@ -377,13 +377,14 @@ config BR2_PACKAGE_COLLECTD_MODBUS
>  config BR2_PACKAGE_COLLECTD_MYSQL
>  	bool "mysql"
>  	depends on BR2_INSTALL_LIBSTDCPP # mysql
> -	depends on BR2_USE_MMU # mysql
> -	depends on BR2_TOOLCHAIN_HAS_THREADS # mysql

Regarding the removal of these, there is a school of thought that says
it's better to duplicate them, so that when the dependencies of mysql
change, it's a bit more obvious what to do.

>  	select BR2_PACKAGE_MYSQL
>  	help
>  	  Connects to a MySQL database and issues a "show status"
>  	  command.
>  
> +comment "mysql needs a toolchain w/ C++"
> +	depends on !BR2_INSTALL_LIBSTDCPP

That being said, what does this means for this comment? Should we talk
only about the C++ dependency, or also about the threads dependency ?

Arnout, Yann, Peter?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/collectd: add missing C++ comment for mysql

[Thomas Petazzoni]

On Sat, 30 Oct 2021 23:53:07 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Add missing C++ comment for mysql and while at it drops depends on
> MMU and threads which are always true
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/collectd/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

I have applied the comment addition, but not the removal of
"duplicated" dependencies.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/collectd: add missing C++ comment for mysql

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On Sat, 30 Oct 2021 23:53:07 +0200
 > Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

 >> Add missing C++ comment for mysql and while at it drops depends on
 >> MMU and threads which are always true
 >> 
 >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 >> ---
 >> package/collectd/Config.in | 5 +++--
 >> 1 file changed, 3 insertions(+), 2 deletions(-)

 > I have applied the comment addition, but not the removal of
 > "duplicated" dependencies.

Committed to 2021.02.x and 2021.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot