* [Buildroot] [PATCH 1/1] package/rcw-smarc-sal28: don't override dependencies
@ 2021-11-09 17:19 Fabrice Fontaine
2021-11-10 9:41 ` Yann E. MORIN
2021-11-17 15:03 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2021-11-09 17:19 UTC (permalink / raw)
To: buildroot; +Cc: Michael Walle, Fabrice Fontaine
Don't override RCW_SMARC_SAL28_DEPENDENCIES in a conditional
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/rcw-smarc-sal28/rcw-smarc-sal28.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/rcw-smarc-sal28/rcw-smarc-sal28.mk b/package/rcw-smarc-sal28/rcw-smarc-sal28.mk
index 4928f1a7f8..2bc740027f 100644
--- a/package/rcw-smarc-sal28/rcw-smarc-sal28.mk
+++ b/package/rcw-smarc-sal28/rcw-smarc-sal28.mk
@@ -14,7 +14,7 @@ RCW_SMARC_SAL28_INSTALL_IMAGES = YES
RCW_SMARC_SAL28_BOOT_VARIANT = $(call qstrip,$(BR2_PACKAGE_RCW_SMARC_SAL28_BOOT_VARIANT))
ifeq ($(BR2_PACKAGE_RCW_SMARC_SAL28_BUILD_UPDATE_SCRIPT),y)
-RCW_SMARC_SAL28_DEPENDENCIES = host-uboot-tools
+RCW_SMARC_SAL28_DEPENDENCIES += host-uboot-tools
define RCW_SMARC_SAL28_UPDATE_SCRIPT_BUILD_CMDS
MKIMAGE=$(HOST_DIR)/bin/mkimage $(MAKE) -C $(@D)/contrib all
endef
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/rcw-smarc-sal28: don't override dependencies
2021-11-09 17:19 [Buildroot] [PATCH 1/1] package/rcw-smarc-sal28: don't override dependencies Fabrice Fontaine
@ 2021-11-10 9:41 ` Yann E. MORIN
2021-11-17 15:03 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-11-10 9:41 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Michael Walle, buildroot
Fabrice, All,
On 2021-11-09 18:19 +0100, Fabrice Fontaine spake thusly:
> Don't override RCW_SMARC_SAL28_DEPENDENCIES in a conditional
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/rcw-smarc-sal28/rcw-smarc-sal28.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/rcw-smarc-sal28/rcw-smarc-sal28.mk b/package/rcw-smarc-sal28/rcw-smarc-sal28.mk
> index 4928f1a7f8..2bc740027f 100644
> --- a/package/rcw-smarc-sal28/rcw-smarc-sal28.mk
> +++ b/package/rcw-smarc-sal28/rcw-smarc-sal28.mk
> @@ -14,7 +14,7 @@ RCW_SMARC_SAL28_INSTALL_IMAGES = YES
> RCW_SMARC_SAL28_BOOT_VARIANT = $(call qstrip,$(BR2_PACKAGE_RCW_SMARC_SAL28_BOOT_VARIANT))
>
> ifeq ($(BR2_PACKAGE_RCW_SMARC_SAL28_BUILD_UPDATE_SCRIPT),y)
> -RCW_SMARC_SAL28_DEPENDENCIES = host-uboot-tools
> +RCW_SMARC_SAL28_DEPENDENCIES += host-uboot-tools
> define RCW_SMARC_SAL28_UPDATE_SCRIPT_BUILD_CMDS
> MKIMAGE=$(HOST_DIR)/bin/mkimage $(MAKE) -C $(@D)/contrib all
> endef
> --
> 2.33.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/rcw-smarc-sal28: don't override dependencies
2021-11-09 17:19 [Buildroot] [PATCH 1/1] package/rcw-smarc-sal28: don't override dependencies Fabrice Fontaine
2021-11-10 9:41 ` Yann E. MORIN
@ 2021-11-17 15:03 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-11-17 15:03 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Michael Walle, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Don't override RCW_SMARC_SAL28_DEPENDENCIES in a conditional
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2021.02.x and 2021.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-17 15:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-09 17:19 [Buildroot] [PATCH 1/1] package/rcw-smarc-sal28: don't override dependencies Fabrice Fontaine
2021-11-10 9:41 ` Yann E. MORIN
2021-11-17 15:03 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox