From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Gary Bisson <bisson.gary@gmail.com>,
Refik Tuzakli <tuzakli.refik@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/freescale-imx/imx-vpuwrap: don't override dependencies
Date: Wed, 10 Nov 2021 10:42:24 +0100 [thread overview]
Message-ID: <20211110094224.GK2084998@scaer> (raw)
In-Reply-To: <20211109172120.457166-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2021-11-09 18:21 +0100, Fabrice Fontaine spake thusly:
> Don't override IMX_VPUWRAP_DEPENDENCIES in a conditional
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk b/package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk
> index fdad3a5f2b..b9a1717d28 100644
> --- a/package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk
> +++ b/package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk
> @@ -8,15 +8,9 @@ IMX_VPUWRAP_VERSION = 4.3.5
> IMX_VPUWRAP_SITE = $(FREESCALE_IMX_SITE)
> IMX_VPUWRAP_SOURCE = imx-vpuwrap-$(IMX_VPUWRAP_VERSION).bin
> IMX_VPUWRAP_INSTALL_STAGING = YES
> -
> -ifeq ($(BR2_PACKAGE_IMX_VPU),y)
> -IMX_VPUWRAP_DEPENDENCIES = imx-vpu
> -endif
> -
> -ifeq ($(BR2_PACKAGE_IMX_VPU_HANTRO),y)
> -IMX_VPUWRAP_DEPENDENCIES = imx-vpu-hantro
> -endif
> -
> +IMX_VPUWRAP_DEPENDENCIES = \
> + $(if $(BR2_PACKAGE_IMX_VPU),imx-vpu) \
> + $(if $(BR2_PACKAGE_IMX_VPU_HANTRO),imx-vpu-hantro)
I've kept the multi-line conditonal blocks, and just used +=, then
applied to master, thanks.
Regards,
Yann E. MORIN.
> IMX_VPUWRAP_LICENSE = NXP Semiconductor Software License Agreement
> IMX_VPUWRAP_LICENSE_FILES = EULA COPYING
> IMX_VPUWRAP_REDISTRIBUTE = NO
> --
> 2.33.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-11-10 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 17:21 [Buildroot] [PATCH 1/1] package/freescale-imx/imx-vpuwrap: don't override dependencies Fabrice Fontaine
2021-11-10 9:42 ` Yann E. MORIN [this message]
2021-11-17 15:02 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110094224.GK2084998@scaer \
--to=yann.morin.1998@free.fr \
--cc=bisson.gary@gmail.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=tuzakli.refik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox