* [Buildroot] [PATCH 1/1] package/freescale-imx/imx-vpuwrap: don't override dependencies
@ 2021-11-09 17:21 Fabrice Fontaine
2021-11-10 9:42 ` Yann E. MORIN
2021-11-17 15:02 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2021-11-09 17:21 UTC (permalink / raw)
To: buildroot; +Cc: Gary Bisson, Fabrice Fontaine, Refik Tuzakli
Don't override IMX_VPUWRAP_DEPENDENCIES in a conditional
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk b/package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk
index fdad3a5f2b..b9a1717d28 100644
--- a/package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk
+++ b/package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk
@@ -8,15 +8,9 @@ IMX_VPUWRAP_VERSION = 4.3.5
IMX_VPUWRAP_SITE = $(FREESCALE_IMX_SITE)
IMX_VPUWRAP_SOURCE = imx-vpuwrap-$(IMX_VPUWRAP_VERSION).bin
IMX_VPUWRAP_INSTALL_STAGING = YES
-
-ifeq ($(BR2_PACKAGE_IMX_VPU),y)
-IMX_VPUWRAP_DEPENDENCIES = imx-vpu
-endif
-
-ifeq ($(BR2_PACKAGE_IMX_VPU_HANTRO),y)
-IMX_VPUWRAP_DEPENDENCIES = imx-vpu-hantro
-endif
-
+IMX_VPUWRAP_DEPENDENCIES = \
+ $(if $(BR2_PACKAGE_IMX_VPU),imx-vpu) \
+ $(if $(BR2_PACKAGE_IMX_VPU_HANTRO),imx-vpu-hantro)
IMX_VPUWRAP_LICENSE = NXP Semiconductor Software License Agreement
IMX_VPUWRAP_LICENSE_FILES = EULA COPYING
IMX_VPUWRAP_REDISTRIBUTE = NO
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/freescale-imx/imx-vpuwrap: don't override dependencies
2021-11-09 17:21 [Buildroot] [PATCH 1/1] package/freescale-imx/imx-vpuwrap: don't override dependencies Fabrice Fontaine
@ 2021-11-10 9:42 ` Yann E. MORIN
2021-11-17 15:02 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-11-10 9:42 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Gary Bisson, Refik Tuzakli, buildroot
Fabrice, All,
On 2021-11-09 18:21 +0100, Fabrice Fontaine spake thusly:
> Don't override IMX_VPUWRAP_DEPENDENCIES in a conditional
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk b/package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk
> index fdad3a5f2b..b9a1717d28 100644
> --- a/package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk
> +++ b/package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk
> @@ -8,15 +8,9 @@ IMX_VPUWRAP_VERSION = 4.3.5
> IMX_VPUWRAP_SITE = $(FREESCALE_IMX_SITE)
> IMX_VPUWRAP_SOURCE = imx-vpuwrap-$(IMX_VPUWRAP_VERSION).bin
> IMX_VPUWRAP_INSTALL_STAGING = YES
> -
> -ifeq ($(BR2_PACKAGE_IMX_VPU),y)
> -IMX_VPUWRAP_DEPENDENCIES = imx-vpu
> -endif
> -
> -ifeq ($(BR2_PACKAGE_IMX_VPU_HANTRO),y)
> -IMX_VPUWRAP_DEPENDENCIES = imx-vpu-hantro
> -endif
> -
> +IMX_VPUWRAP_DEPENDENCIES = \
> + $(if $(BR2_PACKAGE_IMX_VPU),imx-vpu) \
> + $(if $(BR2_PACKAGE_IMX_VPU_HANTRO),imx-vpu-hantro)
I've kept the multi-line conditonal blocks, and just used +=, then
applied to master, thanks.
Regards,
Yann E. MORIN.
> IMX_VPUWRAP_LICENSE = NXP Semiconductor Software License Agreement
> IMX_VPUWRAP_LICENSE_FILES = EULA COPYING
> IMX_VPUWRAP_REDISTRIBUTE = NO
> --
> 2.33.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/freescale-imx/imx-vpuwrap: don't override dependencies
2021-11-09 17:21 [Buildroot] [PATCH 1/1] package/freescale-imx/imx-vpuwrap: don't override dependencies Fabrice Fontaine
2021-11-10 9:42 ` Yann E. MORIN
@ 2021-11-17 15:02 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-11-17 15:02 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Gary Bisson, Refik Tuzakli, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Don't override IMX_VPUWRAP_DEPENDENCIES in a conditional
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2021.02.x and 2021.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-17 15:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-09 17:21 [Buildroot] [PATCH 1/1] package/freescale-imx/imx-vpuwrap: don't override dependencies Fabrice Fontaine
2021-11-10 9:42 ` Yann E. MORIN
2021-11-17 15:02 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox