* [Buildroot] [PATCH 1/1] package/alsa-lib: don't override dependencies
@ 2021-11-09 17:22 Fabrice Fontaine
2021-11-10 9:42 ` Yann E. MORIN
2021-11-17 15:02 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2021-11-09 17:22 UTC (permalink / raw)
To: buildroot; +Cc: Bernd Kuhls, Fabrice Fontaine
Don't override ALSA_LIB_DEPENDENCIES in a conditional
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/alsa-lib/alsa-lib.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/alsa-lib/alsa-lib.mk b/package/alsa-lib/alsa-lib.mk
index 99c53f9408..3bdde217ce 100644
--- a/package/alsa-lib/alsa-lib.mk
+++ b/package/alsa-lib/alsa-lib.mk
@@ -64,13 +64,13 @@ ALSA_LIB_CONF_OPTS += \
--with-pythonlibs=-lpython$(PYTHON_VERSION_MAJOR) \
--with-pythonincludes=$(STAGING_DIR)/usr/include/python$(PYTHON_VERSION_MAJOR)
ALSA_LIB_CFLAGS += -I$(STAGING_DIR)/usr/include/python$(PYTHON_VERSION_MAJOR)
-ALSA_LIB_DEPENDENCIES = python
+ALSA_LIB_DEPENDENCIES += python
else
ALSA_LIB_CONF_OPTS += \
--with-pythonlibs=-lpython$(PYTHON3_VERSION_MAJOR) \
--with-pythonincludes=$(STAGING_DIR)/usr/include/python$(PYTHON3_VERSION_MAJOR)
ALSA_LIB_CFLAGS += -I$(STAGING_DIR)/usr/include/python$(PYTHON3_VERSION_MAJOR)
-ALSA_LIB_DEPENDENCIES = python3
+ALSA_LIB_DEPENDENCIES += python3
endif
else
ALSA_LIB_CONF_OPTS += --disable-python
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/alsa-lib: don't override dependencies
2021-11-09 17:22 [Buildroot] [PATCH 1/1] package/alsa-lib: don't override dependencies Fabrice Fontaine
@ 2021-11-10 9:42 ` Yann E. MORIN
2021-11-17 15:02 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-11-10 9:42 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Bernd Kuhls, buildroot
Fabrice, All,
On 2021-11-09 18:22 +0100, Fabrice Fontaine spake thusly:
> Don't override ALSA_LIB_DEPENDENCIES in a conditional
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/alsa-lib/alsa-lib.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/alsa-lib/alsa-lib.mk b/package/alsa-lib/alsa-lib.mk
> index 99c53f9408..3bdde217ce 100644
> --- a/package/alsa-lib/alsa-lib.mk
> +++ b/package/alsa-lib/alsa-lib.mk
> @@ -64,13 +64,13 @@ ALSA_LIB_CONF_OPTS += \
> --with-pythonlibs=-lpython$(PYTHON_VERSION_MAJOR) \
> --with-pythonincludes=$(STAGING_DIR)/usr/include/python$(PYTHON_VERSION_MAJOR)
> ALSA_LIB_CFLAGS += -I$(STAGING_DIR)/usr/include/python$(PYTHON_VERSION_MAJOR)
> -ALSA_LIB_DEPENDENCIES = python
> +ALSA_LIB_DEPENDENCIES += python
> else
> ALSA_LIB_CONF_OPTS += \
> --with-pythonlibs=-lpython$(PYTHON3_VERSION_MAJOR) \
> --with-pythonincludes=$(STAGING_DIR)/usr/include/python$(PYTHON3_VERSION_MAJOR)
> ALSA_LIB_CFLAGS += -I$(STAGING_DIR)/usr/include/python$(PYTHON3_VERSION_MAJOR)
> -ALSA_LIB_DEPENDENCIES = python3
> +ALSA_LIB_DEPENDENCIES += python3
> endif
> else
> ALSA_LIB_CONF_OPTS += --disable-python
> --
> 2.33.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/alsa-lib: don't override dependencies
2021-11-09 17:22 [Buildroot] [PATCH 1/1] package/alsa-lib: don't override dependencies Fabrice Fontaine
2021-11-10 9:42 ` Yann E. MORIN
@ 2021-11-17 15:02 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-11-17 15:02 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Bernd Kuhls, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Don't override ALSA_LIB_DEPENDENCIES in a conditional
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2021.02.x and 2021.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-17 15:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-09 17:22 [Buildroot] [PATCH 1/1] package/alsa-lib: don't override dependencies Fabrice Fontaine
2021-11-10 9:42 ` Yann E. MORIN
2021-11-17 15:02 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox