From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: buildroot@uclibc.org
Subject: Re: [Buildroot] [PATCH 1/2] package/glmark2: drm-glesv2 needs libdrm
Date: Sat, 13 Nov 2021 10:55:54 +0100 [thread overview]
Message-ID: <20211113095554.GR247986@scaer> (raw)
In-Reply-To: <pan$592bf$4b5d782b$717424ed$c336ebd9@ID-313208.user.individual.net>
Bernd, All,
On 2021-11-13 10:33 +0100, Bernd Kuhls spake thusly:
> Am Thu, 11 Nov 2021 21:38:13 +0100 schrieb Yann E. MORIN:
>
> > Globally, I think glmark2 needs a bit of refactoring: it is very unusual
> > that the feature-set is before the main symbol. Usually, we have, in
> order:
> > - ARCH_SUPPORTS et al.
> > - main symbol
> > - if-block with all options.
> > - comment(s) about toolchain features et al.
> >
> > Could you look into that, and respin a full series that fixes all these
> > issues in glmark2, and adds the missing dependencies, please?
>
> Hi Yann,
>
> sent v2 with a minimal set of changes
>
> http://patchwork.ozlabs.org/project/buildroot/list/?series=271843
>
> which should fix the technical problems in Config.in while lacking time
> to do a full refactoring, sorry.
Thanks! I applied all three patches now. And no worries, refactoring
would have been nice but the fixes are already great! Thanks!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-11-13 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 20:29 [Buildroot] [PATCH 1/2] package/glmark2: drm-glesv2 needs libdrm Bernd Kuhls
2021-11-09 20:29 ` [Buildroot] [PATCH 2/2] package/glmark2: drm-glesv2 needs libgbm Bernd Kuhls
2021-11-11 20:38 ` [Buildroot] [PATCH 1/2] package/glmark2: drm-glesv2 needs libdrm Yann E. MORIN
[not found] ` <20211111203813.GB2609__12237.069783599$1636663125$gmane$org@scaer>
2021-11-13 9:33 ` Bernd Kuhls
2021-11-13 9:55 ` Yann E. MORIN [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-01-04 19:39 Bernd Kuhls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211113095554.GR247986@scaer \
--to=yann.morin.1998@free.fr \
--cc=bernd.kuhls@t-online.de \
--cc=buildroot@uclibc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox