* [Buildroot] [PATCH 1/2] package/glmark2: drm-glesv2 needs libdrm
@ 2020-01-04 19:39 Bernd Kuhls
0 siblings, 0 replies; 6+ messages in thread
From: Bernd Kuhls @ 2020-01-04 19:39 UTC (permalink / raw)
To: buildroot
Fixes:
http://autobuild.buildroot.net/results/58a/58a498fac83cbb55b252ab54cd8db04570bb5ec9/
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/glmark2/Config.in | 3 +++
package/glmark2/glmark2.mk | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/package/glmark2/Config.in b/package/glmark2/Config.in
index 153eb3b0af..09cd51f2cf 100644
--- a/package/glmark2/Config.in
+++ b/package/glmark2/Config.in
@@ -7,7 +7,10 @@ config BR2_PACKAGE_GLMARK2_FLAVOR_DRM_GLESV2
depends on BR2_PACKAGE_HAS_LIBEGL
depends on BR2_PACKAGE_HAS_LIBGLES
depends on BR2_PACKAGE_HAS_UDEV
+ # libpthread-stubs -> libdrm
+ depends on BR2_TOOLCHAIN_HAS_THREADS
select BR2_PACKAGE_GLMARK2_FLAVOR_ANY
+ select BR2_PACKAGE_LIBDRM
config BR2_PACKAGE_GLMARK2_FLAVOR_DRM_GL
bool
diff --git a/package/glmark2/glmark2.mk b/package/glmark2/glmark2.mk
index 3d31003d06..7c75711829 100644
--- a/package/glmark2/glmark2.mk
+++ b/package/glmark2/glmark2.mk
@@ -11,7 +11,7 @@ GLMARK2_LICENSE_FILES = COPYING COPYING.SGI
GLMARK2_DEPENDENCIES = host-pkgconf jpeg libegl libpng
ifeq ($(BR2_PACKAGE_GLMARK2_FLAVOR_DRM_GLESV2),y)
-GLMARK2_DEPENDENCIES += libgles udev
+GLMARK2_DEPENDENCIES += libdrm libgles udev
GLMARK2_FLAVORS += drm-glesv2
endif
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] package/glmark2: drm-glesv2 needs libdrm
@ 2021-11-09 20:29 Bernd Kuhls
2021-11-09 20:29 ` [Buildroot] [PATCH 2/2] package/glmark2: drm-glesv2 needs libgbm Bernd Kuhls
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Bernd Kuhls @ 2021-11-09 20:29 UTC (permalink / raw)
To: buildroot; +Cc: Spenser Gilliland
Fixes:
http://autobuild.buildroot.net/results/58a/58a498fac83cbb55b252ab54cd8db04570bb5ec9/
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
re-sent deferred patch
http://patchwork.ozlabs.org/project/buildroot/patch/20200104193919.91589-1-bernd.kuhls@t-online.de/
package/glmark2/Config.in | 3 +++
package/glmark2/glmark2.mk | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/package/glmark2/Config.in b/package/glmark2/Config.in
index 40d0adcc8a..96b34f971a 100644
--- a/package/glmark2/Config.in
+++ b/package/glmark2/Config.in
@@ -7,7 +7,10 @@ config BR2_PACKAGE_GLMARK2_FLAVOR_DRM_GLESV2
depends on BR2_PACKAGE_HAS_LIBEGL
depends on BR2_PACKAGE_HAS_LIBGLES
depends on BR2_PACKAGE_HAS_UDEV
+ # libpthread-stubs -> libdrm
+ depends on BR2_TOOLCHAIN_HAS_THREADS
select BR2_PACKAGE_GLMARK2_FLAVOR_ANY
+ select BR2_PACKAGE_LIBDRM
config BR2_PACKAGE_GLMARK2_FLAVOR_DRM_GL
bool
diff --git a/package/glmark2/glmark2.mk b/package/glmark2/glmark2.mk
index 5c2dd06362..5ad3ea2cb4 100644
--- a/package/glmark2/glmark2.mk
+++ b/package/glmark2/glmark2.mk
@@ -11,7 +11,7 @@ GLMARK2_LICENSE_FILES = COPYING COPYING.SGI
GLMARK2_DEPENDENCIES = host-pkgconf jpeg libegl libpng
ifeq ($(BR2_PACKAGE_GLMARK2_FLAVOR_DRM_GLESV2),y)
-GLMARK2_DEPENDENCIES += libgles udev
+GLMARK2_DEPENDENCIES += libdrm libgles udev
GLMARK2_FLAVORS += drm-glesv2
endif
--
2.30.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/glmark2: drm-glesv2 needs libgbm
2021-11-09 20:29 [Buildroot] [PATCH 1/2] package/glmark2: drm-glesv2 needs libdrm Bernd Kuhls
@ 2021-11-09 20:29 ` Bernd Kuhls
2021-11-11 20:38 ` [Buildroot] [PATCH 1/2] package/glmark2: drm-glesv2 needs libdrm Yann E. MORIN
[not found] ` <20211111203813.GB2609__12237.069783599$1636663125$gmane$org@scaer>
2 siblings, 0 replies; 6+ messages in thread
From: Bernd Kuhls @ 2021-11-09 20:29 UTC (permalink / raw)
To: buildroot; +Cc: Spenser Gilliland
Fixes build error with defconfig from:
http://autobuild.buildroot.net/results/e393dbfba7c2989fe983df47ea0638c3ba62ae7a/
Checking for 'libdrm': yes
Checking for 'gbm' : not found
after http://patchwork.ozlabs.org/project/buildroot/patch/20200104193919.91589-1-bernd.kuhls@t-online.de/
was applied. Both patches are needed to fix the build error.
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/glmark2/Config.in | 1 +
package/glmark2/glmark2.mk | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/glmark2/Config.in b/package/glmark2/Config.in
index 96b34f971a..491d1d73a7 100644
--- a/package/glmark2/Config.in
+++ b/package/glmark2/Config.in
@@ -5,6 +5,7 @@ config BR2_PACKAGE_GLMARK2_FLAVOR_DRM_GLESV2
bool
default y
depends on BR2_PACKAGE_HAS_LIBEGL
+ depends on BR2_PACKAGE_HAS_LIBGBM
depends on BR2_PACKAGE_HAS_LIBGLES
depends on BR2_PACKAGE_HAS_UDEV
# libpthread-stubs -> libdrm
diff --git a/package/glmark2/glmark2.mk b/package/glmark2/glmark2.mk
index 5ad3ea2cb4..e8d6f71dad 100644
--- a/package/glmark2/glmark2.mk
+++ b/package/glmark2/glmark2.mk
@@ -11,7 +11,7 @@ GLMARK2_LICENSE_FILES = COPYING COPYING.SGI
GLMARK2_DEPENDENCIES = host-pkgconf jpeg libegl libpng
ifeq ($(BR2_PACKAGE_GLMARK2_FLAVOR_DRM_GLESV2),y)
-GLMARK2_DEPENDENCIES += libdrm libgles udev
+GLMARK2_DEPENDENCIES += libdrm libgbm libgles udev
GLMARK2_FLAVORS += drm-glesv2
endif
--
2.30.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/glmark2: drm-glesv2 needs libdrm
2021-11-09 20:29 [Buildroot] [PATCH 1/2] package/glmark2: drm-glesv2 needs libdrm Bernd Kuhls
2021-11-09 20:29 ` [Buildroot] [PATCH 2/2] package/glmark2: drm-glesv2 needs libgbm Bernd Kuhls
@ 2021-11-11 20:38 ` Yann E. MORIN
[not found] ` <20211111203813.GB2609__12237.069783599$1636663125$gmane$org@scaer>
2 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2021-11-11 20:38 UTC (permalink / raw)
To: Bernd Kuhls; +Cc: Spenser Gilliland, buildroot
Bernd, All,
On 2021-11-09 21:29 +0100, Bernd Kuhls spake thusly:
> Fixes:
> http://autobuild.buildroot.net/results/58a/58a498fac83cbb55b252ab54cd8db04570bb5ec9/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> re-sent deferred patch
> http://patchwork.ozlabs.org/project/buildroot/patch/20200104193919.91589-1-bernd.kuhls@t-online.de/
>
> package/glmark2/Config.in | 3 +++
> package/glmark2/glmark2.mk | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/package/glmark2/Config.in b/package/glmark2/Config.in
> index 40d0adcc8a..96b34f971a 100644
> --- a/package/glmark2/Config.in
> +++ b/package/glmark2/Config.in
> @@ -7,7 +7,10 @@ config BR2_PACKAGE_GLMARK2_FLAVOR_DRM_GLESV2
> depends on BR2_PACKAGE_HAS_LIBEGL
> depends on BR2_PACKAGE_HAS_LIBGLES
> depends on BR2_PACKAGE_HAS_UDEV
> + # libpthread-stubs -> libdrm
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> select BR2_PACKAGE_GLMARK2_FLAVOR_ANY
> + select BR2_PACKAGE_LIBDRM
Oh no no no no!
This means that, even if glmark2 is not enabled, then libdrm will
forcibly be enabled in a configuration with libelg, libegls, and udev.
This is not correct *at all*. And IIRC, we already fixed a similar case
not so long ago... Ah, there it is:
b80c488d04 package/kodi: fix selection of dependencies
And now, I also notice that there is already such a bug in glmark2,
where wayland protocols will also forcibly be enabled in a configuration
with egl, gles, and wayland, even when glmark2 is not enabled.
Globally, I think glmark2 needs a bit of refactoring: it is very unusual
that the feature-set is before the main symbol. Usually, we have, in order:
- ARCH_SUPPORTS et al.
- main symbol
- if-block with all options.
- comment(s) about toolchain features et al.
Could you look into that, and respin a full series that fixes all these
issues in glmark2, and adds the missing dependencies, please?
Regards,
Yann E. MORIN.
> config BR2_PACKAGE_GLMARK2_FLAVOR_DRM_GL
> bool
> diff --git a/package/glmark2/glmark2.mk b/package/glmark2/glmark2.mk
> index 5c2dd06362..5ad3ea2cb4 100644
> --- a/package/glmark2/glmark2.mk
> +++ b/package/glmark2/glmark2.mk
> @@ -11,7 +11,7 @@ GLMARK2_LICENSE_FILES = COPYING COPYING.SGI
> GLMARK2_DEPENDENCIES = host-pkgconf jpeg libegl libpng
>
> ifeq ($(BR2_PACKAGE_GLMARK2_FLAVOR_DRM_GLESV2),y)
> -GLMARK2_DEPENDENCIES += libgles udev
> +GLMARK2_DEPENDENCIES += libdrm libgles udev
> GLMARK2_FLAVORS += drm-glesv2
> endif
>
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/glmark2: drm-glesv2 needs libdrm
[not found] ` <20211111203813.GB2609__12237.069783599$1636663125$gmane$org@scaer>
@ 2021-11-13 9:33 ` Bernd Kuhls
2021-11-13 9:55 ` Yann E. MORIN
0 siblings, 1 reply; 6+ messages in thread
From: Bernd Kuhls @ 2021-11-13 9:33 UTC (permalink / raw)
To: buildroot
Am Thu, 11 Nov 2021 21:38:13 +0100 schrieb Yann E. MORIN:
> Globally, I think glmark2 needs a bit of refactoring: it is very unusual
> that the feature-set is before the main symbol. Usually, we have, in
order:
> - ARCH_SUPPORTS et al.
> - main symbol
> - if-block with all options.
> - comment(s) about toolchain features et al.
>
> Could you look into that, and respin a full series that fixes all these
> issues in glmark2, and adds the missing dependencies, please?
Hi Yann,
sent v2 with a minimal set of changes
http://patchwork.ozlabs.org/project/buildroot/list/?series=271843
which should fix the technical problems in Config.in while lacking time
to do a full refactoring, sorry.
Regards, Bernd
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/glmark2: drm-glesv2 needs libdrm
2021-11-13 9:33 ` Bernd Kuhls
@ 2021-11-13 9:55 ` Yann E. MORIN
0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2021-11-13 9:55 UTC (permalink / raw)
To: Bernd Kuhls; +Cc: buildroot
Bernd, All,
On 2021-11-13 10:33 +0100, Bernd Kuhls spake thusly:
> Am Thu, 11 Nov 2021 21:38:13 +0100 schrieb Yann E. MORIN:
>
> > Globally, I think glmark2 needs a bit of refactoring: it is very unusual
> > that the feature-set is before the main symbol. Usually, we have, in
> order:
> > - ARCH_SUPPORTS et al.
> > - main symbol
> > - if-block with all options.
> > - comment(s) about toolchain features et al.
> >
> > Could you look into that, and respin a full series that fixes all these
> > issues in glmark2, and adds the missing dependencies, please?
>
> Hi Yann,
>
> sent v2 with a minimal set of changes
>
> http://patchwork.ozlabs.org/project/buildroot/list/?series=271843
>
> which should fix the technical problems in Config.in while lacking time
> to do a full refactoring, sorry.
Thanks! I applied all three patches now. And no worries, refactoring
would have been nice but the fixes are already great! Thanks!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-13 9:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-09 20:29 [Buildroot] [PATCH 1/2] package/glmark2: drm-glesv2 needs libdrm Bernd Kuhls
2021-11-09 20:29 ` [Buildroot] [PATCH 2/2] package/glmark2: drm-glesv2 needs libgbm Bernd Kuhls
2021-11-11 20:38 ` [Buildroot] [PATCH 1/2] package/glmark2: drm-glesv2 needs libdrm Yann E. MORIN
[not found] ` <20211111203813.GB2609__12237.069783599$1636663125$gmane$org@scaer>
2021-11-13 9:33 ` Bernd Kuhls
2021-11-13 9:55 ` Yann E. MORIN
-- strict thread matches above, loose matches on Subject: below --
2020-01-04 19:39 Bernd Kuhls
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox