From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] support/pkg-stats: support values with an equal sign in them
Date: Sat, 13 Nov 2021 15:21:30 +0100 [thread overview]
Message-ID: <20211113152130.560f51cf@windsurf> (raw)
In-Reply-To: <20211113124234.524796-1-yann.morin.1998@free.fr>
On Sat, 13 Nov 2021 13:42:34 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> The heuristic to extract the various variables of interest is pretty
> crude: we filter on variables ending with certain suffixes (like
> '%_VERSION' to get the version strings).
>
> However, in doing so, we may dump variables that are not actual package
> versions (especially with br2-external trees), and those may contain one
> or more equal sign. And anyway, an actual package version string may
> very well contain an equal sign too.
>
> But the current situation is that the output of 'printvars' is split on
> all equal signs, which will not fit in the 2-tuple we assign the result,
> thus causing an exception.
>
> Fix that by limiting to a single split.
>
> Reported-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
> support/scripts/pkg-stats | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master and next, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-11-13 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 12:42 [Buildroot] [PATCH] support/pkg-stats: support values with an equal sign in them Yann E. MORIN
2021-11-13 14:21 ` Thomas Petazzoni [this message]
2021-11-17 22:03 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211113152130.560f51cf@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox