Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/qt5/qt5base: add zstd optional dependency
@ 2021-11-14 10:15 Fabrice Fontaine
  2021-11-14 12:28 ` Peter Seiderer
  2021-11-14 13:35 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2021-11-14 10:15 UTC (permalink / raw)
  To: buildroot; +Cc: Peter Seiderer, Julien Corjon, Fabrice Fontaine

zstd is an optional dependency which is enabled by default since version
5.13.0 and
https://github.com/qt/qtbase/commit/f25bc30d8d9d13fffd34213dfbf5e7373a18222a

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/qt5/qt5base/qt5base.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
index 9da3de468a..b04d710d78 100644
--- a/package/qt5/qt5base/qt5base.mk
+++ b/package/qt5/qt5base/qt5base.mk
@@ -116,6 +116,13 @@ else
 QT5BASE_CONFIGURE_OPTS += -no-cups
 endif
 
+ifeq ($(BR2_PACKAGE_ZSTD),y)
+QT5BASE_DEPENDENCIES += zstd
+QT5BASE_CONFIGURE_OPTS += -zstd
+else
+QT5BASE_CONFIGURE_OPTS += -no-zstd
+endif
+
 # Qt5 SQL Plugins
 ifeq ($(BR2_PACKAGE_QT5BASE_SQL),y)
 ifeq ($(BR2_PACKAGE_QT5BASE_MYSQL),y)
-- 
2.33.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/qt5/qt5base: add zstd optional dependency
  2021-11-14 10:15 [Buildroot] [PATCH 1/1] package/qt5/qt5base: add zstd optional dependency Fabrice Fontaine
@ 2021-11-14 12:28 ` Peter Seiderer
  2021-11-14 13:35 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Seiderer @ 2021-11-14 12:28 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Julien Corjon, buildroot

Hello Fabrice,

On Sun, 14 Nov 2021 11:15:54 +0100, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> zstd is an optional dependency which is enabled by default since version
> 5.13.0 and
> https://github.com/qt/qtbase/commit/f25bc30d8d9d13fffd34213dfbf5e7373a18222a
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>


--- build/qt5base-5.15.2_orig/config.summary     2021-11-14 00:00:33.698378466 +0100
+++ build/qt5base-5.15.2/config.summary 2021-11-14 13:16:42.818139194 +0100
@@ -30,7 +30,7 @@
   Using pkg-config ....................... yes
   udev ................................... no
   Using system zlib ...................... yes
-  Zstandard support ...................... no
+  Zstandard support ...................... yes


Reviewed-by: Peter Seiderer <ps.report@gmx.net>

Regards,
Peter


> ---
>  package/qt5/qt5base/qt5base.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index 9da3de468a..b04d710d78 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -116,6 +116,13 @@ else
>  QT5BASE_CONFIGURE_OPTS += -no-cups
>  endif
>
> +ifeq ($(BR2_PACKAGE_ZSTD),y)
> +QT5BASE_DEPENDENCIES += zstd
> +QT5BASE_CONFIGURE_OPTS += -zstd
> +else
> +QT5BASE_CONFIGURE_OPTS += -no-zstd
> +endif
> +
>  # Qt5 SQL Plugins
>  ifeq ($(BR2_PACKAGE_QT5BASE_SQL),y)
>  ifeq ($(BR2_PACKAGE_QT5BASE_MYSQL),y)

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/qt5/qt5base: add zstd optional dependency
  2021-11-14 10:15 [Buildroot] [PATCH 1/1] package/qt5/qt5base: add zstd optional dependency Fabrice Fontaine
  2021-11-14 12:28 ` Peter Seiderer
@ 2021-11-14 13:35 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2021-11-14 13:35 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Peter Seiderer, Julien Corjon, buildroot

On Sun, 14 Nov 2021 11:15:54 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> zstd is an optional dependency which is enabled by default since version
> 5.13.0 and
> https://github.com/qt/qtbase/commit/f25bc30d8d9d13fffd34213dfbf5e7373a18222a
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/qt5/qt5base/qt5base.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied to next, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-11-14 13:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-14 10:15 [Buildroot] [PATCH 1/1] package/qt5/qt5base: add zstd optional dependency Fabrice Fontaine
2021-11-14 12:28 ` Peter Seiderer
2021-11-14 13:35 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox