Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/qt5/qt5base: add libkrb5 optional dependency
@ 2021-11-14 10:33 Fabrice Fontaine
  2021-11-14 12:32 ` Peter Seiderer
  2021-11-14 13:35 ` Thomas Petazzoni
  0 siblings, 2 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2021-11-14 10:33 UTC (permalink / raw)
  To: buildroot; +Cc: Peter Seiderer, Julien Corjon, Fabrice Fontaine

libkrb5 is an optional dependency which is enabled by default (with no
user option) since version 5.14.0 and
https://github.com/qt/qtbase/commit/93b7b0ec76572427291d8e2eef9a10eb499417a9

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/qt5/qt5base/qt5base.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
index b04d710d78..ba2971dc08 100644
--- a/package/qt5/qt5base/qt5base.mk
+++ b/package/qt5/qt5base/qt5base.mk
@@ -233,6 +233,8 @@ QT5BASE_DEPENDENCIES   += $(if $(BR2_PACKAGE_QT5BASE_TSLIB),tslib)
 QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_LIBGLIB2),-glib,-no-glib)
 QT5BASE_DEPENDENCIES   += $(if $(BR2_PACKAGE_LIBGLIB2),libglib2)
 
+QT5BASE_DEPENDENCIES   += $(if $(BR2_PACKAGE_LIBKRB5),libkrb5)
+
 QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_QT5BASE_ICU),-icu,-no-icu)
 QT5BASE_DEPENDENCIES   += $(if $(BR2_PACKAGE_QT5BASE_ICU),icu)
 
-- 
2.33.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/qt5/qt5base: add libkrb5 optional dependency
  2021-11-14 10:33 [Buildroot] [PATCH 1/1] package/qt5/qt5base: add libkrb5 optional dependency Fabrice Fontaine
@ 2021-11-14 12:32 ` Peter Seiderer
  2021-11-14 13:25   ` Fabrice Fontaine
  2021-11-14 13:35 ` Thomas Petazzoni
  1 sibling, 1 reply; 4+ messages in thread
From: Peter Seiderer @ 2021-11-14 12:32 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Julien Corjon, buildroot

Hello Fabrice,

On Sun, 14 Nov 2021 11:33:49 +0100, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> libkrb5 is an optional dependency which is enabled by default (with no
> user option) since version 5.14.0 and
> https://github.com/qt/qtbase/commit/93b7b0ec76572427291d8e2eef9a10eb499417a9
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>


--- build/qt5base-5.15.2_orig/config.summary     2021-11-14 00:00:33.698378466 +0100
+++ build/qt5base-5.15.2/config.summary 2021-11-14 13:16:42.818139194 +0100
[...]
@@ -57,7 +57,7 @@
   OCSP-stapling .......................... no
   SCTP ................................... no
   Use system proxies ..................... yes
-  GSSAPI ................................. no
+  GSSAPI ................................. yes
 Qt Gui:
   Accessibility .......................... yes
   FreeType ............................... no


Reviewed-by: Peter Seiderer <ps.report@gmx.net>

Out of interest, how did you stumble over this and the zstd one?

Regards,
Peter


> ---
>  package/qt5/qt5base/qt5base.mk | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index b04d710d78..ba2971dc08 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -233,6 +233,8 @@ QT5BASE_DEPENDENCIES   += $(if $(BR2_PACKAGE_QT5BASE_TSLIB),tslib)
>  QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_LIBGLIB2),-glib,-no-glib)
>  QT5BASE_DEPENDENCIES   += $(if $(BR2_PACKAGE_LIBGLIB2),libglib2)
>
> +QT5BASE_DEPENDENCIES   += $(if $(BR2_PACKAGE_LIBKRB5),libkrb5)
> +
>  QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_QT5BASE_ICU),-icu,-no-icu)
>  QT5BASE_DEPENDENCIES   += $(if $(BR2_PACKAGE_QT5BASE_ICU),icu)
>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/qt5/qt5base: add libkrb5 optional dependency
  2021-11-14 12:32 ` Peter Seiderer
@ 2021-11-14 13:25   ` Fabrice Fontaine
  0 siblings, 0 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2021-11-14 13:25 UTC (permalink / raw)
  To: Peter Seiderer; +Cc: Julien Corjon, Buildroot Mailing List

Hello Peter,

Le dim. 14 nov. 2021 à 13:32, Peter Seiderer <ps.report@gmx.net> a écrit :
>
> Hello Fabrice,
>
> On Sun, 14 Nov 2021 11:33:49 +0100, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > libkrb5 is an optional dependency which is enabled by default (with no
> > user option) since version 5.14.0 and
> > https://github.com/qt/qtbase/commit/93b7b0ec76572427291d8e2eef9a10eb499417a9
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
>
> --- build/qt5base-5.15.2_orig/config.summary     2021-11-14 00:00:33.698378466 +0100
> +++ build/qt5base-5.15.2/config.summary 2021-11-14 13:16:42.818139194 +0100
> [...]
> @@ -57,7 +57,7 @@
>    OCSP-stapling .......................... no
>    SCTP ................................... no
>    Use system proxies ..................... yes
> -  GSSAPI ................................. no
> +  GSSAPI ................................. yes
>  Qt Gui:
>    Accessibility .......................... yes
>    FreeType ............................... no
>
>
> Reviewed-by: Peter Seiderer <ps.report@gmx.net>
>
> Out of interest, how did you stumble over this and the zstd one?
I found out those issues when investigating the following build failure:
http://autobuild.buildroot.org/results/a0c/a0ce11c1984a2b5344a1d659400d0b08cd884513/build-end.log
>
> Regards,
> Peter
>
>
> > ---
> >  package/qt5/qt5base/qt5base.mk | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> > index b04d710d78..ba2971dc08 100644
> > --- a/package/qt5/qt5base/qt5base.mk
> > +++ b/package/qt5/qt5base/qt5base.mk
> > @@ -233,6 +233,8 @@ QT5BASE_DEPENDENCIES   += $(if $(BR2_PACKAGE_QT5BASE_TSLIB),tslib)
> >  QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_LIBGLIB2),-glib,-no-glib)
> >  QT5BASE_DEPENDENCIES   += $(if $(BR2_PACKAGE_LIBGLIB2),libglib2)
> >
> > +QT5BASE_DEPENDENCIES   += $(if $(BR2_PACKAGE_LIBKRB5),libkrb5)
> > +
> >  QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_QT5BASE_ICU),-icu,-no-icu)
> >  QT5BASE_DEPENDENCIES   += $(if $(BR2_PACKAGE_QT5BASE_ICU),icu)
> >
>
Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/qt5/qt5base: add libkrb5 optional dependency
  2021-11-14 10:33 [Buildroot] [PATCH 1/1] package/qt5/qt5base: add libkrb5 optional dependency Fabrice Fontaine
  2021-11-14 12:32 ` Peter Seiderer
@ 2021-11-14 13:35 ` Thomas Petazzoni
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2021-11-14 13:35 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Peter Seiderer, Julien Corjon, buildroot

On Sun, 14 Nov 2021 11:33:49 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> libkrb5 is an optional dependency which is enabled by default (with no
> user option) since version 5.14.0 and
> https://github.com/qt/qtbase/commit/93b7b0ec76572427291d8e2eef9a10eb499417a9
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/qt5/qt5base/qt5base.mk | 2 ++
>  1 file changed, 2 insertions(+)

Applied to next, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-14 13:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-14 10:33 [Buildroot] [PATCH 1/1] package/qt5/qt5base: add libkrb5 optional dependency Fabrice Fontaine
2021-11-14 12:32 ` Peter Seiderer
2021-11-14 13:25   ` Fabrice Fontaine
2021-11-14 13:35 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox