Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/libodb-mysql: don't use mysql_config outside static build
@ 2021-11-13 10:51 Fabrice Fontaine
  2021-11-14 14:21 ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Fabrice Fontaine @ 2021-11-13 10:51 UTC (permalink / raw)
  To: buildroot; +Cc: Kamel Bouhara, Fabrice Fontaine

uclibc (and glibc) installs the following ld script in
$(STAGING_DIR)/usr/lib/libc.so in addition to the 'standard' library
installed in $(STAGING_DIR)/lib:

/* GNU ld script
 * Use the shared library, but some functions are only in
 * the static library, so try that secondarily. */
OUTPUT_FORMAT("elf32-powerpc", "elf32-powerpc",
	      "elf32-powerpc")
GROUP ( /lib/libc.so.1 /usr/lib/uclibc_nonshared.a libpthread_nonshared.a AS_NEEDED ( /lib/ld-uClibc.so.1 ) )

For an unknown reason, if this script is used, this will result in
the following build failure:

configure:3286: /home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/libodb-mysql/host/bin/powerpc-buildroot-linux-uclibc-gcc -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os -g0  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  conftest.c -rdynamic -L/home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/libodb-mysql/host/powerpc-buildroot-linux-uclibc/sysroot/usr/lib/mysql -lmysqlclient -L/home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/oracle-mysql/host/powerpc-buildroot-linux-uclibc/sysroot/usr/lib -lz -lnsl -lm >&5
/home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/libodb-mysql/host/bin/../lib/gcc/powerpc-buildroot-linux-uclibc/10.3.0/../../../../powerpc-buildroot-linux-uclibc/bin/ld: cannot find /lib/libc.so.1
/home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/libodb-mysql/host/bin/../lib/gcc/powerpc-buildroot-linux-uclibc/10.3.0/../../../../powerpc-buildroot-linux-uclibc/bin/ld: cannot find /usr/lib/uclibc_nonshared.a
/home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/libodb-mysql/host/bin/../lib/gcc/powerpc-buildroot-linux-uclibc/10.3.0/../../../../powerpc-buildroot-linux-uclibc/bin/ld: cannot find /lib/ld-uClibc.so.1

To fix this build failure, don't use mysql_config outside of static
builds.

It should be noted that this issue also affects open2300 and rsyslog
which should also be updated.

Fixes:
 - http://autobuild.buildroot.org/results/9e3c09dd3d9bd55de14fc89a1d17ba9c008b195b

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libodb-mysql/libodb-mysql.mk | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/package/libodb-mysql/libodb-mysql.mk b/package/libodb-mysql/libodb-mysql.mk
index 88b6f4cb31..d2fa977209 100644
--- a/package/libodb-mysql/libodb-mysql.mk
+++ b/package/libodb-mysql/libodb-mysql.mk
@@ -12,8 +12,10 @@ LIBODB_MYSQL_INSTALL_STAGING = YES
 LIBODB_MYSQL_LICENSE = GPL-2.0
 LIBODB_MYSQL_LICENSE_FILES = LICENSE
 LIBODB_MYSQL_DEPENDENCIES = libodb mysql
-LIBODB_MYSQL_CONF_ENV = \
-	CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11" \
-	LIBS=`$(STAGING_DIR)/usr/bin/mysql_config --libs`
+LIBODB_MYSQL_CONF_ENV = CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11"
+
+ifeq ($(BR2_STATIC_LIBS),y)
+LIBODB_MYSQL_CONF_ENV += LIBS="`$(STAGING_DIR)/usr/bin/mysql_config --libs`"
+endif
 
 $(eval $(autotools-package))
-- 
2.33.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libodb-mysql: don't use mysql_config outside static build
  2021-11-13 10:51 [Buildroot] [PATCH 1/1] package/libodb-mysql: don't use mysql_config outside static build Fabrice Fontaine
@ 2021-11-14 14:21 ` Thomas Petazzoni
  2021-11-14 14:26   ` Fabrice Fontaine
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2021-11-14 14:21 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Kamel Bouhara, buildroot

Hello Fabrice,

On Sat, 13 Nov 2021 11:51:30 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> uclibc (and glibc) installs the following ld script in
> $(STAGING_DIR)/usr/lib/libc.so in addition to the 'standard' library
> installed in $(STAGING_DIR)/lib:
> 
> /* GNU ld script
>  * Use the shared library, but some functions are only in
>  * the static library, so try that secondarily. */
> OUTPUT_FORMAT("elf32-powerpc", "elf32-powerpc",
> 	      "elf32-powerpc")
> GROUP ( /lib/libc.so.1 /usr/lib/uclibc_nonshared.a libpthread_nonshared.a AS_NEEDED ( /lib/ld-uClibc.so.1 ) )
> 
> For an unknown reason, if this script is used, this will result in
> the following build failure:
> 
> configure:3286: /home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/libodb-mysql/host/bin/powerpc-buildroot-linux-uclibc-gcc -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os -g0  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  conftest.c -rdynamic -L/home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/libodb-mysql/host/powerpc-buildroot-linux-uclibc/sysroot/usr/lib/mysql -lmysqlclient -L/home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/oracle-mysql/host/powerpc-buildroot-linux-uclibc/sysroot/usr/lib -lz -lnsl -lm >&5
> /home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/libodb-mysql/host/bin/../lib/gcc/powerpc-buildroot-linux-uclibc/10.3.0/../../../../powerpc-buildroot-linux-uclibc/bin/ld: cannot find /lib/libc.so.1
> /home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/libodb-mysql/host/bin/../lib/gcc/powerpc-buildroot-linux-uclibc/10.3.0/../../../../powerpc-buildroot-linux-uclibc/bin/ld: cannot find /usr/lib/uclibc_nonshared.a
> /home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/libodb-mysql/host/bin/../lib/gcc/powerpc-buildroot-linux-uclibc/10.3.0/../../../../powerpc-buildroot-linux-uclibc/bin/ld: cannot find /lib/ld-uClibc.so.1
> 
> To fix this build failure, don't use mysql_config outside of static
> builds.

Do you have a minimal defconfig to reproduce the build failure? Indeed,
I remember already seeing and fixing similar issues arising when
BR2_PER_PACKAGE_DIRECTORIES=y (which is enabled in the failing
configuration). And for I remember, this was due to incorrect -L flags.
In the example here, you have two -L:

-L/home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/libodb-mysql/host/powerpc-buildroot-linux-uclibc/sysroot/usr/lib/mysql
-L/home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/oracle-mysql/host/powerpc-buildroot-linux-uclibc/sysroot/usr/lib

The former is correct, the latter is not, and it does cause this kind
of linker issue. So the real fix (I think!) is not understand why we
have this bogus second -L option, and get rid of it.

You can read the commit log of a18c828bed99d7e0db5128224ffcda4897cd8e80
which explains what is going on.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libodb-mysql: don't use mysql_config outside static build
  2021-11-14 14:21 ` Thomas Petazzoni
@ 2021-11-14 14:26   ` Fabrice Fontaine
  0 siblings, 0 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2021-11-14 14:26 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: Kamel Bouhara, Buildroot Mailing List

Hello Thomas,

Le dim. 14 nov. 2021 à 15:21, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a écrit :
>
> Hello Fabrice,
>
> On Sat, 13 Nov 2021 11:51:30 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > uclibc (and glibc) installs the following ld script in
> > $(STAGING_DIR)/usr/lib/libc.so in addition to the 'standard' library
> > installed in $(STAGING_DIR)/lib:
> >
> > /* GNU ld script
> >  * Use the shared library, but some functions are only in
> >  * the static library, so try that secondarily. */
> > OUTPUT_FORMAT("elf32-powerpc", "elf32-powerpc",
> >             "elf32-powerpc")
> > GROUP ( /lib/libc.so.1 /usr/lib/uclibc_nonshared.a libpthread_nonshared.a AS_NEEDED ( /lib/ld-uClibc.so.1 ) )
> >
> > For an unknown reason, if this script is used, this will result in
> > the following build failure:
> >
> > configure:3286: /home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/libodb-mysql/host/bin/powerpc-buildroot-linux-uclibc-gcc -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os -g0  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  conftest.c -rdynamic -L/home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/libodb-mysql/host/powerpc-buildroot-linux-uclibc/sysroot/usr/lib/mysql -lmysqlclient -L/home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/oracle-mysql/host/powerpc-buildroot-linux-uclibc/sysroot/usr/lib -lz -lnsl -lm >&5
> > /home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/libodb-mysql/host/bin/../lib/gcc/powerpc-buildroot-linux-uclibc/10.3.0/../../../../powerpc-buildroot-linux-uclibc/bin/ld: cannot find /lib/libc.so.1
> > /home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/libodb-mysql/host/bin/../lib/gcc/powerpc-buildroot-linux-uclibc/10.3.0/../../../../powerpc-buildroot-linux-uclibc/bin/ld: cannot find /usr/lib/uclibc_nonshared.a
> > /home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/libodb-mysql/host/bin/../lib/gcc/powerpc-buildroot-linux-uclibc/10.3.0/../../../../powerpc-buildroot-linux-uclibc/bin/ld: cannot find /lib/ld-uClibc.so.1
> >
> > To fix this build failure, don't use mysql_config outside of static
> > builds.
>
> Do you have a minimal defconfig to reproduce the build failure? Indeed,
> I remember already seeing and fixing similar issues arising when
> BR2_PER_PACKAGE_DIRECTORIES=y (which is enabled in the failing
> configuration). And for I remember, this was due to incorrect -L flags.
> In the example here, you have two -L:
>
> -L/home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/libodb-mysql/host/powerpc-buildroot-linux-uclibc/sysroot/usr/lib/mysql
> -L/home/giuliobenetti/autobuild/run/instance-3/output-1/per-package/oracle-mysql/host/powerpc-buildroot-linux-uclibc/sysroot/usr/lib
>
> The former is correct, the latter is not, and it does cause this kind
> of linker issue. So the real fix (I think!) is not understand why we
> have this bogus second -L option, and get rid of it.
The second -L option is "hard-coded" in mysql_config which is itself
generated by oracle-mysql-5.1.73/scripts/mysql_config.pl.in.
I'll investigate how to fix it.
>
> You can read the commit log of a18c828bed99d7e0db5128224ffcda4897cd8e80
> which explains what is going on.
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-14 14:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-13 10:51 [Buildroot] [PATCH 1/1] package/libodb-mysql: don't use mysql_config outside static build Fabrice Fontaine
2021-11-14 14:21 ` Thomas Petazzoni
2021-11-14 14:26   ` Fabrice Fontaine

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox