Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Francois Perrad <fperrad@gmail.com>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH v2] board/olimex/stmp1_olinuxino: add STMP157-OLinuXino-LIME2 board support
Date: Fri, 17 Dec 2021 23:00:47 +0100	[thread overview]
Message-ID: <20211217230047.16353bdf@windsurf> (raw)
In-Reply-To: <20211211080949.206284-1-francois.perrad@gadz.org>

Hello François,

On Sat, 11 Dec 2021 09:09:49 +0100
Francois Perrad <fperrad@gmail.com> wrote:

> kernel:
> - the device tree is not yet mainline
> - ITE IT66121 (HDMI) is mainline only since 5.14
> 
> u-boot:
> - the device tree is not yet mainline
> - this board uses AXP209 as PMIC instead of the STPMIC1,
>   this use case of AXP209 is not mainline
> 
> arm-trusted-firmware:
> at this time, there is no patch for this board,
> so u-boot-spl is used as FSBL (basic boot chain)

Could we use the code from the Olimex Github repos instead? Your commit
really adds two many large board-specific patches. We try hard to avoid
this kind of stuff in Buildroot.

Also, I think the kernel config file shouldn't have comments. We pretty
much never do that with kernel configuration files as it's too annoying
to maintain.

Finally, your SoB line is missing.

Could you rework this?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2021-12-17 22:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-11  8:09 [Buildroot] [PATCH v2] board/olimex/stmp1_olinuxino: add STMP157-OLinuXino-LIME2 board support Francois Perrad
2021-12-17 22:00 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211217230047.16353bdf@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    --cc=fperrad@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox