Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] configs/kontron_smarc_sal28: move gpt between rcw and bootloader
@ 2021-12-27 10:55 Michael Walle
  2021-12-27 11:13 ` Giulio Benetti
  2021-12-27 14:44 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Michael Walle @ 2021-12-27 10:55 UTC (permalink / raw)
  To: buildroot; +Cc: Michael Walle

genimage v15 complains about the GPT overlapping with the RCW. Move it
to offset 16k which is between the rcw (which isn't expected to grow
much more) and the bootloader.

This will fix the following error:
ERROR: hdimage(sdcard-emmc.img): partition [GPT array] (offset 0x400, size 0x4000) overlaps previous partition rcw (offset 0x1000, size 0x580)
ERROR: hdimage(sdcard-emmc.img): bootloaders, etc. that overlap with the partition table must declare the overlapping area as a hole.

Signed-off-by: Michael Walle <michael@walle.cc>
---

Please note, that this patch applies on top of
https://lore.kernel.org/buildroot/20211219142035.6220-2-peter@korsgaard.com/

 board/kontron/smarc-sal28/genimage.cfg | 1 +
 1 file changed, 1 insertion(+)

diff --git a/board/kontron/smarc-sal28/genimage.cfg b/board/kontron/smarc-sal28/genimage.cfg
index 0ad020b347..c885cd51a6 100644
--- a/board/kontron/smarc-sal28/genimage.cfg
+++ b/board/kontron/smarc-sal28/genimage.cfg
@@ -1,6 +1,7 @@
 image sdcard-emmc.img {
 	hdimage {
 		partition-table-type = "gpt"
+		gpt-location = 16K
 	}
 
 	partition rcw {
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] configs/kontron_smarc_sal28: move gpt between rcw and bootloader
  2021-12-27 10:55 [Buildroot] [PATCH] configs/kontron_smarc_sal28: move gpt between rcw and bootloader Michael Walle
@ 2021-12-27 11:13 ` Giulio Benetti
  2021-12-27 14:44 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Giulio Benetti @ 2021-12-27 11:13 UTC (permalink / raw)
  To: Michael Walle, buildroot

Hi Michael, All,

On 27/12/21 11:55, Michael Walle wrote:
> genimage v15 complains about the GPT overlapping with the RCW. Move it
> to offset 16k which is between the rcw (which isn't expected to grow
> much more) and the bootloader.
> 
> This will fix the following error:
> ERROR: hdimage(sdcard-emmc.img): partition [GPT array] (offset 0x400, size 0x4000) overlaps previous partition rcw (offset 0x1000, size 0x580)
> ERROR: hdimage(sdcard-emmc.img): bootloaders, etc. that overlap with the partition table must declare the overlapping area as a hole.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>

Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

> ---
> 
> Please note, that this patch applies on top of
> https://lore.kernel.org/buildroot/20211219142035.6220-2-peter@korsgaard.com/
> 
>   board/kontron/smarc-sal28/genimage.cfg | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/board/kontron/smarc-sal28/genimage.cfg b/board/kontron/smarc-sal28/genimage.cfg
> index 0ad020b347..c885cd51a6 100644
> --- a/board/kontron/smarc-sal28/genimage.cfg
> +++ b/board/kontron/smarc-sal28/genimage.cfg
> @@ -1,6 +1,7 @@
>   image sdcard-emmc.img {
>   	hdimage {
>   		partition-table-type = "gpt"
> +		gpt-location = 16K
>   	}
>   
>   	partition rcw {
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] configs/kontron_smarc_sal28: move gpt between rcw and bootloader
  2021-12-27 10:55 [Buildroot] [PATCH] configs/kontron_smarc_sal28: move gpt between rcw and bootloader Michael Walle
  2021-12-27 11:13 ` Giulio Benetti
@ 2021-12-27 14:44 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2021-12-27 14:44 UTC (permalink / raw)
  To: Michael Walle; +Cc: buildroot

On Mon, 27 Dec 2021 11:55:50 +0100
Michael Walle <michael@walle.cc> wrote:

> genimage v15 complains about the GPT overlapping with the RCW. Move it
> to offset 16k which is between the rcw (which isn't expected to grow
> much more) and the bootloader.
> 
> This will fix the following error:
> ERROR: hdimage(sdcard-emmc.img): partition [GPT array] (offset 0x400, size 0x4000) overlaps previous partition rcw (offset 0x1000, size 0x580)
> ERROR: hdimage(sdcard-emmc.img): bootloaders, etc. that overlap with the partition table must declare the overlapping area as a hole.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-27 14:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-27 10:55 [Buildroot] [PATCH] configs/kontron_smarc_sal28: move gpt between rcw and bootloader Michael Walle
2021-12-27 11:13 ` Giulio Benetti
2021-12-27 14:44 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox