* [Buildroot] [PATCH] package/binutils: fix an OpenRISC binutils 2.37 patch
@ 2021-12-26 10:33 Thomas Petazzoni
2021-12-26 10:49 ` Giulio Benetti
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2021-12-26 10:33 UTC (permalink / raw)
To: buildroot; +Cc: Romain Naour, Giulio Benetti, Thomas Petazzoni
When binutils 2.37 was introduced in commit
62f0232980c8168631b29f27edf612af8109c691 ("package/binutils: add
version 2.37"), the patch
0008-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch was
not properly updated. Indeed, between binutils 2.36 and 2.37, binutils
has switched to using the standard "bool" type, so instead of using
TRUE/FALSE, true/false must be used.
With this change, the binutils patch matches the one that was merged
upstream.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
...4-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/binutils/2.37/0004-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch b/package/binutils/2.37/0004-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch
index 779baeab63..0d18321ee1 100644
--- a/package/binutils/2.37/0004-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch
+++ b/package/binutils/2.37/0004-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch
@@ -46,7 +46,7 @@ index 32063ab0289..67252394173 100644
+ _bfd_error_handler
+ (_("%pB: pc-relative relocation against dynamic symbol %s"),
+ input_bfd, name);
-+ ret_val = FALSE;
++ ret_val = false;
+ bfd_set_error (bfd_error_bad_value);
+ }
+ break;
--
2.31.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/binutils: fix an OpenRISC binutils 2.37 patch
2021-12-26 10:33 [Buildroot] [PATCH] package/binutils: fix an OpenRISC binutils 2.37 patch Thomas Petazzoni
@ 2021-12-26 10:49 ` Giulio Benetti
2021-12-27 19:16 ` Yann E. MORIN
2022-01-25 16:43 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Giulio Benetti @ 2021-12-26 10:49 UTC (permalink / raw)
To: Thomas Petazzoni, buildroot; +Cc: Romain Naour
On 26/12/21 11:33, Thomas Petazzoni wrote:
> When binutils 2.37 was introduced in commit
> 62f0232980c8168631b29f27edf612af8109c691 ("package/binutils: add
> version 2.37"), the patch
> 0008-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch was
> not properly updated. Indeed, between binutils 2.36 and 2.37, binutils
> has switched to using the standard "bool" type, so instead of using
> TRUE/FALSE, true/false must be used.
>
> With this change, the binutils patch matches the one that was merged
> upstream.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Best regards
--
Giulio Benetti
Benetti Engineering sas
> ---
> ...4-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/binutils/2.37/0004-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch b/package/binutils/2.37/0004-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch
> index 779baeab63..0d18321ee1 100644
> --- a/package/binutils/2.37/0004-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch
> +++ b/package/binutils/2.37/0004-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch
> @@ -46,7 +46,7 @@ index 32063ab0289..67252394173 100644
> + _bfd_error_handler
> + (_("%pB: pc-relative relocation against dynamic symbol %s"),
> + input_bfd, name);
> -+ ret_val = FALSE;
> ++ ret_val = false;
> + bfd_set_error (bfd_error_bad_value);
> + }
> + break;
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/binutils: fix an OpenRISC binutils 2.37 patch
2021-12-26 10:33 [Buildroot] [PATCH] package/binutils: fix an OpenRISC binutils 2.37 patch Thomas Petazzoni
2021-12-26 10:49 ` Giulio Benetti
@ 2021-12-27 19:16 ` Yann E. MORIN
2022-01-25 16:43 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2021-12-27 19:16 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Romain Naour, Giulio Benetti, buildroot
Thomas, All,
On 2021-12-26 11:33 +0100, Thomas Petazzoni spake thusly:
> When binutils 2.37 was introduced in commit
> 62f0232980c8168631b29f27edf612af8109c691 ("package/binutils: add
> version 2.37"), the patch
> 0008-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch was
> not properly updated. Indeed, between binutils 2.36 and 2.37, binutils
> has switched to using the standard "bool" type, so instead of using
> TRUE/FALSE, true/false must be used.
>
> With this change, the binutils patch matches the one that was merged
> upstream.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> ...4-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/binutils/2.37/0004-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch b/package/binutils/2.37/0004-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch
> index 779baeab63..0d18321ee1 100644
> --- a/package/binutils/2.37/0004-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch
> +++ b/package/binutils/2.37/0004-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch
> @@ -46,7 +46,7 @@ index 32063ab0289..67252394173 100644
> + _bfd_error_handler
> + (_("%pB: pc-relative relocation against dynamic symbol %s"),
> + input_bfd, name);
> -+ ret_val = FALSE;
> ++ ret_val = false;
> + bfd_set_error (bfd_error_bad_value);
> + }
> + break;
> --
> 2.31.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/binutils: fix an OpenRISC binutils 2.37 patch
2021-12-26 10:33 [Buildroot] [PATCH] package/binutils: fix an OpenRISC binutils 2.37 patch Thomas Petazzoni
2021-12-26 10:49 ` Giulio Benetti
2021-12-27 19:16 ` Yann E. MORIN
@ 2022-01-25 16:43 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2022-01-25 16:43 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Romain Naour, Giulio Benetti, buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> When binutils 2.37 was introduced in commit
> 62f0232980c8168631b29f27edf612af8109c691 ("package/binutils: add
> version 2.37"), the patch
> 0008-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch was
> not properly updated. Indeed, between binutils 2.36 and 2.37, binutils
> has switched to using the standard "bool" type, so instead of using
> TRUE/FALSE, true/false must be used.
> With this change, the binutils patch matches the one that was merged
> upstream.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2021.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-25 16:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-26 10:33 [Buildroot] [PATCH] package/binutils: fix an OpenRISC binutils 2.37 patch Thomas Petazzoni
2021-12-26 10:49 ` Giulio Benetti
2021-12-27 19:16 ` Yann E. MORIN
2022-01-25 16:43 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox