[Buildroot] [PATCH 1/1] package/ncmpc: needs threads

[Buildroot] [PATCH 1/1] package/ncmpc: needs threads

[Fabrice Fontaine]

threads dependency was wrongly removed by commit
d29d1368478df621c2426820e1a6019225467234

Fixes:
 - http://autobuild.buildroot.org/results/151765cb4000643048e8d86c7a49bc8bcbf9f390

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/ncmpc/Config.in | 5 +++--
 package/ncmpc/ncmpc.mk  | 3 +--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/ncmpc/Config.in b/package/ncmpc/Config.in
index 4155404fcf..eda6e0bbd5 100644
--- a/package/ncmpc/Config.in
+++ b/package/ncmpc/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_NCMPC
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_USE_WCHAR
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17
 	select BR2_PACKAGE_LIBMPDCLIENT
 	select BR2_PACKAGE_NCURSES
@@ -13,7 +14,7 @@ config BR2_PACKAGE_NCMPC
 
 	  http://www.musicpd.org/clients/ncmpc/
 
-comment "ncmpc needs a toolchain w/ C++, wchar, gcc >= 7"
+comment "ncmpc needs a toolchain w/ C++, wchar, threads, gcc >= 7"
 	depends on BR2_USE_MMU
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
-		!BR2_TOOLCHAIN_GCC_AT_LEAST_7
+		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_7
diff --git a/package/ncmpc/ncmpc.mk b/package/ncmpc/ncmpc.mk
index 91859cbc24..41fface525 100644
--- a/package/ncmpc/ncmpc.mk
+++ b/package/ncmpc/ncmpc.mk
@@ -20,8 +20,7 @@ NCMPC_CPE_ID_VENDOR = ncmpc_project
 NCMPC_CONF_OPTS = \
 	-Dcurses=ncurses \
 	-Ddocumentation=disabled \
-	$(if $(BR2_SYSTEM_ENABLE_NLS),-Dnls=enabled,-Dnls=disabled) \
-	$(if $(BR2_TOOLCHAIN_HAS_THREADS),-Dsignalfd=true,-Dsignalfd=false)
+	$(if $(BR2_SYSTEM_ENABLE_NLS),-Dnls=enabled,-Dnls=disabled)
 
 ifeq ($(BR2_PACKAGE_LIRC_TOOLS),y)
 NCMPC_DEPENDENCIES += lirc-tools
-- 
2.33.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/ncmpc: needs threads

[Thomas Petazzoni]

On Mon, 27 Dec 2021 20:06:36 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> threads dependency was wrongly removed by commit
> d29d1368478df621c2426820e1a6019225467234
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/151765cb4000643048e8d86c7a49bc8bcbf9f390
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/ncmpc/Config.in | 5 +++--
>  package/ncmpc/ncmpc.mk  | 3 +--
>  2 files changed, 4 insertions(+), 4 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot