[Buildroot] [PATCH] package/glibmm: needs BR2_TOOLCHAIN_HAS_SYNC_4

[Buildroot] [PATCH] package/glibmm: needs BR2_TOOLCHAIN_HAS_SYNC_4

[Giulio Benetti]

Add BR2_TOOLCHAIN_HAS_SYNC_4 and restyle the with "|| \" form.

Fixes:
http://autobuild.buildroot.net/results/6a2/6a2709956fbb16ac3cbf676acb242c88f83fcdae/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/glibmm/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/glibmm/Config.in b/package/glibmm/Config.in
index 2dfc861817..1b27f8cbb1 100644
--- a/package/glibmm/Config.in
+++ b/package/glibmm/Config.in
@@ -4,6 +4,7 @@ config BR2_PACKAGE_GLIBMM
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_USE_WCHAR # libglib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on BR2_USE_MMU # libglib2
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_LIBSIGC
@@ -14,5 +15,6 @@ config BR2_PACKAGE_GLIBMM
 
 comment "glibmm needs a toolchain w/ C++, wchar, threads, gcc >= 7"
 	depends on BR2_USE_MMU
-	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_USE_WCHAR \
-		|| !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_USE_WCHAR || \
+		!BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_TOOLCHAIN_HAS_SYNC_4
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/glibmm: needs BR2_TOOLCHAIN_HAS_SYNC_4

[Thomas Petazzoni]

Hello Giulio,

On Wed, 29 Dec 2021 10:56:00 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Add BR2_TOOLCHAIN_HAS_SYNC_4 and restyle the with "|| \" form.
> 
> Fixes:
> http://autobuild.buildroot.net/results/6a2/6a2709956fbb16ac3cbf676acb242c88f83fcdae/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/glibmm/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/glibmm/Config.in b/package/glibmm/Config.in
> index 2dfc861817..1b27f8cbb1 100644
> --- a/package/glibmm/Config.in
> +++ b/package/glibmm/Config.in
> @@ -4,6 +4,7 @@ config BR2_PACKAGE_GLIBMM
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_USE_WCHAR # libglib2
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4

Not the correct fix: you're confusing the sync built-ins with the atomic
built-ins. Fabrice sent the correct fix a few minutes before yours :-)

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/glibmm: needs BR2_TOOLCHAIN_HAS_SYNC_4

[Giulio Benetti]

On 29/12/21 11:20, Thomas Petazzoni wrote:
> Hello Giulio,
> 
> On Wed, 29 Dec 2021 10:56:00 +0100
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> Add BR2_TOOLCHAIN_HAS_SYNC_4 and restyle the with "|| \" form.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/6a2/6a2709956fbb16ac3cbf676acb242c88f83fcdae/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>>   package/glibmm/Config.in | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/glibmm/Config.in b/package/glibmm/Config.in
>> index 2dfc861817..1b27f8cbb1 100644
>> --- a/package/glibmm/Config.in
>> +++ b/package/glibmm/Config.in
>> @@ -4,6 +4,7 @@ config BR2_PACKAGE_GLIBMM
>>   	depends on BR2_INSTALL_LIBSTDCPP
>>   	depends on BR2_USE_WCHAR # libglib2
>>   	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
>> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4
> 
> Not the correct fix: you're confusing the sync built-ins with the atomic
> built-ins. 

Yes, this is new to me.

> Fabrice sent the correct fix a few minutes before yours :-)

Yes, I've seen and replied to him already.
At least I've learnt one new thing :-)

Best regards
-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot