Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Yunhao Tian <t123yh.xyz@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libopenaptx: use official tarball
Date: Sat, 1 Jan 2022 22:55:56 +0100	[thread overview]
Message-ID: <20220101215555.GD69135@scaer> (raw)
In-Reply-To: <20211218232238.667138-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2021-12-19 00:22 +0100, Fabrice Fontaine spake thusly:
> Use official tarball and while at it use 2 spaces and reorder files in
> libopenaptx.hash

As explained in my review,i and despite my previous suggestion for this
change, this would clash with the archive that is now on s.b.o, or with
those people already have localy.

So, I've marked this as rejected.

Regards,
Yann E. MORIN.

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libopenaptx/libopenaptx.hash | 4 ++--
>  package/libopenaptx/libopenaptx.mk   | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/libopenaptx/libopenaptx.hash b/package/libopenaptx/libopenaptx.hash
> index 76b4e66c9b..acaec5d642 100644
> --- a/package/libopenaptx/libopenaptx.hash
> +++ b/package/libopenaptx/libopenaptx.hash
> @@ -1,3 +1,3 @@
>  # Locally calculated:
> -sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 COPYING
> -sha256 a19b3b642def6f86441b73dd4efda6e6f13d49e7e2d6e5e91cc7eb464ebb505a libopenaptx-0.2.1.tar.gz
> +sha256  f13eac1ebfe31a563943cd47819eece1109960e10a1e85c111975bcfd37d5361  libopenaptx-0.2.1.tar.gz
> +sha256  8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903  COPYING
> diff --git a/package/libopenaptx/libopenaptx.mk b/package/libopenaptx/libopenaptx.mk
> index c2f5fa2390..12c33f6225 100644
> --- a/package/libopenaptx/libopenaptx.mk
> +++ b/package/libopenaptx/libopenaptx.mk
> @@ -5,7 +5,7 @@
>  ################################################################################
>  
>  LIBOPENAPTX_VERSION = 0.2.1
> -LIBOPENAPTX_SITE = $(call github,pali,libopenaptx,$(LIBOPENAPTX_VERSION))
> +LIBOPENAPTX_SITE = https://github.com/pali/libopenaptx/releases/download/$(LIBOPENAPTX_VERSION)
>  LIBOPENAPTX_LICENSE = GPL-3.0+
>  LIBOPENAPTX_LICENSE_FILES = COPYING
>  LIBOPENAPTX_INSTALL_STAGING = YES
> -- 
> 2.33.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2022-01-01 21:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-18 23:22 [Buildroot] [PATCH 1/1] package/libopenaptx: use official tarball Fabrice Fontaine
2021-12-19 10:14 ` Yann E. MORIN
2022-01-01 21:55 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220101215555.GD69135@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=t123yh.xyz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox