* Re: [Buildroot] [PATCH 1/1] package/libopenaptx: use official tarball
2021-12-18 23:22 [Buildroot] [PATCH 1/1] package/libopenaptx: use official tarball Fabrice Fontaine
@ 2021-12-19 10:14 ` Yann E. MORIN
2022-01-01 21:55 ` Yann E. MORIN
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-12-19 10:14 UTC (permalink / raw)
To: Fabrice Fontaine, Thomas Petazzoni; +Cc: Yunhao Tian, buildroot
Fabrice, All,
On 2021-12-19 00:22 +0100, Fabrice Fontaine spake thusly:
> Use official tarball and while at it use 2 spaces and reorder files in
> libopenaptx.hash
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/libopenaptx/libopenaptx.hash | 4 ++--
> package/libopenaptx/libopenaptx.mk | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/libopenaptx/libopenaptx.hash b/package/libopenaptx/libopenaptx.hash
> index 76b4e66c9b..acaec5d642 100644
> --- a/package/libopenaptx/libopenaptx.hash
> +++ b/package/libopenaptx/libopenaptx.hash
> @@ -1,3 +1,3 @@
> # Locally calculated:
> -sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 COPYING
> -sha256 a19b3b642def6f86441b73dd4efda6e6f13d49e7e2d6e5e91cc7eb464ebb505a libopenaptx-0.2.1.tar.gz
> +sha256 f13eac1ebfe31a563943cd47819eece1109960e10a1e85c111975bcfd37d5361 libopenaptx-0.2.1.tar.gz
I was not awake enough yesterday evening when I said to send a patch
switching over to the official tarball: this will change the hash, and
trhus will clash with anyone already having downloaded the archive, and
will also obviously clash with s.b.o.
So I took a look at upstream to see if there was any newer version we
could switch to at the same time, and... Oh the horror...
0.2.1 has been released just so that the license was changed from
LGPLv2.1+ to GPLv3.0+, *and* an explicit ban to f.d.o and Collabora from
using that code, and with a long rant about it, even stating that the
license to f.d.o or Collabora was terminated:
https://github.com/pali/libopenaptx/commit/811bc18586d634042618d633727ac0281d4170b8#diff-2b7814d3fca2e99e56c51b6ff2aa313ea6e9da6424804240aa8ad891fdfe0900
Most conerning are some sentences like:
this library and any other project which uses this library must not
be used or distributed in any Freedesktop or Collabora project,
application or library, either in source code, loaded or linked at
compile time or at runtime either directly or transitionally
This is very, very concerning.
An issue was opened about that, and it is pretty dirty:
https://github.com/pali/libopenaptx/issues/13
Besides, the original code is puportedly from ffmpeg, where it was
LGPLv2.1+. Relicensing to GPL-3.0+ seems very dubious at best...
My suggestion is that we should just drop that package.
An option would be to revert to 0.2.0, which is the last version before
the licensing change...
Thoughts?
Regards,
Yann E. MORIN.
> +sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 COPYING
> diff --git a/package/libopenaptx/libopenaptx.mk b/package/libopenaptx/libopenaptx.mk
> index c2f5fa2390..12c33f6225 100644
> --- a/package/libopenaptx/libopenaptx.mk
> +++ b/package/libopenaptx/libopenaptx.mk
> @@ -5,7 +5,7 @@
> ################################################################################
>
> LIBOPENAPTX_VERSION = 0.2.1
> -LIBOPENAPTX_SITE = $(call github,pali,libopenaptx,$(LIBOPENAPTX_VERSION))
> +LIBOPENAPTX_SITE = https://github.com/pali/libopenaptx/releases/download/$(LIBOPENAPTX_VERSION)
> LIBOPENAPTX_LICENSE = GPL-3.0+
> LIBOPENAPTX_LICENSE_FILES = COPYING
> LIBOPENAPTX_INSTALL_STAGING = YES
> --
> 2.33.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/libopenaptx: use official tarball
2021-12-18 23:22 [Buildroot] [PATCH 1/1] package/libopenaptx: use official tarball Fabrice Fontaine
2021-12-19 10:14 ` Yann E. MORIN
@ 2022-01-01 21:55 ` Yann E. MORIN
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2022-01-01 21:55 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Yunhao Tian, buildroot
Fabrice, All,
On 2021-12-19 00:22 +0100, Fabrice Fontaine spake thusly:
> Use official tarball and while at it use 2 spaces and reorder files in
> libopenaptx.hash
As explained in my review,i and despite my previous suggestion for this
change, this would clash with the archive that is now on s.b.o, or with
those people already have localy.
So, I've marked this as rejected.
Regards,
Yann E. MORIN.
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/libopenaptx/libopenaptx.hash | 4 ++--
> package/libopenaptx/libopenaptx.mk | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/libopenaptx/libopenaptx.hash b/package/libopenaptx/libopenaptx.hash
> index 76b4e66c9b..acaec5d642 100644
> --- a/package/libopenaptx/libopenaptx.hash
> +++ b/package/libopenaptx/libopenaptx.hash
> @@ -1,3 +1,3 @@
> # Locally calculated:
> -sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 COPYING
> -sha256 a19b3b642def6f86441b73dd4efda6e6f13d49e7e2d6e5e91cc7eb464ebb505a libopenaptx-0.2.1.tar.gz
> +sha256 f13eac1ebfe31a563943cd47819eece1109960e10a1e85c111975bcfd37d5361 libopenaptx-0.2.1.tar.gz
> +sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 COPYING
> diff --git a/package/libopenaptx/libopenaptx.mk b/package/libopenaptx/libopenaptx.mk
> index c2f5fa2390..12c33f6225 100644
> --- a/package/libopenaptx/libopenaptx.mk
> +++ b/package/libopenaptx/libopenaptx.mk
> @@ -5,7 +5,7 @@
> ################################################################################
>
> LIBOPENAPTX_VERSION = 0.2.1
> -LIBOPENAPTX_SITE = $(call github,pali,libopenaptx,$(LIBOPENAPTX_VERSION))
> +LIBOPENAPTX_SITE = https://github.com/pali/libopenaptx/releases/download/$(LIBOPENAPTX_VERSION)
> LIBOPENAPTX_LICENSE = GPL-3.0+
> LIBOPENAPTX_LICENSE_FILES = COPYING
> LIBOPENAPTX_INSTALL_STAGING = YES
> --
> 2.33.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread