From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Romain Naour <romain.naour@gmail.com>
Cc: Pierre-Jean Texier <texier.pj2@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] board/qemu/aarch64-sbsa: use partition-type-uuid for genimage-15
Date: Mon, 3 Jan 2022 21:43:44 +0100 [thread overview]
Message-ID: <20220103204344.GJ69135@scaer> (raw)
In-Reply-To: <20220102165431.3551867-1-romain.naour@gmail.com>
Romain, All,
On 2022-01-02 17:54 +0100, Romain Naour spake thusly:
> Genimage 15 restricted the partition-type option to mbr and hybrid
> partition-table-type and now prints a warning when it is used [1]:
>
> ERROR: hdimage(disk.img): part boot: 'partition-type' is only valid for mbr and hybrid partition-table-type
>
> [1] https://github.com/pengutronix/genimage/commit/1d72d8091f83790a0a35a1ea7dc25d46adba8876
>
> Sync the genimage.cfg with the one used for aarch64_efi_defconfig
>
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/1929717179
> https://gitlab.com/buildroot.org/buildroot/-/jobs/1921792262
I've added a link to the Wikipedia page that lists the UUIDs:
https://en.wikipedia.org/wiki/GUID_Partition_Table#Partition_type_GUIDs
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Dick Olsson <hi@senzilla.io>
> Cc: Pierre-Jean Texier <texier.pj2@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> board/qemu/aarch64-sbsa/genimage.cfg | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/board/qemu/aarch64-sbsa/genimage.cfg b/board/qemu/aarch64-sbsa/genimage.cfg
> index 121ae9f37b..bdf8a89d75 100644
> --- a/board/qemu/aarch64-sbsa/genimage.cfg
> +++ b/board/qemu/aarch64-sbsa/genimage.cfg
> @@ -18,12 +18,14 @@ image disk.img {
> }
>
> partition boot {
> - partition-type = 0xEF
> image = "efi-part.vfat"
> + partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
> + offset = 32K
> + bootable = true
> }
>
> partition root {
> - partition-type = 0x83
> + partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
> image = "rootfs.ext2"
> }
> }
> --
> 2.31.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-01-03 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-02 16:54 [Buildroot] [PATCH] board/qemu/aarch64-sbsa: use partition-type-uuid for genimage-15 Romain Naour
2022-01-03 20:43 ` Yann E. MORIN [this message]
2022-01-03 20:45 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220103204344.GJ69135@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
--cc=texier.pj2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox