* [Buildroot] [PATCH] board/qemu/aarch64-sbsa: use partition-type-uuid for genimage-15
@ 2022-01-02 16:54 Romain Naour
2022-01-03 20:43 ` Yann E. MORIN
0 siblings, 1 reply; 3+ messages in thread
From: Romain Naour @ 2022-01-02 16:54 UTC (permalink / raw)
To: buildroot; +Cc: Pierre-Jean Texier, Romain Naour
Genimage 15 restricted the partition-type option to mbr and hybrid
partition-table-type and now prints a warning when it is used [1]:
ERROR: hdimage(disk.img): part boot: 'partition-type' is only valid for mbr and hybrid partition-table-type
[1] https://github.com/pengutronix/genimage/commit/1d72d8091f83790a0a35a1ea7dc25d46adba8876
Sync the genimage.cfg with the one used for aarch64_efi_defconfig
Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1929717179
https://gitlab.com/buildroot.org/buildroot/-/jobs/1921792262
Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Dick Olsson <hi@senzilla.io>
Cc: Pierre-Jean Texier <texier.pj2@gmail.com>
---
board/qemu/aarch64-sbsa/genimage.cfg | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/board/qemu/aarch64-sbsa/genimage.cfg b/board/qemu/aarch64-sbsa/genimage.cfg
index 121ae9f37b..bdf8a89d75 100644
--- a/board/qemu/aarch64-sbsa/genimage.cfg
+++ b/board/qemu/aarch64-sbsa/genimage.cfg
@@ -18,12 +18,14 @@ image disk.img {
}
partition boot {
- partition-type = 0xEF
image = "efi-part.vfat"
+ partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+ offset = 32K
+ bootable = true
}
partition root {
- partition-type = 0x83
+ partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
image = "rootfs.ext2"
}
}
--
2.31.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Buildroot] [PATCH] board/qemu/aarch64-sbsa: use partition-type-uuid for genimage-15
2022-01-02 16:54 [Buildroot] [PATCH] board/qemu/aarch64-sbsa: use partition-type-uuid for genimage-15 Romain Naour
@ 2022-01-03 20:43 ` Yann E. MORIN
2022-01-03 20:45 ` Romain Naour
0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2022-01-03 20:43 UTC (permalink / raw)
To: Romain Naour; +Cc: Pierre-Jean Texier, buildroot
Romain, All,
On 2022-01-02 17:54 +0100, Romain Naour spake thusly:
> Genimage 15 restricted the partition-type option to mbr and hybrid
> partition-table-type and now prints a warning when it is used [1]:
>
> ERROR: hdimage(disk.img): part boot: 'partition-type' is only valid for mbr and hybrid partition-table-type
>
> [1] https://github.com/pengutronix/genimage/commit/1d72d8091f83790a0a35a1ea7dc25d46adba8876
>
> Sync the genimage.cfg with the one used for aarch64_efi_defconfig
>
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/1929717179
> https://gitlab.com/buildroot.org/buildroot/-/jobs/1921792262
I've added a link to the Wikipedia page that lists the UUIDs:
https://en.wikipedia.org/wiki/GUID_Partition_Table#Partition_type_GUIDs
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Dick Olsson <hi@senzilla.io>
> Cc: Pierre-Jean Texier <texier.pj2@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> board/qemu/aarch64-sbsa/genimage.cfg | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/board/qemu/aarch64-sbsa/genimage.cfg b/board/qemu/aarch64-sbsa/genimage.cfg
> index 121ae9f37b..bdf8a89d75 100644
> --- a/board/qemu/aarch64-sbsa/genimage.cfg
> +++ b/board/qemu/aarch64-sbsa/genimage.cfg
> @@ -18,12 +18,14 @@ image disk.img {
> }
>
> partition boot {
> - partition-type = 0xEF
> image = "efi-part.vfat"
> + partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
> + offset = 32K
> + bootable = true
> }
>
> partition root {
> - partition-type = 0x83
> + partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
> image = "rootfs.ext2"
> }
> }
> --
> 2.31.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Buildroot] [PATCH] board/qemu/aarch64-sbsa: use partition-type-uuid for genimage-15
2022-01-03 20:43 ` Yann E. MORIN
@ 2022-01-03 20:45 ` Romain Naour
0 siblings, 0 replies; 3+ messages in thread
From: Romain Naour @ 2022-01-03 20:45 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Pierre-Jean Texier, buildroot
Hello Yann,
Le 03/01/2022 à 21:43, Yann E. MORIN a écrit :
> Romain, All,
>
> On 2022-01-02 17:54 +0100, Romain Naour spake thusly:
>> Genimage 15 restricted the partition-type option to mbr and hybrid
>> partition-table-type and now prints a warning when it is used [1]:
>>
>> ERROR: hdimage(disk.img): part boot: 'partition-type' is only valid for mbr and hybrid partition-table-type
>>
>> [1] https://github.com/pengutronix/genimage/commit/1d72d8091f83790a0a35a1ea7dc25d46adba8876
>>
>> Sync the genimage.cfg with the one used for aarch64_efi_defconfig
>>
>> Fixes:
>> https://gitlab.com/buildroot.org/buildroot/-/jobs/1929717179
>> https://gitlab.com/buildroot.org/buildroot/-/jobs/1921792262
>
> I've added a link to the Wikipedia page that lists the UUIDs:
> https://en.wikipedia.org/wiki/GUID_Partition_Table#Partition_type_GUIDs
Thanks, useful link!
Best regards,
Romain
>
>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>> Cc: Dick Olsson <hi@senzilla.io>
>> Cc: Pierre-Jean Texier <texier.pj2@gmail.com>
>
> Applied to master, thanks.
>
> Regards,
> Yann E. MORIN.
>
>> ---
>> board/qemu/aarch64-sbsa/genimage.cfg | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/board/qemu/aarch64-sbsa/genimage.cfg b/board/qemu/aarch64-sbsa/genimage.cfg
>> index 121ae9f37b..bdf8a89d75 100644
>> --- a/board/qemu/aarch64-sbsa/genimage.cfg
>> +++ b/board/qemu/aarch64-sbsa/genimage.cfg
>> @@ -18,12 +18,14 @@ image disk.img {
>> }
>>
>> partition boot {
>> - partition-type = 0xEF
>> image = "efi-part.vfat"
>> + partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
>> + offset = 32K
>> + bootable = true
>> }
>>
>> partition root {
>> - partition-type = 0x83
>> + partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
>> image = "rootfs.ext2"
>> }
>> }
>> --
>> 2.31.1
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-03 20:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-02 16:54 [Buildroot] [PATCH] board/qemu/aarch64-sbsa: use partition-type-uuid for genimage-15 Romain Naour
2022-01-03 20:43 ` Yann E. MORIN
2022-01-03 20:45 ` Romain Naour
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox