Re: [Buildroot] [PATCH-NEXT v3 4/6] support/download/go-post-process: implement Go vendoring support

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello Christian,

On Sun, 10 Oct 2021 16:46:53 -0700
Christian Stewart via buildroot <buildroot@buildroot.org> wrote:

> From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> 
> This commit introduces the download post-process script
> support/download/go-post-process, and hooks it into the Go package
> infrastructure.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Signed-off-by: Christian Stewart <christian@paral.in>
> 
> v1 -> v2:
> 
>  - re-submitting Thomas's series with adjustments:
>  - run "go mod init" just before "go mod vendor"
>  - this fixes the case when go.mod does not exist
>  - use -modcacherw to fix "make clean" permissions errors
>  - use the mk_tar_gz helper in the post-process step
> 
> Signed-off-by: Christian Stewart <christian@paral.in>

I am a bit confused by the changes you introduced here. You're
labelling this patch series v3, so I assume it comes after my v2:

  https://patchwork.ozlabs.org/project/buildroot/patch/20201219153525.1361175-6-thomas.petazzoni@bootlin.com/

I'm particularly confused by the addition of the -g option to pass the
argument of "go mod init" as opposed to using the BR_GOMOD environment
variable.

In the patch I linked above, you reported that it was causing some hash
issues, but I don't understand which of your changes fixed that
problem. Could you clarify?

Also, my patch dropped the creation of go.mod from
package/pkg-golang.mk (macro $(2)_GEN_GOMOD), but I'm not sure why your
patch doesn't drop that.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot