Re: [Buildroot] [PATCH-NEXT v3 4/6] support/download/go-post-process: implement Go vendoring support

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello,

On Sun, 10 Oct 2021 16:46:53 -0700
Christian Stewart via buildroot <buildroot@buildroot.org> wrote:

> +# Do the Go vendoring
> +pushd ${base_name} > /dev/null
> +# modcacherw option leaves directories in the module cache at their default
> +# permissions rather than making them read-only.
> +if [ ! -f go.mod ] && [ -n "${gomod_init}" ]; then
> +    go mod init -modcacherw ${gomod_init}

So here you're using "go mod init" to create the go.mod file, but in
package/pkg-golang.mk, we're manually creating it.

So for the sake of consistency, I tried using "go mod init" in
package/pkg-golang.mk as well, but running that on balena-engine caused
go mod init to start downloading stuff... which is wrong because
balena-engine already comes with its vendored dependencies.

So in the end, I ended up creating the go.mod manually (with the same
logic) in both pkg-golang.mk and in this download post-process script.
But if we find why "go mod init" didn't work in the context of
pkg-golang.mk, we could switch back to using that.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot