From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Romain Naour <romain.naour@smile.fr>
Cc: Romain Naour <romain.naour@gmail.com>,
David Pierret <david.pierret@smile.fr>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCHv4] package/bat: new package
Date: Fri, 7 Jan 2022 11:05:22 +0100 [thread overview]
Message-ID: <20220107110522.523586ae@windsurf> (raw)
In-Reply-To: <20220107090348.3947187-1-romain.naour@smile.fr>
Hello,
On Fri, 7 Jan 2022 10:03:48 +0100
Romain Naour <romain.naour@smile.fr> wrote:
> diff --git a/package/pkg-cargo.mk b/package/pkg-cargo.mk
> index bf1436a86b..e2fe104cf3 100644
> --- a/package/pkg-cargo.mk
> +++ b/package/pkg-cargo.mk
> @@ -110,6 +110,7 @@ ifndef $(2)_INSTALL_TARGET_CMDS
> define $(2)_INSTALL_TARGET_CMDS
> cd $$(@D) && \
> $$(TARGET_MAKE_ENV) $$($(2)_CARGO_ENV) \
> + CC_$$(subst -,_,$$(RUSTC_TARGET_NAME))=$$(TARGET_CC) \
But we don't even pass this variable at build time.. why would it be
needed at install time? Due to the fact that "bar" builds stuff during
the install step, I understand that we might need extra variable during
the installation step, but I would expect to only need variables that
are already passed during the build step.
Any idea?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-01-07 10:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 9:03 [Buildroot] [PATCHv4] package/bat: new package Romain Naour
2022-01-07 10:05 ` Thomas Petazzoni [this message]
2022-01-07 10:08 ` Romain Naour
2022-01-07 10:17 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220107110522.523586ae@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=david.pierret@smile.fr \
--cc=romain.naour@gmail.com \
--cc=romain.naour@smile.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox