Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Romain Naour <romain.naour@smile.fr>
Cc: Romain Naour <romain.naour@gmail.com>,
	David Pierret <david.pierret@smile.fr>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCHv4] package/bat: new package
Date: Fri, 7 Jan 2022 11:17:27 +0100	[thread overview]
Message-ID: <20220107111727.1d021ffd@windsurf> (raw)
In-Reply-To: <0ebbe6b2-2932-862f-52a1-a34ab7d0f11e@smile.fr>

Hello,

On Fri, 7 Jan 2022 11:08:21 +0100
Romain Naour <romain.naour@smile.fr> wrote:

> > But we don't even pass this variable at build time.. why would it be
> > needed at install time? Due to the fact that "bar" builds stuff during
> > the install step, I understand that we might need extra variable during
> > the installation step, but I would expect to only need variables that
> > are already passed during the build step.  
> 
> It seems we just need to add $$(TARGET_CONFIGURE_OPTS) to _INSTALL_TARGET_CMDS
> 
> http://lists.busybox.net/pipermail/buildroot/2022-January/632613.html

Ah, OK. This indeed we are passing at build time, but not at install
time currently. We can certainly add that at install time too. Though
this "build during install step" thing is a bit annoying...

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-01-07 10:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07  9:03 [Buildroot] [PATCHv4] package/bat: new package Romain Naour
2022-01-07 10:05 ` Thomas Petazzoni
2022-01-07 10:08   ` Romain Naour
2022-01-07 10:17     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220107111727.1d021ffd@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=david.pierret@smile.fr \
    --cc=romain.naour@gmail.com \
    --cc=romain.naour@smile.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox