Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>
Cc: Eloi Bail <eloi.bail@savoirfairelinux.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/gstreamer1/gst1-plugins-bayer2rgb-neon: show comment on aarch64
Date: Fri, 7 Jan 2022 19:02:59 +0100	[thread overview]
Message-ID: <20220107190259.5365b6ea@windsurf> (raw)
In-Reply-To: <20220107140546.1921-2-sebastien.szymanski@armadeus.com>

Hello Sébastien,

On Fri,  7 Jan 2022 15:05:46 +0100
Sébastien Szymanski <sebastien.szymanski@armadeus.com> wrote:

> On aarch64, the Config.in comment for gst1-plugins-bayer2rgb-neon is not
> shown when a dependency is missing. Fix that.
> 
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
>  package/gstreamer1/gst1-plugins-bayer2rgb-neon/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This wasn't entirely correct, indeed the same problem exists in
bayer2rgb-neon, which this package depends on. So to avoid this
mistake, I've instead added a BR2_PACKAGE_BAYER2RGB_NEON_ARCH_SUPPORTS
blind option, and used it in both packages.

Don't hesitate to double check that what I have committed is correct,
of course!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-01-07 18:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07 14:05 [Buildroot] [PATCH 1/2] package/gstreamer1/gst1-plugins-bayer2rgb-neon: use "config" Sébastien Szymanski
2022-01-07 14:05 ` [Buildroot] [PATCH 2/2] package/gstreamer1/gst1-plugins-bayer2rgb-neon: show comment on aarch64 Sébastien Szymanski
2022-01-07 18:02   ` Thomas Petazzoni [this message]
2022-01-07 18:01 ` [Buildroot] [PATCH 1/2] package/gstreamer1/gst1-plugins-bayer2rgb-neon: use "config" Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220107190259.5365b6ea@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=eloi.bail@savoirfairelinux.com \
    --cc=sebastien.szymanski@armadeus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox