[Buildroot] [PATCH 1/2] package/gstreamer1/gst1-plugins-bayer2rgb-neon: use "config"

[Buildroot] [PATCH 1/2] package/gstreamer1/gst1-plugins-bayer2rgb-neon: use "config"

[Sébastien Szymanski]

gst1-plugins-bayer2rgb-neon doesn't have sub-options so use "config"
instead of "menuconfig".

Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
---
 package/gstreamer1/gst1-plugins-bayer2rgb-neon/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/gstreamer1/gst1-plugins-bayer2rgb-neon/Config.in b/package/gstreamer1/gst1-plugins-bayer2rgb-neon/Config.in
index 570300a304..d3e4d0e243 100644
--- a/package/gstreamer1/gst1-plugins-bayer2rgb-neon/Config.in
+++ b/package/gstreamer1/gst1-plugins-bayer2rgb-neon/Config.in
@@ -1,4 +1,4 @@
-menuconfig BR2_PACKAGE_GST1_PLUGINS_BAYER2RGB_NEON
+config BR2_PACKAGE_GST1_PLUGINS_BAYER2RGB_NEON
 	bool "gst1-plugins-bayer2rgb-neon"
 	depends on (BR2_arm && BR2_ARM_CPU_HAS_NEON) || BR2_aarch64 # bayer2rgb-neon
 	depends on !BR2_STATIC_LIBS # bayer2rgb-neon
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] package/gstreamer1/gst1-plugins-bayer2rgb-neon: show comment on aarch64

[Sébastien Szymanski]

On aarch64, the Config.in comment for gst1-plugins-bayer2rgb-neon is not
shown when a dependency is missing. Fix that.

Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
---
 package/gstreamer1/gst1-plugins-bayer2rgb-neon/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/gstreamer1/gst1-plugins-bayer2rgb-neon/Config.in b/package/gstreamer1/gst1-plugins-bayer2rgb-neon/Config.in
index d3e4d0e243..68d7a2bc56 100644
--- a/package/gstreamer1/gst1-plugins-bayer2rgb-neon/Config.in
+++ b/package/gstreamer1/gst1-plugins-bayer2rgb-neon/Config.in
@@ -15,6 +15,6 @@ config BR2_PACKAGE_GST1_PLUGINS_BAYER2RGB_NEON
 	  https://gitlab-ext.sigma-chemnitz.de/ensc/gst-bayer2rgb-neon
 
 comment "gst1-plugins-bayer2rgb-neon needs a toolchain w/ C++, dynamic library, gcc >= 4.9"
-	depends on BR2_arm && BR2_ARM_CPU_HAS_NEON
+	depends on (BR2_arm && BR2_ARM_CPU_HAS_NEON) || BR2_aarch64
 	depends on BR2_STATIC_LIBS || !BR2_INSTALL_LIBSTDCPP || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/gstreamer1/gst1-plugins-bayer2rgb-neon: use "config"

[Thomas Petazzoni]

On Fri,  7 Jan 2022 15:05:45 +0100
Sébastien Szymanski <sebastien.szymanski@armadeus.com> wrote:

> gst1-plugins-bayer2rgb-neon doesn't have sub-options so use "config"
> instead of "menuconfig".
> 
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
>  package/gstreamer1/gst1-plugins-bayer2rgb-neon/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/gstreamer1/gst1-plugins-bayer2rgb-neon: show comment on aarch64

[Thomas Petazzoni]

Hello Sébastien,

On Fri,  7 Jan 2022 15:05:46 +0100
Sébastien Szymanski <sebastien.szymanski@armadeus.com> wrote:

> On aarch64, the Config.in comment for gst1-plugins-bayer2rgb-neon is not
> shown when a dependency is missing. Fix that.
> 
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
>  package/gstreamer1/gst1-plugins-bayer2rgb-neon/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This wasn't entirely correct, indeed the same problem exists in
bayer2rgb-neon, which this package depends on. So to avoid this
mistake, I've instead added a BR2_PACKAGE_BAYER2RGB_NEON_ARCH_SUPPORTS
blind option, and used it in both packages.

Don't hesitate to double check that what I have committed is correct,
of course!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot