* [Buildroot] [PATCH 1/2] qemu_arm_versatile: switch to in-kernel defconfig + fragment
@ 2021-03-16 14:38 Masahiro Yamada
2021-03-16 14:38 ` [Buildroot] [PATCH 2/2] qemu_arm_versatile_nommu: " Masahiro Yamada
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Masahiro Yamada @ 2021-03-16 14:38 UTC (permalink / raw)
To: buildroot
This platform has its own kernel defconfig in Buildroot, but we cannot
get quick idea about how much it diverged from the in-kernel defconfig.
Let's use the upstream arch/arm/config/versatile_defconfig as a base,
and maintain the diff as a merge-config fragment. The same .config is
still generated based on the 5.10.7 kernel.
The diff is quite big, but this is a good start-point for cleanups.
Follow-up works can drop diff lines unless we find a good reason for
divergence.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
board/qemu/arm-versatile/linux.config | 43 ------------
.../qemu/arm-versatile/linux.config.fragment | 66 +++++++++++++++++++
configs/qemu_arm_versatile_defconfig | 4 +-
3 files changed, 68 insertions(+), 45 deletions(-)
delete mode 100644 board/qemu/arm-versatile/linux.config
create mode 100644 board/qemu/arm-versatile/linux.config.fragment
diff --git a/board/qemu/arm-versatile/linux.config b/board/qemu/arm-versatile/linux.config
deleted file mode 100644
index b1001d84a7..0000000000
--- a/board/qemu/arm-versatile/linux.config
+++ /dev/null
@@ -1,43 +0,0 @@
-CONFIG_SYSVIPC=y
-CONFIG_MODULES=y
-CONFIG_MODULE_UNLOAD=y
-# CONFIG_ARCH_MULTI_V7 is not set
-CONFIG_ARCH_VERSATILE=y
-CONFIG_PCI=y
-CONFIG_PCI_VERSATILE=y
-CONFIG_AEABI=y
-CONFIG_NET=y
-CONFIG_PACKET=y
-CONFIG_UNIX=y
-CONFIG_INET=y
-CONFIG_SCSI=y
-CONFIG_BLK_DEV_SD=y
-CONFIG_SCSI_SYM53C8XX_2=y
-CONFIG_NETDEVICES=y
-CONFIG_8139CP=y
-CONFIG_PHYLIB=y
-CONFIG_INPUT_EVDEV=y
-CONFIG_SERIO_AMBAKMI=y
-CONFIG_LEGACY_PTY_COUNT=16
-CONFIG_SERIAL_8250=m
-CONFIG_SERIAL_8250_EXTENDED=y
-CONFIG_SERIAL_8250_MANY_PORTS=y
-CONFIG_SERIAL_8250_SHARE_IRQ=y
-CONFIG_SERIAL_8250_RSA=y
-CONFIG_SERIAL_AMBA_PL011=y
-CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
-CONFIG_I2C=y
-CONFIG_I2C_CHARDEV=m
-CONFIG_FB=y
-CONFIG_FB_ARMCLCD=y
-CONFIG_FRAMEBUFFER_CONSOLE=y
-CONFIG_SOUND=y
-CONFIG_SND=m
-CONFIG_SND_MIXER_OSS=m
-CONFIG_SND_PCM_OSS=m
-CONFIG_SND_ARMAACI=m
-CONFIG_EXT4_FS=y
-CONFIG_VFAT_FS=m
-CONFIG_TMPFS=y
-CONFIG_TMPFS_POSIX_ACL=y
-CONFIG_MAGIC_SYSRQ=y
diff --git a/board/qemu/arm-versatile/linux.config.fragment b/board/qemu/arm-versatile/linux.config.fragment
new file mode 100644
index 0000000000..0aed558315
--- /dev/null
+++ b/board/qemu/arm-versatile/linux.config.fragment
@@ -0,0 +1,66 @@
+# CONFIG_BLK_DEV_INITRD is not set
+# CONFIG_BLK_DEV_RAM is not set
+# CONFIG_CMA is not set
+# CONFIG_CRAMFS is not set
+CONFIG_CMDLINE=""
+CONFIG_CRC16=y
+CONFIG_CRYPTO=y
+# CONFIG_DEBUG_FS is not set
+# CONFIG_DEBUG_KERNEL is not set
+# CONFIG_DEBUG_USER is not set
+CONFIG_DEVTMPFS=y
+# CONFIG_DRM is not set
+# CONFIG_EEPROM_LEGACY is not set
+# CONFIG_EXT2_FS is not set
+CONFIG_EXT4_FS=y
+CONFIG_FB_ARMCLCD=y
+# CONFIG_FONTS is not set
+CONFIG_FONT_8x16=y
+CONFIG_FONT_8x8=y
+# CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY is not set
+# CONFIG_FTRACE is not set
+# CONFIG_GPIOLIB is not set
+# CONFIG_HIGH_RES_TIMERS is not set
+CONFIG_HWMON=y
+CONFIG_HZ_PERIODIC=y
+# CONFIG_I2C_VERSATILE is not set
+CONFIG_INET_DIAG=y
+CONFIG_INPUT_EVDEV=y
+CONFIG_IPV6=y
+# CONFIG_IP_MULTICAST is not set
+# CONFIG_IP_PNP is not set
+CONFIG_LOCALVERSION_AUTO=y
+# CONFIG_LOGO is not set
+CONFIG_LOG_BUF_SHIFT=17
+CONFIG_MDIO_DEVICE=y
+# CONFIG_MINIX_FS is not set
+# CONFIG_MMC is not set
+# CONFIG_MTD is not set
+# CONFIG_NEW_LEDS is not set
+# CONFIG_NFSD is not set
+# CONFIG_NFS_FS is not set
+# CONFIG_NLS_CODEPAGE_850 is not set
+# CONFIG_NLS_ISO8859_1 is not set
+# CONFIG_NO_HZ_IDLE is not set
+# CONFIG_NVMEM is not set
+# CONFIG_OABI_COMPAT is not set
+# CONFIG_PARTITION_ADVANCED is not set
+CONFIG_PCI=y
+CONFIG_PCI_VERSATILE=y
+CONFIG_PHYLIB=y
+# CONFIG_ROMFS_FS is not set
+# CONFIG_RTC_CLASS is not set
+CONFIG_SCSI=y
+CONFIG_SCSI_SPI_ATTRS=y
+CONFIG_SCSI_SYM53C8XX_2=y
+CONFIG_SERIO_SERPORT=y
+CONFIG_SLUB=y
+# CONFIG_SPI is not set
+# CONFIG_SYNC_FILE is not set
+CONFIG_TMPFS=y
+CONFIG_TMPFS_POSIX_ACL=y
+CONFIG_TMPFS_XATTR=y
+# CONFIG_VFP is not set
+# CONFIG_XZ_DEC is not set
+CONFIG_8139CP=y
+CONFIG_BLK_DEV_SD=y
diff --git a/configs/qemu_arm_versatile_defconfig b/configs/qemu_arm_versatile_defconfig
index 10dd9e52b4..f4950ca2d8 100644
--- a/configs/qemu_arm_versatile_defconfig
+++ b/configs/qemu_arm_versatile_defconfig
@@ -21,8 +21,8 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_10=y
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_VERSION=y
BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.10.7"
-BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
-BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/arm-versatile/linux.config"
+BR2_LINUX_KERNEL_DEFCONFIG="versatile"
+BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/qemu/arm-versatile/linux.config.fragment"
BR2_LINUX_KERNEL_DTS_SUPPORT=y
BR2_LINUX_KERNEL_INTREE_DTS_NAME="versatile-pb"
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] qemu_arm_versatile_nommu: switch to in-kernel defconfig + fragment
2021-03-16 14:38 [Buildroot] [PATCH 1/2] qemu_arm_versatile: switch to in-kernel defconfig + fragment Masahiro Yamada
@ 2021-03-16 14:38 ` Masahiro Yamada
2021-03-16 14:55 ` [Buildroot] [PATCH 1/2] qemu_arm_versatile: " Masahiro Yamada
2022-01-08 14:09 ` Romain Naour
2 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2021-03-16 14:38 UTC (permalink / raw)
To: buildroot
This platform has its own kernel defconfig in Buildroot, but we cannot
get quick idea about how much it diverged from the in-kernel defconfig.
Let's use the upstream arch/arm/config/versatile_defconfig as a base,
and maintain the diff as a merge-config fragment. The same .config is
still generated based on the 5.10.7 kernel.
The diff is quite big, but this is a good start-point for cleanups.
Follow-up works can drop diff lines unless we find a good reason for
divergence.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
board/qemu/arm-versatile/linux-nommu.config | 47 ---------------
.../arm-versatile/linux-nommu.config.fragment | 59 +++++++++++++++++++
configs/qemu_arm_versatile_nommu_defconfig | 4 +-
3 files changed, 61 insertions(+), 49 deletions(-)
delete mode 100644 board/qemu/arm-versatile/linux-nommu.config
create mode 100644 board/qemu/arm-versatile/linux-nommu.config.fragment
diff --git a/board/qemu/arm-versatile/linux-nommu.config b/board/qemu/arm-versatile/linux-nommu.config
deleted file mode 100644
index 1d91d51a14..0000000000
--- a/board/qemu/arm-versatile/linux-nommu.config
+++ /dev/null
@@ -1,47 +0,0 @@
-# CONFIG_MMU is not set
-CONFIG_ARCH_VERSATILE=y
-CONFIG_ARM_SINGLE_ARCH_VERSATILE=y
-CONFIG_SET_MEM_PARAM=y
-CONFIG_DRAM_BASE=0x00000000
-CONFIG_DRAM_SIZE=0x08000000
-CONFIG_ARCH_VERSATILE_PB=y
-CONFIG_MACH_VERSATILE_AB=y
-CONFIG_MACH_VERSATILE_DT=y
-CONFIG_BINFMT_FLAT=y
-CONFIG_SYSVIPC=y
-CONFIG_MODULES=y
-CONFIG_MODULE_UNLOAD=y
-# CONFIG_ARCH_MULTI_V7 is not set
-CONFIG_AEABI=y
-CONFIG_NET=y
-CONFIG_PACKET=y
-CONFIG_UNIX=y
-CONFIG_INET=y
-CONFIG_NETDEVICES=y
-CONFIG_SMC91X=y
-CONFIG_PHYLIB=y
-CONFIG_INPUT_EVDEV=y
-CONFIG_SERIO_AMBAKMI=y
-CONFIG_LEGACY_PTY_COUNT=16
-CONFIG_SERIAL_8250=m
-CONFIG_SERIAL_8250_EXTENDED=y
-CONFIG_SERIAL_8250_MANY_PORTS=y
-CONFIG_SERIAL_8250_SHARE_IRQ=y
-CONFIG_SERIAL_8250_RSA=y
-CONFIG_SERIAL_AMBA_PL011=y
-CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
-CONFIG_I2C=y
-CONFIG_I2C_CHARDEV=m
-CONFIG_FB=y
-CONFIG_FB_ARMCLCD=y
-CONFIG_FRAMEBUFFER_CONSOLE=y
-CONFIG_SOUND=y
-CONFIG_SND=m
-CONFIG_SND_MIXER_OSS=m
-CONFIG_SND_PCM_OSS=m
-CONFIG_SND_ARMAACI=m
-CONFIG_EXT4_FS=y
-CONFIG_VFAT_FS=m
-CONFIG_TMPFS=y
-CONFIG_TMPFS_POSIX_ACL=y
-CONFIG_MAGIC_SYSRQ=y
diff --git a/board/qemu/arm-versatile/linux-nommu.config.fragment b/board/qemu/arm-versatile/linux-nommu.config.fragment
new file mode 100644
index 0000000000..6f1cc3f26d
--- /dev/null
+++ b/board/qemu/arm-versatile/linux-nommu.config.fragment
@@ -0,0 +1,59 @@
+# CONFIG_ARM_SINGLE_ARMV7M is not set
+CONFIG_ARM_SINGLE_ARCH_VERSATILE=y
+CONFIG_BINFMT_ELF_FDPIC=y
+CONFIG_BINFMT_FLAT=y
+# CONFIG_BLK_DEV_RAM is not set
+# CONFIG_CRAMFS is not set
+CONFIG_CMDLINE=""
+# CONFIG_DEBUG_FS is not set
+# CONFIG_DEBUG_KERNEL is not set
+# CONFIG_DEBUG_USER is not set
+# CONFIG_DRM is not set
+# CONFIG_EEPROM_LEGACY is not set
+# CONFIG_EXT2_FS is not set
+CONFIG_EXT4_FS=y
+CONFIG_FB_ARMCLCD=y
+# CONFIG_FONTS is not set
+CONFIG_FONT_8x16=y
+CONFIG_FONT_8x8=y
+# CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY is not set
+# CONFIG_FTRACE is not set
+# CONFIG_GPIO_PL061 is not set
+# CONFIG_HIGH_RES_TIMERS is not set
+CONFIG_HWMON=y
+# CONFIG_I2C_VERSATILE is not set
+CONFIG_INET_DIAG=y
+CONFIG_INPUT_EVDEV=y
+CONFIG_IPV6=y
+# CONFIG_IP_MULTICAST is not set
+# CONFIG_IP_PNP is not set
+# CONFIG_MMU is not set
+CONFIG_LOCALVERSION_AUTO=y
+# CONFIG_LOGO is not set
+CONFIG_LOG_BUF_SHIFT=17
+CONFIG_MDIO_DEVICE=y
+# CONFIG_MINIX_FS is not set
+# CONFIG_MMC is not set
+# CONFIG_MTD is not set
+# CONFIG_NEW_LEDS is not set
+# CONFIG_NFSD is not set
+# CONFIG_NFS_FS is not set
+# CONFIG_NLS_CODEPAGE_850 is not set
+# CONFIG_NLS_ISO8859_1 is not set
+# CONFIG_NO_HZ_IDLE is not set
+# CONFIG_NVMEM is not set
+CONFIG_DRAM_BASE=0x00000000
+CONFIG_DRAM_SIZE=0x08000000
+CONFIG_INITRAMFS_SOURCE="${BR_BINARIES_DIR}/rootfs.cpio"
+# CONFIG_PARTITION_ADVANCED is not set
+# CONFIG_OABI_COMPAT is not set
+CONFIG_PHYLIB=y
+# CONFIG_ROMFS_FS is not set
+# CONFIG_RTC_CLASS is not set
+CONFIG_SERIAL_CORE=y
+CONFIG_SERIO_SERPORT=y
+CONFIG_SET_MEM_PARAM=y
+CONFIG_SLUB=y
+# CONFIG_SPI is not set
+# CONFIG_SYNC_FILE is not set
+# CONFIG_VFP is not set
diff --git a/configs/qemu_arm_versatile_nommu_defconfig b/configs/qemu_arm_versatile_nommu_defconfig
index fa783f9299..b60de66dff 100644
--- a/configs/qemu_arm_versatile_nommu_defconfig
+++ b/configs/qemu_arm_versatile_nommu_defconfig
@@ -32,8 +32,8 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_10=y
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_VERSION=y
BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.10.7"
-BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
-BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/arm-versatile/linux-nommu.config"
+BR2_LINUX_KERNEL_DEFCONFIG="versatile"
+BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/qemu/arm-versatile/linux-nommu.config.fragment"
BR2_LINUX_KERNEL_DTS_SUPPORT=y
BR2_LINUX_KERNEL_INTREE_DTS_NAME="versatile-pb"
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] qemu_arm_versatile: switch to in-kernel defconfig + fragment
2021-03-16 14:38 [Buildroot] [PATCH 1/2] qemu_arm_versatile: switch to in-kernel defconfig + fragment Masahiro Yamada
2021-03-16 14:38 ` [Buildroot] [PATCH 2/2] qemu_arm_versatile_nommu: " Masahiro Yamada
@ 2021-03-16 14:55 ` Masahiro Yamada
2022-01-08 14:09 ` Romain Naour
2 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2021-03-16 14:55 UTC (permalink / raw)
To: buildroot
On Tue, Mar 16, 2021 at 11:38 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> This platform has its own kernel defconfig in Buildroot, but we cannot
> get quick idea about how much it diverged from the in-kernel defconfig.
>
> Let's use the upstream arch/arm/config/versatile_defconfig as a base,
> and maintain the diff as a merge-config fragment. The same .config is
> still generated based on the 5.10.7 kernel.
>
> The diff is quite big, but this is a good start-point for cleanups.
> Follow-up works can drop diff lines unless we find a good reason for
> divergence.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
We do not have a consistent naming rule for
defconfig files and config fragments.
Maybe we can give _defconfig suffix to BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE,
and .config to BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES.
This goes along with the naming rule in the upstream kernel.
>
> board/qemu/arm-versatile/linux.config | 43 ------------
> .../qemu/arm-versatile/linux.config.fragment | 66 +++++++++++++++++++
> configs/qemu_arm_versatile_defconfig | 4 +-
> 3 files changed, 68 insertions(+), 45 deletions(-)
> delete mode 100644 board/qemu/arm-versatile/linux.config
> create mode 100644 board/qemu/arm-versatile/linux.config.fragment
>
> diff --git a/board/qemu/arm-versatile/linux.config b/board/qemu/arm-versatile/linux.config
> deleted file mode 100644
> index b1001d84a7..0000000000
> --- a/board/qemu/arm-versatile/linux.config
> +++ /dev/null
> @@ -1,43 +0,0 @@
> -CONFIG_SYSVIPC=y
> -CONFIG_MODULES=y
> -CONFIG_MODULE_UNLOAD=y
> -# CONFIG_ARCH_MULTI_V7 is not set
> -CONFIG_ARCH_VERSATILE=y
> -CONFIG_PCI=y
> -CONFIG_PCI_VERSATILE=y
> -CONFIG_AEABI=y
> -CONFIG_NET=y
> -CONFIG_PACKET=y
> -CONFIG_UNIX=y
> -CONFIG_INET=y
> -CONFIG_SCSI=y
> -CONFIG_BLK_DEV_SD=y
> -CONFIG_SCSI_SYM53C8XX_2=y
> -CONFIG_NETDEVICES=y
> -CONFIG_8139CP=y
> -CONFIG_PHYLIB=y
> -CONFIG_INPUT_EVDEV=y
> -CONFIG_SERIO_AMBAKMI=y
> -CONFIG_LEGACY_PTY_COUNT=16
> -CONFIG_SERIAL_8250=m
> -CONFIG_SERIAL_8250_EXTENDED=y
> -CONFIG_SERIAL_8250_MANY_PORTS=y
> -CONFIG_SERIAL_8250_SHARE_IRQ=y
> -CONFIG_SERIAL_8250_RSA=y
> -CONFIG_SERIAL_AMBA_PL011=y
> -CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
> -CONFIG_I2C=y
> -CONFIG_I2C_CHARDEV=m
> -CONFIG_FB=y
> -CONFIG_FB_ARMCLCD=y
> -CONFIG_FRAMEBUFFER_CONSOLE=y
> -CONFIG_SOUND=y
> -CONFIG_SND=m
> -CONFIG_SND_MIXER_OSS=m
> -CONFIG_SND_PCM_OSS=m
> -CONFIG_SND_ARMAACI=m
> -CONFIG_EXT4_FS=y
> -CONFIG_VFAT_FS=m
> -CONFIG_TMPFS=y
> -CONFIG_TMPFS_POSIX_ACL=y
> -CONFIG_MAGIC_SYSRQ=y
> diff --git a/board/qemu/arm-versatile/linux.config.fragment b/board/qemu/arm-versatile/linux.config.fragment
> new file mode 100644
> index 0000000000..0aed558315
> --- /dev/null
> +++ b/board/qemu/arm-versatile/linux.config.fragment
> @@ -0,0 +1,66 @@
> +# CONFIG_BLK_DEV_INITRD is not set
> +# CONFIG_BLK_DEV_RAM is not set
> +# CONFIG_CMA is not set
> +# CONFIG_CRAMFS is not set
> +CONFIG_CMDLINE=""
> +CONFIG_CRC16=y
> +CONFIG_CRYPTO=y
> +# CONFIG_DEBUG_FS is not set
> +# CONFIG_DEBUG_KERNEL is not set
> +# CONFIG_DEBUG_USER is not set
> +CONFIG_DEVTMPFS=y
> +# CONFIG_DRM is not set
> +# CONFIG_EEPROM_LEGACY is not set
> +# CONFIG_EXT2_FS is not set
> +CONFIG_EXT4_FS=y
> +CONFIG_FB_ARMCLCD=y
> +# CONFIG_FONTS is not set
> +CONFIG_FONT_8x16=y
> +CONFIG_FONT_8x8=y
> +# CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY is not set
> +# CONFIG_FTRACE is not set
> +# CONFIG_GPIOLIB is not set
> +# CONFIG_HIGH_RES_TIMERS is not set
> +CONFIG_HWMON=y
> +CONFIG_HZ_PERIODIC=y
> +# CONFIG_I2C_VERSATILE is not set
> +CONFIG_INET_DIAG=y
> +CONFIG_INPUT_EVDEV=y
> +CONFIG_IPV6=y
> +# CONFIG_IP_MULTICAST is not set
> +# CONFIG_IP_PNP is not set
> +CONFIG_LOCALVERSION_AUTO=y
> +# CONFIG_LOGO is not set
> +CONFIG_LOG_BUF_SHIFT=17
> +CONFIG_MDIO_DEVICE=y
> +# CONFIG_MINIX_FS is not set
> +# CONFIG_MMC is not set
> +# CONFIG_MTD is not set
> +# CONFIG_NEW_LEDS is not set
> +# CONFIG_NFSD is not set
> +# CONFIG_NFS_FS is not set
> +# CONFIG_NLS_CODEPAGE_850 is not set
> +# CONFIG_NLS_ISO8859_1 is not set
> +# CONFIG_NO_HZ_IDLE is not set
> +# CONFIG_NVMEM is not set
> +# CONFIG_OABI_COMPAT is not set
> +# CONFIG_PARTITION_ADVANCED is not set
> +CONFIG_PCI=y
> +CONFIG_PCI_VERSATILE=y
> +CONFIG_PHYLIB=y
> +# CONFIG_ROMFS_FS is not set
> +# CONFIG_RTC_CLASS is not set
> +CONFIG_SCSI=y
> +CONFIG_SCSI_SPI_ATTRS=y
> +CONFIG_SCSI_SYM53C8XX_2=y
> +CONFIG_SERIO_SERPORT=y
> +CONFIG_SLUB=y
> +# CONFIG_SPI is not set
> +# CONFIG_SYNC_FILE is not set
> +CONFIG_TMPFS=y
> +CONFIG_TMPFS_POSIX_ACL=y
> +CONFIG_TMPFS_XATTR=y
> +# CONFIG_VFP is not set
> +# CONFIG_XZ_DEC is not set
> +CONFIG_8139CP=y
> +CONFIG_BLK_DEV_SD=y
> diff --git a/configs/qemu_arm_versatile_defconfig b/configs/qemu_arm_versatile_defconfig
> index 10dd9e52b4..f4950ca2d8 100644
> --- a/configs/qemu_arm_versatile_defconfig
> +++ b/configs/qemu_arm_versatile_defconfig
> @@ -21,8 +21,8 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_10=y
> BR2_LINUX_KERNEL=y
> BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.10.7"
> -BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
> -BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/arm-versatile/linux.config"
> +BR2_LINUX_KERNEL_DEFCONFIG="versatile"
> +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/qemu/arm-versatile/linux.config.fragment"
> BR2_LINUX_KERNEL_DTS_SUPPORT=y
> BR2_LINUX_KERNEL_INTREE_DTS_NAME="versatile-pb"
>
> --
> 2.27.0
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] qemu_arm_versatile: switch to in-kernel defconfig + fragment
2021-03-16 14:38 [Buildroot] [PATCH 1/2] qemu_arm_versatile: switch to in-kernel defconfig + fragment Masahiro Yamada
2021-03-16 14:38 ` [Buildroot] [PATCH 2/2] qemu_arm_versatile_nommu: " Masahiro Yamada
2021-03-16 14:55 ` [Buildroot] [PATCH 1/2] qemu_arm_versatile: " Masahiro Yamada
@ 2022-01-08 14:09 ` Romain Naour
2022-01-08 14:13 ` Thomas Petazzoni
2022-01-08 14:16 ` Arnout Vandecappelle
2 siblings, 2 replies; 6+ messages in thread
From: Romain Naour @ 2022-01-08 14:09 UTC (permalink / raw)
To: Masahiro Yamada, buildroot; +Cc: Thomas Petazzoni
Hello Masahiro, All
Le 16/03/2021 à 15:38, Masahiro Yamada a écrit :
> This platform has its own kernel defconfig in Buildroot, but we cannot
> get quick idea about how much it diverged from the in-kernel defconfig.
>
> Let's use the upstream arch/arm/config/versatile_defconfig as a base,
> and maintain the diff as a merge-config fragment. The same .config is
> still generated based on the 5.10.7 kernel.
>
> The diff is quite big, but this is a good start-point for cleanups.
> Follow-up works can drop diff lines unless we find a good reason for
> divergence.
We use a custom kernel defconfig for this defconfig since it was added to
Buildroot [1].
I guess the aim of having a custom kernel defconfig is to reduce the build time.
This defconfig is used for boot testing on Qemu, I'm not sure if it really used
for other use case.
Have you tested without any additional fragment?
[1]
https://git.buildroot.net/buildroot/commit/?id=d3789ce3b70aaaa5e180d041b2ad282b36d929ed
Best regards,
Romain
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] qemu_arm_versatile: switch to in-kernel defconfig + fragment
2022-01-08 14:09 ` Romain Naour
@ 2022-01-08 14:13 ` Thomas Petazzoni
2022-01-08 14:16 ` Arnout Vandecappelle
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2022-01-08 14:13 UTC (permalink / raw)
To: Romain Naour; +Cc: buildroot, Masahiro Yamada
On Sat, 8 Jan 2022 15:09:56 +0100
Romain Naour <romain.naour@smile.fr> wrote:
> We use a custom kernel defconfig for this defconfig since it was added to
> Buildroot [1].
>
> I guess the aim of having a custom kernel defconfig is to reduce the build time.
Most likely yes, but when I see the fragment, it indeed disables a lot
of things, which is nice as it speed up the build. Just like on x86,
you could build the full defconfig to have something that boots under
qemu, but having a stripped down configuration is a lot more
useful/practical;
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] qemu_arm_versatile: switch to in-kernel defconfig + fragment
2022-01-08 14:09 ` Romain Naour
2022-01-08 14:13 ` Thomas Petazzoni
@ 2022-01-08 14:16 ` Arnout Vandecappelle
1 sibling, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2022-01-08 14:16 UTC (permalink / raw)
To: Romain Naour, Masahiro Yamada, buildroot; +Cc: Thomas Petazzoni
On 08/01/2022 15:09, Romain Naour wrote:
> Hello Masahiro, All
>
> Le 16/03/2021 à 15:38, Masahiro Yamada a écrit :
>> This platform has its own kernel defconfig in Buildroot, but we cannot
>> get quick idea about how much it diverged from the in-kernel defconfig.
>>
>> Let's use the upstream arch/arm/config/versatile_defconfig as a base,
>> and maintain the diff as a merge-config fragment. The same .config is
>> still generated based on the 5.10.7 kernel.
>>
>> The diff is quite big, but this is a good start-point for cleanups.
>> Follow-up works can drop diff lines unless we find a good reason for
>> divergence.
>
> We use a custom kernel defconfig for this defconfig since it was added to
> Buildroot [1].
... And at that time I don't think we had infrastructure for fragments yet.
>
> I guess the aim of having a custom kernel defconfig is to reduce the build time.
Even so, it's better to have the difference as a fragment rather than having a
full config, so at least we can easily see the difference (as Masahiro mentions
in the commit message).
> This defconfig is used for boot testing on Qemu, I'm not sure if it really used
> for other use case.
>
> Have you tested without any additional fragment?
Masahiro mentions that it yields exactly the same full config, so this is
perfect to keep the reduced build time. We can decide later whether or not we
want to move closer to the upstream defconfig.
So, applied both to master, thanks! Sorry it took so long.
Regards,
Arnout
>
> [1]
> https://git.buildroot.net/buildroot/commit/?id=d3789ce3b70aaaa5e180d041b2ad282b36d929ed
>
> Best regards,
> Romain
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-08 14:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-16 14:38 [Buildroot] [PATCH 1/2] qemu_arm_versatile: switch to in-kernel defconfig + fragment Masahiro Yamada
2021-03-16 14:38 ` [Buildroot] [PATCH 2/2] qemu_arm_versatile_nommu: " Masahiro Yamada
2021-03-16 14:55 ` [Buildroot] [PATCH 1/2] qemu_arm_versatile: " Masahiro Yamada
2022-01-08 14:09 ` Romain Naour
2022-01-08 14:13 ` Thomas Petazzoni
2022-01-08 14:16 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox