* [Buildroot] [PATCH v2 1/1] core/pkg-utils: add missing bracket/sep
@ 2022-01-09 6:44 James Hilliard
2022-01-09 7:27 ` Arnout Vandecappelle
0 siblings, 1 reply; 2+ messages in thread
From: James Hilliard @ 2022-01-09 6:44 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard
This appears to have been incorrectly removed in:
03aa3e6ac71a0fe1ff87fe192c8de0b1acebd0df
Fixes:
package/pkg-utils.mk:212: *** unterminated call to function 'foreach': missing ')'. Stop.
make: *** [Makefile:84: _all] Error 2
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
Changes v1 -> v2:
- add sep as well
---
package/pkg-utils.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
index 6aa64a2096..7d1aea7710 100644
--- a/package/pkg-utils.mk
+++ b/package/pkg-utils.mk
@@ -214,7 +214,7 @@ define per-package-rsync
$(foreach pkg,$(1),\
rsync -a --link-dest=$(PER_PACKAGE_DIR)/$(pkg)/$(2)/ \
$(PER_PACKAGE_DIR)/$(pkg)/$(2)/ \
- $(3)
+ $(3)$(sep))
endef
# prepares the per-package HOST_DIR and TARGET_DIR of the current
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH v2 1/1] core/pkg-utils: add missing bracket/sep
2022-01-09 6:44 [Buildroot] [PATCH v2 1/1] core/pkg-utils: add missing bracket/sep James Hilliard
@ 2022-01-09 7:27 ` Arnout Vandecappelle
0 siblings, 0 replies; 2+ messages in thread
From: Arnout Vandecappelle @ 2022-01-09 7:27 UTC (permalink / raw)
To: James Hilliard, buildroot
On 09/01/2022 07:44, James Hilliard wrote:
> This appears to have been incorrectly removed in:
> 03aa3e6ac71a0fe1ff87fe192c8de0b1acebd0df
>
> Fixes:
> package/pkg-utils.mk:212: *** unterminated call to function 'foreach': missing ')'. Stop.
> make: *** [Makefile:84: _all] Error 2
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Applied to master, thanks.
Regards,
Arnout
> ---
> Changes v1 -> v2:
> - add sep as well
> ---
> package/pkg-utils.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> index 6aa64a2096..7d1aea7710 100644
> --- a/package/pkg-utils.mk
> +++ b/package/pkg-utils.mk
> @@ -214,7 +214,7 @@ define per-package-rsync
> $(foreach pkg,$(1),\
> rsync -a --link-dest=$(PER_PACKAGE_DIR)/$(pkg)/$(2)/ \
> $(PER_PACKAGE_DIR)/$(pkg)/$(2)/ \
> - $(3)
> + $(3)$(sep))
> endef
>
> # prepares the per-package HOST_DIR and TARGET_DIR of the current
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-09 7:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-09 6:44 [Buildroot] [PATCH v2 1/1] core/pkg-utils: add missing bracket/sep James Hilliard
2022-01-09 7:27 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox