From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org, Jared Bents <jared.bents@rockwellcollins.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/libvirt: libvirtd needs C++
Date: Sun, 9 Jan 2022 22:58:03 +0100 [thread overview]
Message-ID: <20220109215803.GJ1477939@scaer> (raw)
In-Reply-To: <20220109204853.GH1477939@scaer>
Fabrice, All,
On 2022-01-09 21:48 +0100, Yann E. MORIN spake thusly:
> On 2022-01-09 21:20 +0100, Fabrice Fontaine spake thusly:
> > Fix the following build failure raised since commit
> > fbf25acfbfd5a73b3560918bea081768abbe5723:
> >
> > WARNING: unmet direct dependencies detected for BR2_PACKAGE_NMAP
> > Depends on [n]: BR2_INSTALL_LIBSTDCPP [=n] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y]
> > Selected by [y]:
> > - BR2_PACKAGE_LIBVIRT_DAEMON [=y] && BR2_PACKAGE_LIBVIRT [=y] && !BR2_PACKAGE_NETCAT_OPENBSD [=n]
> >
> > Fixes:
> > - No autobuilder failures (yet)
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > package/libvirt/Config.in | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/package/libvirt/Config.in b/package/libvirt/Config.in
> > index a35295bc97..d7ca5f8db5 100644
> > --- a/package/libvirt/Config.in
> > +++ b/package/libvirt/Config.in
> > @@ -37,6 +37,7 @@ if BR2_PACKAGE_LIBVIRT
> > config BR2_PACKAGE_LIBVIRT_DAEMON
> > bool "libvirtd"
> > default y
> > + depends on BR2_INSTALL_LIBSTDCPP # nmap
>
> In fact, the requirement on C++ is due to nmap-ncat, which is enabled
> only if netcat-openbsd is not available, so I relaxed the requirement
> accordingly.
This introduced a messy circular dependency, so I pushed another patch
that;
- remove the C++ dependency
- switches the nmap-ncat and netcat-openbsd conditional dependnecies
Regards,
Yann E. MORIN.
> Applied to master, thanks.
>
> Regards,
> Yann E. MORIN.
>
> > select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> > select BR2_PACKAGE_DNSMASQ
> > select BR2_PACKAGE_EBTABLES
> > @@ -50,6 +51,9 @@ config BR2_PACKAGE_LIBVIRT_DAEMON
> > Build the libvirt daemon (libvirtd) otherwise build only the
> > utility programs.
> >
> > +comment "libvirtd needs a toolchain w/ C++"
> > + depends on !BR2_INSTALL_LIBSTDCPP
> > +
> > # Stateful drivers are useful only when building the daemon.
> > if BR2_PACKAGE_LIBVIRT_DAEMON
> >
> > --
> > 2.34.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-01-09 21:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 20:20 [Buildroot] [PATCH 1/1] package/libvirt: libvirtd needs C++ Fabrice Fontaine
2022-01-09 20:48 ` Yann E. MORIN
2022-01-09 21:58 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220109215803.GJ1477939@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=jared.bents@rockwellcollins.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox