* [Buildroot] [PATCH 1/1] package/libvirt: libvirtd needs C++
@ 2022-01-09 20:20 Fabrice Fontaine
2022-01-09 20:48 ` Yann E. MORIN
0 siblings, 1 reply; 3+ messages in thread
From: Fabrice Fontaine @ 2022-01-09 20:20 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine, Jared Bents
Fix the following build failure raised since commit
fbf25acfbfd5a73b3560918bea081768abbe5723:
WARNING: unmet direct dependencies detected for BR2_PACKAGE_NMAP
Depends on [n]: BR2_INSTALL_LIBSTDCPP [=n] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y]
Selected by [y]:
- BR2_PACKAGE_LIBVIRT_DAEMON [=y] && BR2_PACKAGE_LIBVIRT [=y] && !BR2_PACKAGE_NETCAT_OPENBSD [=n]
Fixes:
- No autobuilder failures (yet)
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/libvirt/Config.in | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/libvirt/Config.in b/package/libvirt/Config.in
index a35295bc97..d7ca5f8db5 100644
--- a/package/libvirt/Config.in
+++ b/package/libvirt/Config.in
@@ -37,6 +37,7 @@ if BR2_PACKAGE_LIBVIRT
config BR2_PACKAGE_LIBVIRT_DAEMON
bool "libvirtd"
default y
+ depends on BR2_INSTALL_LIBSTDCPP # nmap
select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
select BR2_PACKAGE_DNSMASQ
select BR2_PACKAGE_EBTABLES
@@ -50,6 +51,9 @@ config BR2_PACKAGE_LIBVIRT_DAEMON
Build the libvirt daemon (libvirtd) otherwise build only the
utility programs.
+comment "libvirtd needs a toolchain w/ C++"
+ depends on !BR2_INSTALL_LIBSTDCPP
+
# Stateful drivers are useful only when building the daemon.
if BR2_PACKAGE_LIBVIRT_DAEMON
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libvirt: libvirtd needs C++
2022-01-09 20:20 [Buildroot] [PATCH 1/1] package/libvirt: libvirtd needs C++ Fabrice Fontaine
@ 2022-01-09 20:48 ` Yann E. MORIN
2022-01-09 21:58 ` Yann E. MORIN
0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2022-01-09 20:48 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Jared Bents, buildroot
Fabrice, All,
You little joker, sending a fix right when I was applying your bump...
;-)
On 2022-01-09 21:20 +0100, Fabrice Fontaine spake thusly:
> Fix the following build failure raised since commit
> fbf25acfbfd5a73b3560918bea081768abbe5723:
>
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_NMAP
> Depends on [n]: BR2_INSTALL_LIBSTDCPP [=n] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y]
> Selected by [y]:
> - BR2_PACKAGE_LIBVIRT_DAEMON [=y] && BR2_PACKAGE_LIBVIRT [=y] && !BR2_PACKAGE_NETCAT_OPENBSD [=n]
>
> Fixes:
> - No autobuilder failures (yet)
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/libvirt/Config.in | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/libvirt/Config.in b/package/libvirt/Config.in
> index a35295bc97..d7ca5f8db5 100644
> --- a/package/libvirt/Config.in
> +++ b/package/libvirt/Config.in
> @@ -37,6 +37,7 @@ if BR2_PACKAGE_LIBVIRT
> config BR2_PACKAGE_LIBVIRT_DAEMON
> bool "libvirtd"
> default y
> + depends on BR2_INSTALL_LIBSTDCPP # nmap
In fact, the requirement on C++ is due to nmap-ncat, which is enabled
only if netcat-openbsd is not available, so I relaxed the requirement
accordingly.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> select BR2_PACKAGE_DNSMASQ
> select BR2_PACKAGE_EBTABLES
> @@ -50,6 +51,9 @@ config BR2_PACKAGE_LIBVIRT_DAEMON
> Build the libvirt daemon (libvirtd) otherwise build only the
> utility programs.
>
> +comment "libvirtd needs a toolchain w/ C++"
> + depends on !BR2_INSTALL_LIBSTDCPP
> +
> # Stateful drivers are useful only when building the daemon.
> if BR2_PACKAGE_LIBVIRT_DAEMON
>
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libvirt: libvirtd needs C++
2022-01-09 20:48 ` Yann E. MORIN
@ 2022-01-09 21:58 ` Yann E. MORIN
0 siblings, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2022-01-09 21:58 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot, Jared Bents
Fabrice, All,
On 2022-01-09 21:48 +0100, Yann E. MORIN spake thusly:
> On 2022-01-09 21:20 +0100, Fabrice Fontaine spake thusly:
> > Fix the following build failure raised since commit
> > fbf25acfbfd5a73b3560918bea081768abbe5723:
> >
> > WARNING: unmet direct dependencies detected for BR2_PACKAGE_NMAP
> > Depends on [n]: BR2_INSTALL_LIBSTDCPP [=n] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y]
> > Selected by [y]:
> > - BR2_PACKAGE_LIBVIRT_DAEMON [=y] && BR2_PACKAGE_LIBVIRT [=y] && !BR2_PACKAGE_NETCAT_OPENBSD [=n]
> >
> > Fixes:
> > - No autobuilder failures (yet)
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > package/libvirt/Config.in | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/package/libvirt/Config.in b/package/libvirt/Config.in
> > index a35295bc97..d7ca5f8db5 100644
> > --- a/package/libvirt/Config.in
> > +++ b/package/libvirt/Config.in
> > @@ -37,6 +37,7 @@ if BR2_PACKAGE_LIBVIRT
> > config BR2_PACKAGE_LIBVIRT_DAEMON
> > bool "libvirtd"
> > default y
> > + depends on BR2_INSTALL_LIBSTDCPP # nmap
>
> In fact, the requirement on C++ is due to nmap-ncat, which is enabled
> only if netcat-openbsd is not available, so I relaxed the requirement
> accordingly.
This introduced a messy circular dependency, so I pushed another patch
that;
- remove the C++ dependency
- switches the nmap-ncat and netcat-openbsd conditional dependnecies
Regards,
Yann E. MORIN.
> Applied to master, thanks.
>
> Regards,
> Yann E. MORIN.
>
> > select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> > select BR2_PACKAGE_DNSMASQ
> > select BR2_PACKAGE_EBTABLES
> > @@ -50,6 +51,9 @@ config BR2_PACKAGE_LIBVIRT_DAEMON
> > Build the libvirt daemon (libvirtd) otherwise build only the
> > utility programs.
> >
> > +comment "libvirtd needs a toolchain w/ C++"
> > + depends on !BR2_INSTALL_LIBSTDCPP
> > +
> > # Stateful drivers are useful only when building the daemon.
> > if BR2_PACKAGE_LIBVIRT_DAEMON
> >
> > --
> > 2.34.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-09 21:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-09 20:20 [Buildroot] [PATCH 1/1] package/libvirt: libvirtd needs C++ Fabrice Fontaine
2022-01-09 20:48 ` Yann E. MORIN
2022-01-09 21:58 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox