From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: James Hilliard <james.hilliard1@gmail.com>,
Buildroot Mailing List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/gensio: add avahi optional dependency
Date: Thu, 13 Jan 2022 20:57:33 +0100 [thread overview]
Message-ID: <20220113205733.270b84f0@windsurf> (raw)
In-Reply-To: <CAPi7W80QXfaA5iTk5e2_deLChHSTPp8dO1rrhsuLE9ouJ5+cvw@mail.gmail.com>
On Mon, 10 Jan 2022 08:45:05 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> > > +GENSIO_DEPENDENCIES = $(if $(BR2_PACKAGE_AVAHI_DAEMON),avahi)
> >
> > In the commit message you talk about avahi-client, but here it's avahi-daemon.
> > That looks a bit weird... Can you explain?
> avahi-client needs avahi-daemon and dbus but perhaps we should add a
> BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT hidden option.
I suppose you will rework this patch with the new avahi hidden option
that you have added? I'll mark this particular patch as Changes
Requested.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-01-13 19:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 20:41 [Buildroot] [PATCH 1/1] package/gensio: add avahi optional dependency Fabrice Fontaine
2022-01-10 7:13 ` Arnout Vandecappelle
2022-01-10 7:45 ` Fabrice Fontaine
2022-01-13 19:57 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220113205733.270b84f0@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=james.hilliard1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox