[Buildroot] [PATCH 1/1] package/gensio: add avahi optional dependency

[Buildroot] [PATCH 1/1] package/gensio: add avahi optional dependency

[Fabrice Fontaine]

avahi-client is an optional dependency which is enabled by default since
version 2.2.0 and
https://github.com/cminyard/gensio/commit/5ab117c9743fd4719f610cf9f1ba45023cc25d7c

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/gensio/gensio.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/gensio/gensio.mk b/package/gensio/gensio.mk
index 389de1e263..b4936d5f21 100644
--- a/package/gensio/gensio.mk
+++ b/package/gensio/gensio.mk
@@ -9,6 +9,7 @@ GENSIO_SITE = http://downloads.sourceforge.net/project/ser2net/ser2net
 GENSIO_LICENSE = LGPL-2.1+ (library), GPL-2.0+ (tools)
 GENSIO_LICENSE_FILES = COPYING.LIB COPYING
 GENSIO_INSTALL_STAGING = YES
+GENSIO_DEPENDENCIES = $(if $(BR2_PACKAGE_AVAHI_DAEMON),avahi)
 GENSIO_CONF_OPTS = \
 	--without-openipmi \
 	--without-swig \
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/gensio: add avahi optional dependency

[Arnout Vandecappelle]

On 04/01/2022 21:41, Fabrice Fontaine wrote:
> avahi-client is an optional dependency which is enabled by default since
> version 2.2.0 and
> https://github.com/cminyard/gensio/commit/5ab117c9743fd4719f610cf9f1ba45023cc25d7c
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>   package/gensio/gensio.mk | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/package/gensio/gensio.mk b/package/gensio/gensio.mk
> index 389de1e263..b4936d5f21 100644
> --- a/package/gensio/gensio.mk
> +++ b/package/gensio/gensio.mk
> @@ -9,6 +9,7 @@ GENSIO_SITE = http://downloads.sourceforge.net/project/ser2net/ser2net
>   GENSIO_LICENSE = LGPL-2.1+ (library), GPL-2.0+ (tools)
>   GENSIO_LICENSE_FILES = COPYING.LIB COPYING
>   GENSIO_INSTALL_STAGING = YES
> +GENSIO_DEPENDENCIES = $(if $(BR2_PACKAGE_AVAHI_DAEMON),avahi)

  In the commit message you talk about avahi-client, but here it's avahi-daemon. 
That looks a bit weird... Can you explain?

  Regards,
  Arnout

>   GENSIO_CONF_OPTS = \
>   	--without-openipmi \
>   	--without-swig \
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/gensio: add avahi optional dependency

[Fabrice Fontaine]

Le lun. 10 janv. 2022 à 08:13, Arnout Vandecappelle <arnout@mind.be> a écrit :
>
>
>
> On 04/01/2022 21:41, Fabrice Fontaine wrote:
> > avahi-client is an optional dependency which is enabled by default since
> > version 2.2.0 and
> > https://github.com/cminyard/gensio/commit/5ab117c9743fd4719f610cf9f1ba45023cc25d7c
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >   package/gensio/gensio.mk | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/package/gensio/gensio.mk b/package/gensio/gensio.mk
> > index 389de1e263..b4936d5f21 100644
> > --- a/package/gensio/gensio.mk
> > +++ b/package/gensio/gensio.mk
> > @@ -9,6 +9,7 @@ GENSIO_SITE = http://downloads.sourceforge.net/project/ser2net/ser2net
> >   GENSIO_LICENSE = LGPL-2.1+ (library), GPL-2.0+ (tools)
> >   GENSIO_LICENSE_FILES = COPYING.LIB COPYING
> >   GENSIO_INSTALL_STAGING = YES
> > +GENSIO_DEPENDENCIES = $(if $(BR2_PACKAGE_AVAHI_DAEMON),avahi)
>
>   In the commit message you talk about avahi-client, but here it's avahi-daemon.
> That looks a bit weird... Can you explain?
 avahi-client needs avahi-daemon and dbus but perhaps we should add a
BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT hidden option.
>
>   Regards,
>   Arnout
>
> >   GENSIO_CONF_OPTS = \
> >       --without-openipmi \
> >       --without-swig \
> >
Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/gensio: add avahi optional dependency

[Thomas Petazzoni]

On Mon, 10 Jan 2022 08:45:05 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> > > +GENSIO_DEPENDENCIES = $(if $(BR2_PACKAGE_AVAHI_DAEMON),avahi)  
> >
> >   In the commit message you talk about avahi-client, but here it's avahi-daemon.
> > That looks a bit weird... Can you explain?  
>  avahi-client needs avahi-daemon and dbus but perhaps we should add a
> BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT hidden option.

I suppose you will rework this patch with the new avahi hidden option
that you have added? I'll mark this particular patch as Changes
Requested.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot