* [Buildroot] [PATCH 1/1] Dependency on liburiparser was removed
@ 2022-01-19 15:57 Tilman Keskinöz
2022-01-19 20:33 ` Yann E. MORIN
0 siblings, 1 reply; 2+ messages in thread
From: Tilman Keskinöz @ 2022-01-19 15:57 UTC (permalink / raw)
To: buildroot; +Cc: arved
From: Tilman Keskinöz <arved@arved.at>
Dependency was removed from Makefile in
593683b45f72169dd94ec14fa18720b3cec9dda4
Signed-off-by: Tilman Keskinöz <arved@arved.at>
---
package/tpm2-tss/Config.in | 1 -
1 file changed, 1 deletion(-)
diff --git a/package/tpm2-tss/Config.in b/package/tpm2-tss/Config.in
index 2fc56dbd76..857987ae36 100644
--- a/package/tpm2-tss/Config.in
+++ b/package/tpm2-tss/Config.in
@@ -1,7 +1,6 @@
config BR2_PACKAGE_TPM2_TSS
bool "tpm2-tss"
depends on !BR2_STATIC_LIBS # dlfcn.h
- select BR2_PACKAGE_LIBURIPARSER
select BR2_PACKAGE_OPENSSL
select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL
help
--
2.32.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH 1/1] Dependency on liburiparser was removed
2022-01-19 15:57 [Buildroot] [PATCH 1/1] Dependency on liburiparser was removed Tilman Keskinöz
@ 2022-01-19 20:33 ` Yann E. MORIN
0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2022-01-19 20:33 UTC (permalink / raw)
To: Tilman Keskinöz; +Cc: buildroot
Tilman, All,
On 2022-01-19 16:57 +0100, Tilman Keskinöz spake thusly:
> From: Tilman Keskinöz <arved@arved.at>
>
> Dependency was removed from Makefile in
> 593683b45f72169dd94ec14fa18720b3cec9dda4
The commit title should mention the impacted package, and mention an
action in the infinitive tense, like so:
package/tpm2-tss: do not select liburiparser
The commit log was mostly OK, if a bit confusing, so I reworded it with:
Commit 593683b45f72 (package/tpm2-tss: remove unused dependency)
removed the build-time dependency (in the .mk), but forgot to
remove it from the Config.in.
Applied to master with those changes (and for good measure, a typo of
mine that I noticed too late, sorry). Thanks!
Regards,
Yann E. MORIN.
> Signed-off-by: Tilman Keskinöz <arved@arved.at>
> ---
> package/tpm2-tss/Config.in | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/package/tpm2-tss/Config.in b/package/tpm2-tss/Config.in
> index 2fc56dbd76..857987ae36 100644
> --- a/package/tpm2-tss/Config.in
> +++ b/package/tpm2-tss/Config.in
> @@ -1,7 +1,6 @@
> config BR2_PACKAGE_TPM2_TSS
> bool "tpm2-tss"
> depends on !BR2_STATIC_LIBS # dlfcn.h
> - select BR2_PACKAGE_LIBURIPARSER
> select BR2_PACKAGE_OPENSSL
> select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL
> help
> --
> 2.32.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-19 20:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-19 15:57 [Buildroot] [PATCH 1/1] Dependency on liburiparser was removed Tilman Keskinöz
2022-01-19 20:33 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox