Re: [Buildroot] [PATCH 1/1] package/network-manager: add optional nmcli support

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Michael Fischer <mf@go-sys.de>, buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH 1/1] package/network-manager: add optional nmcli support
Date: Wed, 26 Jan 2022 23:28:00 +0100	[thread overview]
Message-ID: <20220126222800.GL457876@scaer> (raw)
In-Reply-To: <20220126231432.37374caf@windsurf>

Thomas, Michael, All,

On 2022-01-26 23:14 +0100, Thomas Petazzoni spake thusly:
> On Wed, 26 Jan 2022 10:04:57 +0100
> Michael Fischer <mf@go-sys.de> wrote:
[--SNIP--]
> > +config BR2_PACKAGE_NETWORK_MANAGER_CLI
> > +        bool "nmcli support"
> > +        select BR2_PACKAGE_READLINE
> > +        help
> > +          This option enables support for NetworkManager Command Line Interface
> 
> I think this line is too long, make sure to run "make check-package".
> 
> But a bigger problem is the legacy handling. Indeed, before your patch,
> a configuration with BR2_PACKAGE_NETWORK_MANAGER=y and
> BR2_PACKAGE_READLINE=y gets nmcli. After your patch, such a
> configuration no longer has nmcli compiled, because
> BR2_PACKAGE_NETWORK_MANAGER_CLI is not enabled.

I was also looking at that patch, and was wondering what we could do.
I do not like efaulting symbols to 'y', even conditionally, and I would
also expect people to regression-test their systems when they upgrade
anyway.

> Is this important to address, I don't know.
> 
> Is it possible to address is by doing:
> 
> config BR2_PACKAGE_NETWORK_MANAGER_CLI
> 	 bool "nmcli support"
> 	 default y if BR2_PACKAGE_READLINE
> 	 select BR2_PACKAGE_READLINE
> 
> I don't know if Kconfig is happy about such a construct. Yann? :-)

No it is not valid: you have both a backward and a forward dependency
that drive the availability of the symbol:

    package/readline/Config.in:1:error: recursive dependency detected!
    package/readline/Config.in:1:   symbol BR2_PACKAGE_READLINE is selected by BR2_PACKAGE_NETWORK_MANAGER_CLI
    package/network-manager/Config.in:36:   symbol BR2_PACKAGE_NETWORK_MANAGER_CLI depends on BR2_PACKAGE_READLINE
    For a resolution refer to Documentation/kbuild/kconfig-language.txt
    subsection "Kconfig recursive dependency limitations"

TBH, I would just leave it like that...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot