From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Michael Fischer <mf@go-sys.de>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH v2 1/1] package/network-manager: add optional nmcli support
Date: Sun, 21 Aug 2022 17:29:42 +0200 [thread overview]
Message-ID: <20220821152942.GY2775145@scaer> (raw)
In-Reply-To: <20220127104658.9895-1-mf@go-sys.de>
Michael, All,
On 2022-01-27 11:46 +0100, Michael Fischer spake thusly:
> The network-manager package builds the nmcli utility when the
> readline package is enabled. However, this is not necessarily
> obvious to the user. Therefore, this commit adds an explicit
> option to enable the nmcli tool, which automatically selects readline.
>
> Signed-off-by: Michael Fischer <mf@go-sys.de>
Applied to master^Wnext, thanks.
Regards,
Yann E. MORIN.
> ---
> package/network-manager/Config.in | 8 +++++++-
> package/network-manager/network-manager.mk | 2 +-
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/package/network-manager/Config.in b/package/network-manager/Config.in
> index a48cb37b15..f61a046a95 100644
> --- a/package/network-manager/Config.in
> +++ b/package/network-manager/Config.in
> @@ -37,6 +37,13 @@ config BR2_PACKAGE_NETWORK_MANAGER_TUI
> help
> This option enables terminal based UI
>
> +config BR2_PACKAGE_NETWORK_MANAGER_CLI
> + bool "nmcli support"
> + select BR2_PACKAGE_READLINE
> + help
> + This option enables support for the
> + NetworkManager Command Line Interface
> +
> config BR2_PACKAGE_NETWORK_MANAGER_MODEM_MANAGER
> bool "modem-manager support"
> select BR2_PACKAGE_MODEM_MANAGER
> @@ -54,7 +61,6 @@ config BR2_PACKAGE_NETWORK_MANAGER_OVS
> select BR2_PACKAGE_JANSSON
> help
> This option enables support for OpenVSwitch
> -
> endif
>
> comment "NetworkManager needs udev /dev management and a glibc toolchain w/ headers >= 4.6, dynamic library, wchar, threads, gcc >= 4.9"
> diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk
> index 974320fce0..1eb9233b44 100644
> --- a/package/network-manager/network-manager.mk
> +++ b/package/network-manager/network-manager.mk
> @@ -135,7 +135,7 @@ else
> NETWORK_MANAGER_CONF_OPTS += --disable-polkit
> endif
>
> -ifeq ($(BR2_PACKAGE_READLINE),y)
> +ifeq ($(BR2_PACKAGE_NETWORK_MANAGER_CLI),y)
> NETWORK_MANAGER_DEPENDENCIES += readline
> NETWORK_MANAGER_CONF_OPTS += --with-nmcli
> else
> --
> 2.20.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-08-21 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 9:04 [Buildroot] [PATCH 1/1] package/network-manager: add optional nmcli support Michael Fischer
2022-01-26 22:14 ` Thomas Petazzoni
2022-01-26 22:28 ` Yann E. MORIN
2022-01-27 10:46 ` [Buildroot] [PATCH v2 " Michael Fischer
2022-08-21 15:29 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220821152942.GY2775145@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
--cc=mf@go-sys.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox