Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/xvisor: drop arm support
Date: Wed, 26 Jan 2022 23:32:04 +0100	[thread overview]
Message-ID: <20220126233204.36d9c37c@windsurf> (raw)
In-Reply-To: <20220125190650.107677-1-fontaine.fabrice@gmail.com>

On Tue, 25 Jan 2022 20:06:49 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Support for old 32-bit ARM boards (i.e. ARMv5, ARMv6, ARMv7a) without
> virtualization has been dropped since
> https://github.com/xvisor/xvisor/commit/9fcd69692484e0f6aa5036c27196f55c797582c5
> resulting in the following build failure since bump to version 0.3.1 in
> commit c4f8b8968770ecbf6444a5921c6472f126717626:
> 
> *** Can't find default configuration "/home/giuliobenetti/autobuild/run/instance-3/output-1/build/xvisor-0.3.1/arch/arm/configs/generic-v6-defconfig"!
> 
> *** Can't find default configuration "/home/giuliobenetti/autobuild/run/instance-0/output-1/build/xvisor-0.3.1/arch/arm/configs/generic-v7-defconfig"!
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/1211bf6ff10c75815fa3ac320532fab5fe649a2b
>  - http://autobuild.buildroot.org/results/2bcbbb270df71d2489b7bc83e56c898c58cc90d2
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/xvisor/Config.in | 6 +-----
>  package/xvisor/xvisor.mk | 2 +-
>  2 files changed, 2 insertions(+), 6 deletions(-)

I think this is based on a misunderstanding of the
https://github.com/xvisor/xvisor/commit/9fcd69692484e0f6aa5036c27196f55c797582c5
commit. This commit says that they remove support for "ARM32 without
virtualization support", but there are ARM32 cores with virtualization
support! As explained in the commit log, the ARM32 cores that support
the ARMv7ve instruction set are still supported by Xvisor.

This means that Cortex-A7, Cortex-A12, Cortex-A15 and Cortex-A17, which
are all ARM32 cores, are still supported by Xvisor. So this patch
entirely dropping ARM32 from Xvisor isn't entirely correct.

So, the change should be more like this:

config BR2_PACKAGE_XVISOR_ARCH_SUPPORTS
	bool
	depends on BR2_USE_MMU
	default y if BR2_aarch64
	default y if BR2_x86_64
	default y if BR2_cortex_a7 || BR2_cortex_a12 || BR2_cortex_a15 || BR2_cortex_a17

 config BR2_PACKAGE_XVISOR_DEFCONFIG
 	string "Defconfig name"
-	default "generic-v5" if BR2_ARM_CPU_ARMV5
-	default "generic-v6" if BR2_ARM_CPU_ARMV6
-	default "generic-v7" if BR2_ARM_CPU_ARMV7A
+	default "generic-v7-ve" if BR2_ARM_CPU_ARMV7A
 	default "generic-v8" if BR2_aarch64
 	default "x86_64_generic" if BR2_x86_64

What do you think ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-01-26 22:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25 19:06 [Buildroot] [PATCH 1/2] package/xvisor: drop arm support Fabrice Fontaine
2022-01-25 19:06 ` [Buildroot] [PATCH 2/2] package/xvisor: add riscv support Fabrice Fontaine
2022-01-26 22:49   ` Alistair Francis
2022-01-26 22:32 ` Thomas Petazzoni [this message]
2022-01-26 22:38   ` [Buildroot] [PATCH 1/2] package/xvisor: drop arm support Fabrice Fontaine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220126233204.36d9c37c@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=eric.le.bihan.dev@free.fr \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox