* [Buildroot] [PATCH 1/2] package/xvisor: drop arm support
@ 2022-01-25 19:06 Fabrice Fontaine
2022-01-25 19:06 ` [Buildroot] [PATCH 2/2] package/xvisor: add riscv support Fabrice Fontaine
2022-01-26 22:32 ` [Buildroot] [PATCH 1/2] package/xvisor: drop arm support Thomas Petazzoni
0 siblings, 2 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2022-01-25 19:06 UTC (permalink / raw)
To: buildroot; +Cc: Eric Le Bihan, Fabrice Fontaine
Support for old 32-bit ARM boards (i.e. ARMv5, ARMv6, ARMv7a) without
virtualization has been dropped since
https://github.com/xvisor/xvisor/commit/9fcd69692484e0f6aa5036c27196f55c797582c5
resulting in the following build failure since bump to version 0.3.1 in
commit c4f8b8968770ecbf6444a5921c6472f126717626:
*** Can't find default configuration "/home/giuliobenetti/autobuild/run/instance-3/output-1/build/xvisor-0.3.1/arch/arm/configs/generic-v6-defconfig"!
*** Can't find default configuration "/home/giuliobenetti/autobuild/run/instance-0/output-1/build/xvisor-0.3.1/arch/arm/configs/generic-v7-defconfig"!
Fixes:
- http://autobuild.buildroot.org/results/1211bf6ff10c75815fa3ac320532fab5fe649a2b
- http://autobuild.buildroot.org/results/2bcbbb270df71d2489b7bc83e56c898c58cc90d2
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/xvisor/Config.in | 6 +-----
package/xvisor/xvisor.mk | 2 +-
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/package/xvisor/Config.in b/package/xvisor/Config.in
index eb7475b86d..55c43e6959 100644
--- a/package/xvisor/Config.in
+++ b/package/xvisor/Config.in
@@ -2,8 +2,7 @@ config BR2_PACKAGE_XVISOR_ARCH_SUPPORTS
bool
default y
depends on BR2_USE_MMU
- depends on BR2_arm || BR2_aarch64 || BR2_x86_64
- depends on !BR2_ARM_CPU_ARMV4 && !BR2_ARM_CPU_ARMV7M
+ depends on BR2_aarch64 || BR2_x86_64
menuconfig BR2_PACKAGE_XVISOR
bool "xvisor"
@@ -32,9 +31,6 @@ endchoice
config BR2_PACKAGE_XVISOR_DEFCONFIG
string "Defconfig name"
- default "generic-v5" if BR2_ARM_CPU_ARMV5
- default "generic-v6" if BR2_ARM_CPU_ARMV6
- default "generic-v7" if BR2_ARM_CPU_ARMV7A
default "generic-v8" if BR2_aarch64
default "x86_64_generic" if BR2_x86_64
depends on BR2_PACKAGE_XVISOR_USE_DEFCONFIG
diff --git a/package/xvisor/xvisor.mk b/package/xvisor/xvisor.mk
index dc49258400..4ceb5ed7cb 100644
--- a/package/xvisor/xvisor.mk
+++ b/package/xvisor/xvisor.mk
@@ -30,7 +30,7 @@ XVISOR_KCONFIG_EDITORS = menuconfig
ifeq ($(BR2_x86_64),y)
XVISOR_ARCH = x86
-else ifeq ($(BR2_arm)$(BR2_aarch64),y)
+else ifeq ($(BR2_aarch64),y)
XVISOR_ARCH = arm
endif
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] package/xvisor: add riscv support
2022-01-25 19:06 [Buildroot] [PATCH 1/2] package/xvisor: drop arm support Fabrice Fontaine
@ 2022-01-25 19:06 ` Fabrice Fontaine
2022-01-26 22:49 ` Alistair Francis
2022-01-26 22:32 ` [Buildroot] [PATCH 1/2] package/xvisor: drop arm support Thomas Petazzoni
1 sibling, 1 reply; 5+ messages in thread
From: Fabrice Fontaine @ 2022-01-25 19:06 UTC (permalink / raw)
To: buildroot; +Cc: Eric Le Bihan, Fabrice Fontaine
riscv is supported since version 0.3.0 and
https://github.com/xvisor/xvisor/commit/d6feda4e80eefd372294b081111ce709d08ee4c0
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/xvisor/Config.in | 4 +++-
package/xvisor/xvisor.mk | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/package/xvisor/Config.in b/package/xvisor/Config.in
index 55c43e6959..4e7a3e1b53 100644
--- a/package/xvisor/Config.in
+++ b/package/xvisor/Config.in
@@ -2,7 +2,7 @@ config BR2_PACKAGE_XVISOR_ARCH_SUPPORTS
bool
default y
depends on BR2_USE_MMU
- depends on BR2_aarch64 || BR2_x86_64
+ depends on BR2_aarch64 || BR2_riscv || BR2_x86_64
menuconfig BR2_PACKAGE_XVISOR
bool "xvisor"
@@ -32,6 +32,8 @@ endchoice
config BR2_PACKAGE_XVISOR_DEFCONFIG
string "Defconfig name"
default "generic-v8" if BR2_aarch64
+ default "generic-32b" if BR2_RISCV_32
+ default "generic-64b" if BR2_RISCV_64
default "x86_64_generic" if BR2_x86_64
depends on BR2_PACKAGE_XVISOR_USE_DEFCONFIG
help
diff --git a/package/xvisor/xvisor.mk b/package/xvisor/xvisor.mk
index 4ceb5ed7cb..1a7b49e689 100644
--- a/package/xvisor/xvisor.mk
+++ b/package/xvisor/xvisor.mk
@@ -32,6 +32,8 @@ ifeq ($(BR2_x86_64),y)
XVISOR_ARCH = x86
else ifeq ($(BR2_aarch64),y)
XVISOR_ARCH = arm
+else ifeq ($(BR2_riscv),y)
+XVISOR_ARCH = riscv
endif
ifeq ($(BR2_PACKAGE_XVISOR)$(BR_BUILDING),yy)
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/xvisor: add riscv support
2022-01-25 19:06 ` [Buildroot] [PATCH 2/2] package/xvisor: add riscv support Fabrice Fontaine
@ 2022-01-26 22:49 ` Alistair Francis
0 siblings, 0 replies; 5+ messages in thread
From: Alistair Francis @ 2022-01-26 22:49 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Eric Le Bihan, buildroot
On Wed, Jan 26, 2022 at 5:09 AM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> riscv is supported since version 0.3.0 and
> https://github.com/xvisor/xvisor/commit/d6feda4e80eefd372294b081111ce709d08ee4c0
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> package/xvisor/Config.in | 4 +++-
> package/xvisor/xvisor.mk | 2 ++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/package/xvisor/Config.in b/package/xvisor/Config.in
> index 55c43e6959..4e7a3e1b53 100644
> --- a/package/xvisor/Config.in
> +++ b/package/xvisor/Config.in
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_XVISOR_ARCH_SUPPORTS
> bool
> default y
> depends on BR2_USE_MMU
> - depends on BR2_aarch64 || BR2_x86_64
> + depends on BR2_aarch64 || BR2_riscv || BR2_x86_64
>
> menuconfig BR2_PACKAGE_XVISOR
> bool "xvisor"
> @@ -32,6 +32,8 @@ endchoice
> config BR2_PACKAGE_XVISOR_DEFCONFIG
> string "Defconfig name"
> default "generic-v8" if BR2_aarch64
> + default "generic-32b" if BR2_RISCV_32
> + default "generic-64b" if BR2_RISCV_64
> default "x86_64_generic" if BR2_x86_64
> depends on BR2_PACKAGE_XVISOR_USE_DEFCONFIG
> help
> diff --git a/package/xvisor/xvisor.mk b/package/xvisor/xvisor.mk
> index 4ceb5ed7cb..1a7b49e689 100644
> --- a/package/xvisor/xvisor.mk
> +++ b/package/xvisor/xvisor.mk
> @@ -32,6 +32,8 @@ ifeq ($(BR2_x86_64),y)
> XVISOR_ARCH = x86
> else ifeq ($(BR2_aarch64),y)
> XVISOR_ARCH = arm
> +else ifeq ($(BR2_riscv),y)
> +XVISOR_ARCH = riscv
> endif
>
> ifeq ($(BR2_PACKAGE_XVISOR)$(BR_BUILDING),yy)
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/xvisor: drop arm support
2022-01-25 19:06 [Buildroot] [PATCH 1/2] package/xvisor: drop arm support Fabrice Fontaine
2022-01-25 19:06 ` [Buildroot] [PATCH 2/2] package/xvisor: add riscv support Fabrice Fontaine
@ 2022-01-26 22:32 ` Thomas Petazzoni
2022-01-26 22:38 ` Fabrice Fontaine
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2022-01-26 22:32 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Eric Le Bihan, buildroot
On Tue, 25 Jan 2022 20:06:49 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Support for old 32-bit ARM boards (i.e. ARMv5, ARMv6, ARMv7a) without
> virtualization has been dropped since
> https://github.com/xvisor/xvisor/commit/9fcd69692484e0f6aa5036c27196f55c797582c5
> resulting in the following build failure since bump to version 0.3.1 in
> commit c4f8b8968770ecbf6444a5921c6472f126717626:
>
> *** Can't find default configuration "/home/giuliobenetti/autobuild/run/instance-3/output-1/build/xvisor-0.3.1/arch/arm/configs/generic-v6-defconfig"!
>
> *** Can't find default configuration "/home/giuliobenetti/autobuild/run/instance-0/output-1/build/xvisor-0.3.1/arch/arm/configs/generic-v7-defconfig"!
>
> Fixes:
> - http://autobuild.buildroot.org/results/1211bf6ff10c75815fa3ac320532fab5fe649a2b
> - http://autobuild.buildroot.org/results/2bcbbb270df71d2489b7bc83e56c898c58cc90d2
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/xvisor/Config.in | 6 +-----
> package/xvisor/xvisor.mk | 2 +-
> 2 files changed, 2 insertions(+), 6 deletions(-)
I think this is based on a misunderstanding of the
https://github.com/xvisor/xvisor/commit/9fcd69692484e0f6aa5036c27196f55c797582c5
commit. This commit says that they remove support for "ARM32 without
virtualization support", but there are ARM32 cores with virtualization
support! As explained in the commit log, the ARM32 cores that support
the ARMv7ve instruction set are still supported by Xvisor.
This means that Cortex-A7, Cortex-A12, Cortex-A15 and Cortex-A17, which
are all ARM32 cores, are still supported by Xvisor. So this patch
entirely dropping ARM32 from Xvisor isn't entirely correct.
So, the change should be more like this:
config BR2_PACKAGE_XVISOR_ARCH_SUPPORTS
bool
depends on BR2_USE_MMU
default y if BR2_aarch64
default y if BR2_x86_64
default y if BR2_cortex_a7 || BR2_cortex_a12 || BR2_cortex_a15 || BR2_cortex_a17
config BR2_PACKAGE_XVISOR_DEFCONFIG
string "Defconfig name"
- default "generic-v5" if BR2_ARM_CPU_ARMV5
- default "generic-v6" if BR2_ARM_CPU_ARMV6
- default "generic-v7" if BR2_ARM_CPU_ARMV7A
+ default "generic-v7-ve" if BR2_ARM_CPU_ARMV7A
default "generic-v8" if BR2_aarch64
default "x86_64_generic" if BR2_x86_64
What do you think ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/xvisor: drop arm support
2022-01-26 22:32 ` [Buildroot] [PATCH 1/2] package/xvisor: drop arm support Thomas Petazzoni
@ 2022-01-26 22:38 ` Fabrice Fontaine
0 siblings, 0 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2022-01-26 22:38 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Eric Le Bihan, Buildroot Mailing List
Le mer. 26 janv. 2022 à 23:32, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a écrit :
>
> On Tue, 25 Jan 2022 20:06:49 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > Support for old 32-bit ARM boards (i.e. ARMv5, ARMv6, ARMv7a) without
> > virtualization has been dropped since
> > https://github.com/xvisor/xvisor/commit/9fcd69692484e0f6aa5036c27196f55c797582c5
> > resulting in the following build failure since bump to version 0.3.1 in
> > commit c4f8b8968770ecbf6444a5921c6472f126717626:
> >
> > *** Can't find default configuration "/home/giuliobenetti/autobuild/run/instance-3/output-1/build/xvisor-0.3.1/arch/arm/configs/generic-v6-defconfig"!
> >
> > *** Can't find default configuration "/home/giuliobenetti/autobuild/run/instance-0/output-1/build/xvisor-0.3.1/arch/arm/configs/generic-v7-defconfig"!
> >
> > Fixes:
> > - http://autobuild.buildroot.org/results/1211bf6ff10c75815fa3ac320532fab5fe649a2b
> > - http://autobuild.buildroot.org/results/2bcbbb270df71d2489b7bc83e56c898c58cc90d2
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > package/xvisor/Config.in | 6 +-----
> > package/xvisor/xvisor.mk | 2 +-
> > 2 files changed, 2 insertions(+), 6 deletions(-)
>
> I think this is based on a misunderstanding of the
> https://github.com/xvisor/xvisor/commit/9fcd69692484e0f6aa5036c27196f55c797582c5
> commit. This commit says that they remove support for "ARM32 without
> virtualization support", but there are ARM32 cores with virtualization
> support! As explained in the commit log, the ARM32 cores that support
> the ARMv7ve instruction set are still supported by Xvisor.
>
> This means that Cortex-A7, Cortex-A12, Cortex-A15 and Cortex-A17, which
> are all ARM32 cores, are still supported by Xvisor. So this patch
> entirely dropping ARM32 from Xvisor isn't entirely correct.
>
> So, the change should be more like this:
>
> config BR2_PACKAGE_XVISOR_ARCH_SUPPORTS
> bool
> depends on BR2_USE_MMU
> default y if BR2_aarch64
> default y if BR2_x86_64
> default y if BR2_cortex_a7 || BR2_cortex_a12 || BR2_cortex_a15 || BR2_cortex_a17
>
> config BR2_PACKAGE_XVISOR_DEFCONFIG
> string "Defconfig name"
> - default "generic-v5" if BR2_ARM_CPU_ARMV5
> - default "generic-v6" if BR2_ARM_CPU_ARMV6
> - default "generic-v7" if BR2_ARM_CPU_ARMV7A
> + default "generic-v7-ve" if BR2_ARM_CPU_ARMV7A
> default "generic-v8" if BR2_aarch64
> default "x86_64_generic" if BR2_x86_64
>
> What do you think ?
You have more knowledge than me on ARM32. I'll send a v2 of the serie.
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,
Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-26 22:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-25 19:06 [Buildroot] [PATCH 1/2] package/xvisor: drop arm support Fabrice Fontaine
2022-01-25 19:06 ` [Buildroot] [PATCH 2/2] package/xvisor: add riscv support Fabrice Fontaine
2022-01-26 22:49 ` Alistair Francis
2022-01-26 22:32 ` [Buildroot] [PATCH 1/2] package/xvisor: drop arm support Thomas Petazzoni
2022-01-26 22:38 ` Fabrice Fontaine
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox