Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: "Yann E . MORIN" <yann.morin.1998@free.fr>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure
Date: Wed, 2 Feb 2022 22:40:46 +0100	[thread overview]
Message-ID: <20220202224046.1ccef19a@gmx.net> (raw)
In-Reply-To: <48ab9669-d467-a394-12a2-fd229f6229f0@benettiengineering.com>

Hello Giulio,

On Wed, 2 Feb 2022 22:09:22 +0100, Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Hi Peter,
>
> On 02/02/22 21:42, Peter Seiderer wrote:
> > Hello Arnout, Giulio,
> >
> > On Wed, 2 Feb 2022 08:41:34 +0100, Arnout Vandecappelle <arnout@mind.be> wrote:
> >
> >> On 02/02/2022 00:22, Giulio Benetti wrote:
> >>> The UTIL_LINUX_FIX_DISK_UTILS_COMPILE workaround is needed for host
> >>> building too. So let's add it to HOST_UTIL_LINUX_POST_PATCH_HOOKS.
> >>> host-util-linux is used a lot, so this patch fixes a lot of future
> >>> builds.
> >>
> >>    Darn, I tested that, both with and without BR2_PACKAGE_HOST_UTIL_LINUX set. I
> >> don't understand what went wrong in my test...
> >
> > The raw support depends on the available toolchain headers, see e.g.
> > package/util-linux/Config.in:
> >
> > 	config BR2_PACKAGE_UTIL_LINUX_RAW
> > 	        bool "raw"
> > 	        depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_14
> > 	        help
> > 	          Build a linux raw character device
> >
> > Or according to [1] '--disable-raw' for the host build should do
> > the trick too...
>
> I was in hurry to produce the patch last night, so I went for the
> fastest way. Can you give a try with --disable-raw and eventually submit

Thanks for taking care!

> the patch? That would save some time while building. Also because
> host-util-linux is used a lot

Sorry, could not reproduce the host-build failure on my system, seems the
toolchain is too up-to-date (openSUSE Tumbleweed - gcc-11.2.1) ;-)

But can provide an RFC patch for testing...

Regards,
Peter

>
> Thank you!
> Best regards

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-02-02 21:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 23:22 [Buildroot] [URGENT 0/1] This patch is needed for host-util-linux Giulio Benetti
2022-02-01 23:22 ` [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure Giulio Benetti
2022-02-01 23:25   ` Giulio Benetti
2022-02-02  7:41   ` Arnout Vandecappelle
2022-02-02 20:42     ` Peter Seiderer
2022-02-02 21:09       ` Giulio Benetti
2022-02-02 21:40         ` Peter Seiderer [this message]
2022-02-02 21:54           ` Giulio Benetti
2022-02-02 22:05             ` [Buildroot] [PATCH] package/util-linux: improve host build failure fix Giulio Benetti
2022-02-03 20:23               ` Peter Seiderer
2022-02-03 22:29                 ` Giulio Benetti
2022-02-03 22:31                 ` [Buildroot] [PATCH v2] " Giulio Benetti
2022-02-12 22:02                   ` Arnout Vandecappelle
2022-02-02 22:10           ` [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220202224046.1ccef19a@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox